All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 18/23] drm/i915: Add WaDisableGafsUnitClkGating for skl and kbl
Date: Thu, 26 May 2016 18:29:41 +0300	[thread overview]
Message-ID: <1464276586-17939-19-git-send-email-mika.kuoppala@intel.com> (raw)
In-Reply-To: <1464276586-17939-1-git-send-email-mika.kuoppala@intel.com>

We need this gafs bit to be enabled for hw fix to
take effect.

References: HSD#2227156, HSD#2227050
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h         | 1 +
 drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 77f5edc5f915..509238561935 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -6084,6 +6084,7 @@ enum skl_disp_power_wells {
 
 #define GEN9_CS_DEBUG_MODE1		_MMIO(0x20ec)
 #define GEN8_CS_CHICKEN1		_MMIO(0x2580)
+#define GEN8_CS_CHICKEN2		_MMIO(0x2194)
 
 /* GEN7 chicken */
 #define GEN7_COMMON_SLICE_CHICKEN1		_MMIO(0x7010)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index d60b7a3ebb47..234f0e288f44 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1118,6 +1118,9 @@ static int skl_init_workarounds(struct intel_engine_cs *engine)
 			GEN7_HALF_SLICE_CHICKEN1,
 			GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
 
+	/* WaDisableGafsUnitClkGating:skl */
+	WA_SET_BIT(GEN8_CS_CHICKEN2, (1 << 1));
+
 	/* WaDisableLSQCROPERFforOCL:skl */
 	ret = wa_ring_whitelist_reg(engine, GEN8_L3SQCREG4);
 	if (ret)
@@ -1215,6 +1218,9 @@ static int kbl_init_workarounds(struct intel_engine_cs *engine)
 		WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
 				  GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
 
+	/* WaDisableGafsUnitClkGating:kbl */
+	WA_SET_BIT(GEN8_CS_CHICKEN2, (1 << 1));
+
 	/* WaDisableLSQCROPERFforOCL:kbl */
 	ret = wa_ring_whitelist_reg(engine, GEN8_L3SQCREG4);
 	if (ret)
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-05-26 15:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 15:29 [PATCH 00/23] kbl and gen9 workarounds Mika Kuoppala
2016-05-26 15:29 ` [PATCH 01/23] drm/i915/kbl: Init " Mika Kuoppala
2016-05-26 15:29 ` [PATCH 02/23] drm/i915/kbl: Add REVID macro Mika Kuoppala
2016-05-26 15:29 ` [PATCH 03/23] drm/i915/kbl: Add WaSkipStolenMemoryFirstPage for A0 Mika Kuoppala
2016-05-26 15:29 ` [PATCH 04/23] drm/i915/gen9: Always apply WaForceContextSaveRestoreNonCoherent Mika Kuoppala
2016-05-26 15:29 ` [PATCH 05/23] drm/i915: Mimic skl with WaForceEnableNonCoherent Mika Kuoppala
2016-05-26 15:29 ` [PATCH 06/23] drm/i915/kbl: Add WaEnableGapsTsvCreditFix Mika Kuoppala
2016-05-27  8:14   ` Arun Siluvery
2016-05-26 15:29 ` [PATCH 07/23] drm/i915/kbl: Add WaDisableFenceDestinationToSLM for A0 Mika Kuoppala
2016-05-26 15:29 ` [PATCH 08/23] drm/i915/kbl: Add WaDisableSDEUnitClockGating Mika Kuoppala
2016-05-26 15:29 ` [PATCH 09/23] drm/i915/edp: Add WaKVMNotificationOnConfigChange:bdw, skl Mika Kuoppala
2016-05-27  8:18   ` Mika Kuoppala
2016-05-26 15:29 ` [PATCH 10/23] drm/i915/kbl: Add WaDisableLSQCROPERFforOCL Mika Kuoppala
2016-05-26 15:29 ` [PATCH 11/23] drm/i915/gen9: Enable must set chicken bits in config0 reg Mika Kuoppala
2016-05-26 15:29 ` [PATCH 12/23] drm/i915/kbl: Add WaDisableGamClockGating Mika Kuoppala
2016-05-26 15:29 ` [PATCH 13/23] drm/i915/kbl: Add WaDisableDynamicCreditSharing Mika Kuoppala
2016-05-26 15:29 ` [PATCH 14/23] drm/i915: Add WaInsertDummyPushConstP for bxt and kbl Mika Kuoppala
2016-05-26 15:29 ` [PATCH 15/23] drm/i915/gen9: Add WaDisableSkipCaching Mika Kuoppala
2016-05-26 15:29 ` [PATCH 16/23] drm/i915/skl: Add WAC6entrylatency Mika Kuoppala
2016-05-26 15:29 ` [PATCH 17/23] drm/i915/kbl: Add WaForGAMHang Mika Kuoppala
2016-05-26 15:29 ` Mika Kuoppala [this message]
2016-05-26 15:29 ` [PATCH 19/23] drm/i915/kbl: Add WaDisableSbeCacheDispatchPortSharing Mika Kuoppala
2016-05-26 15:29 ` [PATCH 20/23] drm/i915/gen9: Set wa for display underrun issues with Y & Yf Tiling Mika Kuoppala
2016-05-26 16:53   ` [PATCH 20/23] drm/i915/gen9: Add WaEnableChickenDCPR Mika Kuoppala
2016-05-26 15:29 ` [PATCH 21/23] drm/i915/gen9: Set fbc watermarks disabled Mika Kuoppala
2016-05-26 15:53   ` Ville Syrjälä
2016-05-26 16:06     ` Ville Syrjälä
2016-05-26 16:54   ` [PATCH 21/23] drm/i915/gen9: Add WaFbcTurnOffFbcWatermark Mika Kuoppala
2016-05-26 15:29 ` [PATCH 22/23] drm/i915/gen9: Prevent fbc corruption/system hangs with high bw Mika Kuoppala
2016-05-26 16:54   ` [PATCH 22/23] drm/i915/gen9: Add WaFbcWakeMemOn Mika Kuoppala
2016-05-26 15:29 ` [PATCH 23/23] drm/i195/fbc: Enable wa to prevent fbc corruption with skl and kbl Mika Kuoppala
2016-05-26 16:55   ` [PATCH 23/23] drm/i195/fbc: Add WaFbcNukeOnHostModify Mika Kuoppala
2016-05-26 16:37 ` ✗ Ro.CI.BAT: warning for kbl and gen9 workarounds Patchwork
2016-05-26 17:37 ` ✗ Ro.CI.BAT: warning for kbl and gen9 workarounds (rev5) Patchwork
2016-06-06  7:51 ` [PATCH 00/23] kbl and gen9 workarounds Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464276586-17939-19-git-send-email-mika.kuoppala@intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.