All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 09/24] drm/i915/edp: Add WaKVMNotificationOnConfigChange:bdw
Date: Fri, 27 May 2016 17:26:49 +0300	[thread overview]
Message-ID: <1464359224-11436-10-git-send-email-mika.kuoppala@intel.com> (raw)
In-Reply-To: <1464359224-11436-1-git-send-email-mika.kuoppala@intel.com>

According to bspec this workaround helps to reduce lag and improve
performance on edp.

Documentation suggests this for bdw and all gen9. However evidence
shows that this register is missing on gen9 and causing unclaimed mmio
access if we access it. So apply to bdw only where the reg
exists and can hold its value.

v2: drop skl

References: HSD#2134579
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 3 +++
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index e3077259541a..1f84c2ff3563 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -6035,6 +6035,9 @@ enum skl_disp_power_wells {
 #define  FORCE_ARB_IDLE_PLANES	(1 << 14)
 #define  SKL_EDP_PSR_FIX_RDWRAP	(1 << 3)
 
+#define CHICKEN_PAR2_1		_MMIO(0x42090)
+#define  KVM_CONFIG_CHANGE_NOTIFICATION_SELECT	(1 << 14)
+
 #define _CHICKEN_PIPESL_1_A	0x420b0
 #define _CHICKEN_PIPESL_1_B	0x420b4
 #define  HSW_FBCQ_DIS			(1 << 22)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index fc34add6ab82..a6cb2e55afe2 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6916,6 +6916,10 @@ static void broadwell_init_clock_gating(struct drm_device *dev)
 	 */
 	I915_WRITE(HSW_GTT_CACHE_EN, GTT_CACHE_EN_ALL);
 
+	/* WaKVMNotificationOnConfigChange:bdw */
+	I915_WRITE(CHICKEN_PAR2_1, I915_READ(CHICKEN_PAR2_1)
+		   | KVM_CONFIG_CHANGE_NOTIFICATION_SELECT);
+
 	lpt_init_clock_gating(dev);
 }
 
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-05-27 14:26 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 14:26 [PATCH 00/24] kbl and gen9 workarounds v2 Mika Kuoppala
2016-05-27 14:26 ` [PATCH 01/24] drm/i915/kbl: Init gen9 workarounds Mika Kuoppala
2016-06-01 16:11   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 02/24] drm/i915/kbl: Add REVID macro Mika Kuoppala
2016-06-01 14:15   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 03/24] drm/i915/kbl: Add WaSkipStolenMemoryFirstPage for A0 Mika Kuoppala
2016-06-01 14:34   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 04/24] drm/i915/gen9: Always apply WaForceContextSaveRestoreNonCoherent Mika Kuoppala
2016-06-01 14:43   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 05/24] drm/i915: Mimic skl with WaForceEnableNonCoherent Mika Kuoppala
2016-06-01 15:10   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 06/24] drm/i915/kbl: Add WaEnableGapsTsvCreditFix Mika Kuoppala
2016-06-01 16:05   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 07/24] drm/i915/kbl: Add WaDisableFenceDestinationToSLM for A0 Mika Kuoppala
2016-05-27 14:59   ` Chris Wilson
2016-05-30 15:09   ` [PATCH 07/25] " Mika Kuoppala
2016-06-02  9:14     ` Matthew Auld
2016-05-27 14:26 ` [PATCH 08/24] drm/i915/kbl: Add WaDisableSDEUnitClockGating Mika Kuoppala
2016-06-02  9:24   ` Matthew Auld
2016-05-27 14:26 ` Mika Kuoppala [this message]
2016-06-02  9:35   ` [PATCH 09/24] drm/i915/edp: Add WaKVMNotificationOnConfigChange:bdw Matthew Auld
2016-05-27 14:26 ` [PATCH 10/24] drm/i915/kbl: Add WaDisableLSQCROPERFforOCL Mika Kuoppala
2016-06-02  9:55   ` Matthew Auld
2016-06-02  9:58   ` [PATCH 10/25] " Mika Kuoppala
2016-06-06 15:10     ` Matthew Auld
2016-05-27 14:26 ` [PATCH 11/24] drm/i915/gen9: Enable must set chicken bits in config0 reg Mika Kuoppala
2016-06-02 12:29   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 12/24] drm/i915/kbl: Add WaDisableGamClockGating Mika Kuoppala
2016-06-03 14:08   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 13/24] drm/i915/kbl: Add WaDisableDynamicCreditSharing Mika Kuoppala
2016-06-03 17:15   ` Matthew Auld
2016-06-06 12:56     ` Mika Kuoppala
2016-05-27 14:26 ` [PATCH 14/24] drm/i915: Add WaInsertDummyPushConstP for bxt and kbl Mika Kuoppala
2016-06-02 12:59   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 15/24] drm/i915/gen9: Add WaDisableSkipCaching Mika Kuoppala
2016-06-07 10:09   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 16/24] drm/i915/skl: Add WAC6entrylatency Mika Kuoppala
2016-06-02 13:10   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 17/24] drm/i915/kbl: Add WaForGAMHang Mika Kuoppala
2016-06-03 15:35   ` Matthew Auld
2016-05-27 14:26 ` [PATCH 18/24] drm/i915: Add WaDisableGafsUnitClkGating for skl and kbl Mika Kuoppala
2016-05-27 14:49   ` Ville Syrjälä
2016-05-30 15:09   ` [PATCH 18/25] " Mika Kuoppala
2016-05-27 14:26 ` [PATCH 19/24] drm/i915/kbl: Add WaDisableSbeCacheDispatchPortSharing Mika Kuoppala
2016-06-02 13:15   ` Matthew Auld
2016-05-27 14:27 ` [PATCH 20/24] drm/i915/gen9: Add WaEnableChickenDCPR Mika Kuoppala
2016-06-03 15:49   ` Matthew Auld
2016-05-27 14:27 ` [PATCH 21/24] drm/i915/gen9: Add WaFbcTurnOffFbcWatermark Mika Kuoppala
2016-05-27 14:48   ` Ville Syrjälä
2016-05-30 15:10   ` [PATCH 21/25] " Mika Kuoppala
2016-06-01 14:04     ` Ville Syrjälä
2016-05-27 14:27 ` [PATCH 22/24] drm/i915/gen9: Add WaFbcWakeMemOn Mika Kuoppala
2016-06-01 15:05   ` Ville Syrjälä
2016-06-06 13:10     ` Mika Kuoppala
2016-05-27 14:27 ` [PATCH 23/24] drm/i195/fbc: Add WaFbcNukeOnHostModify Mika Kuoppala
2016-06-01 14:54   ` Ville Syrjälä
2016-05-27 14:27 ` [PATCH 24/24] drm/i915/skl: Extend WaDisableChickenBitTSGBarrierAckForFFSliceCS Mika Kuoppala
2016-06-02 13:21   ` Matthew Auld
2016-05-27 14:57 ` ✗ Ro.CI.BAT: failure for kbl and gen9 workarounds (rev6) Patchwork
2016-05-30 15:11 ` [PATCH 25/25] drm/i915/kbl: Add WaClearSlmSpaceAtContextSwitch Mika Kuoppala
2016-06-03 16:01   ` Matthew Auld
2016-06-04  8:54     ` Arun Siluvery
2016-06-06 10:04       ` Matthew Auld
2016-06-06 13:00       ` Mika Kuoppala
2016-05-31 10:30 ` ✗ Ro.CI.BAT: warning for kbl and gen9 workarounds (rev9) Patchwork
2016-06-02 14:17 ` ✗ Ro.CI.BAT: warning for kbl and gen9 workarounds (rev10) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464359224-11436-10-git-send-email-mika.kuoppala@intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.