All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH 5/5] coresight: Cleanup TMC status check
Date: Tue, 31 May 2016 12:57:38 +0100	[thread overview]
Message-ID: <1464695858-29284-6-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1464695858-29284-1-git-send-email-suzuki.poulose@arm.com>

Use the defined symbol rather than hardcoding the value to
check whether the TMC buffer is full.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
index 847d1b5..b0dce93 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
@@ -65,7 +65,7 @@ static void tmc_etr_dump_hw(struct tmc_drvdata *drvdata)
 	val = readl_relaxed(drvdata->base + TMC_STS);
 
 	/* How much memory do we still have */
-	if (val & BIT(0))
+	if (val & TMC_STS_FULL)
 		drvdata->buf = drvdata->vaddr + rwp - drvdata->paddr;
 	else
 		drvdata->buf = drvdata->vaddr;
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: suzuki.poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] coresight: Cleanup TMC status check
Date: Tue, 31 May 2016 12:57:38 +0100	[thread overview]
Message-ID: <1464695858-29284-6-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1464695858-29284-1-git-send-email-suzuki.poulose@arm.com>

Use the defined symbol rather than hardcoding the value to
check whether the TMC buffer is full.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
index 847d1b5..b0dce93 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
@@ -65,7 +65,7 @@ static void tmc_etr_dump_hw(struct tmc_drvdata *drvdata)
 	val = readl_relaxed(drvdata->base + TMC_STS);
 
 	/* How much memory do we still have */
-	if (val & BIT(0))
+	if (val & TMC_STS_FULL)
 		drvdata->buf = drvdata->vaddr + rwp - drvdata->paddr;
 	else
 		drvdata->buf = drvdata->vaddr;
-- 
1.9.1

  parent reply	other threads:[~2016-05-31 11:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 11:57 [PATCH 0/5] coresight: Miscellaneous fixes Suzuki K Poulose
2016-05-31 11:57 ` Suzuki K Poulose
2016-05-31 11:57 ` [PATCH 1/5] coresight: Fix NULL pointer dereference in _coresight_build_path Suzuki K Poulose
2016-05-31 11:57   ` Suzuki K Poulose
2016-05-31 17:39   ` Mathieu Poirier
2016-05-31 17:39     ` Mathieu Poirier
2016-05-31 11:57 ` [PATCH 2/5] coresight: etmv4: Fix ETMv4x peripheral ID table Suzuki K Poulose
2016-05-31 11:57   ` Suzuki K Poulose
2016-05-31 17:45   ` Mathieu Poirier
2016-05-31 17:45     ` Mathieu Poirier
2016-05-31 11:57 ` [PATCH 3/5] coresight: Fix csdev connections initialisation Suzuki K Poulose
2016-05-31 11:57   ` Suzuki K Poulose
2016-05-31 17:55   ` Mathieu Poirier
2016-05-31 17:55     ` Mathieu Poirier
2016-06-01  9:30     ` Suzuki K Poulose
2016-06-01  9:30       ` Suzuki K Poulose
2016-05-31 11:57 ` [PATCH 4/5] coresight: Add better messages for coresight_timeout Suzuki K Poulose
2016-05-31 11:57   ` Suzuki K Poulose
2016-05-31 17:57   ` Mathieu Poirier
2016-05-31 17:57     ` Mathieu Poirier
2016-05-31 17:58   ` Joe Perches
2016-05-31 17:58     ` Joe Perches
2016-06-01  9:34     ` Suzuki K Poulose
2016-06-01  9:34       ` Suzuki K Poulose
2016-06-01 15:15       ` Mathieu Poirier
2016-06-01 15:15         ` Mathieu Poirier
2016-05-31 11:57 ` Suzuki K Poulose [this message]
2016-05-31 11:57   ` [PATCH 5/5] coresight: Cleanup TMC status check Suzuki K Poulose
2016-05-31 18:01   ` Mathieu Poirier
2016-05-31 18:01     ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464695858-29284-6-git-send-email-suzuki.poulose@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.