All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Cc: rogerq@ti.com, Peter Chen <peter.chen@freescale.com>,
	"Ivan T. Ivanov" <iivanov@mm-sol.com>,
	balbi@ti.com, kishon@ti.com,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [RFC v4 1/7] Documentation: extcon: usb-gpio: update usb-gpio binding description
Date: Wed, 08 Jun 2016 15:48:00 +0200	[thread overview]
Message-ID: <1465393686-16644-2-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1465393686-16644-1-git-send-email-k.kozlowski@samsung.com>

From: Robert Baldyga <r.baldyga@samsung.com>

Add information about VBUS pin detection support, 'debounce' property
and some other details.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 .../devicetree/bindings/extcon/extcon-usb-gpio.txt | 28 ++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
index af0b903de293..7096f399b771 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
+++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
@@ -1,16 +1,40 @@
 USB GPIO Extcon device
 
-This is a virtual device used to generate USB cable states from the USB ID pin
-connected to a GPIO pin.
+This is a virtual device used to generate USB cable states from the USB
+ID and VBUS signals connected to GPIO pins.
+
+The extcon cable states USB and USB_HOST are actually VBUS and !ID
+pin states and do not indicate what mode the USB needs to operate in.
+That decision is done by the USB stack.
+
+Some devices have only one of these GPIO pins, so we support cases when
+only one of them is present. Hence properties 'id-gpio' and 'vbus-gpio'
+are described as optional, but at least one of them has to be present
+in extcon-usb-gpio node.
+
+In general we have three cases:
+1. If VBUS and ID gpios are present we pass them as is
+	USB-HOST = !ID, USB = VBUS
+2. If only VBUS gpio is present we assume that ID pin is always High.
+	USB-HOST = false, USB = VBUS.
+3. If only ID pin is available we infer the VBUS pin states based on ID.
+	USB-HOST = !ID, USB = ID
 
 Required properties:
 - compatible: Should be "linux,extcon-usb-gpio"
+
+Optional properties
 - id-gpio: gpio for USB ID pin. See gpio binding.
+- vbus-gpio: gpio for USB VBUS pin. See gpio binding.
+- debounce: gpio debounce time in milliseconds (u32).
+
 
 Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
 	extcon_usb1 {
 		compatible = "linux,extcon-usb-gpio";
 		id-gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>;
+		vbus-gpio = <&gpio6 2 GPIO_ACTIVE_HIGH>;
+		debounce = <25>;
 	}
 
 	&omap_dwc3_1 {
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v4 1/7] Documentation: extcon: usb-gpio: update usb-gpio binding description
Date: Wed, 08 Jun 2016 15:48:00 +0200	[thread overview]
Message-ID: <1465393686-16644-2-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1465393686-16644-1-git-send-email-k.kozlowski@samsung.com>

From: Robert Baldyga <r.baldyga@samsung.com>

Add information about VBUS pin detection support, 'debounce' property
and some other details.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 .../devicetree/bindings/extcon/extcon-usb-gpio.txt | 28 ++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
index af0b903de293..7096f399b771 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
+++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
@@ -1,16 +1,40 @@
 USB GPIO Extcon device
 
-This is a virtual device used to generate USB cable states from the USB ID pin
-connected to a GPIO pin.
+This is a virtual device used to generate USB cable states from the USB
+ID and VBUS signals connected to GPIO pins.
+
+The extcon cable states USB and USB_HOST are actually VBUS and !ID
+pin states and do not indicate what mode the USB needs to operate in.
+That decision is done by the USB stack.
+
+Some devices have only one of these GPIO pins, so we support cases when
+only one of them is present. Hence properties 'id-gpio' and 'vbus-gpio'
+are described as optional, but at least one of them has to be present
+in extcon-usb-gpio node.
+
+In general we have three cases:
+1. If VBUS and ID gpios are present we pass them as is
+	USB-HOST = !ID, USB = VBUS
+2. If only VBUS gpio is present we assume that ID pin is always High.
+	USB-HOST = false, USB = VBUS.
+3. If only ID pin is available we infer the VBUS pin states based on ID.
+	USB-HOST = !ID, USB = ID
 
 Required properties:
 - compatible: Should be "linux,extcon-usb-gpio"
+
+Optional properties
 - id-gpio: gpio for USB ID pin. See gpio binding.
+- vbus-gpio: gpio for USB VBUS pin. See gpio binding.
+- debounce: gpio debounce time in milliseconds (u32).
+
 
 Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
 	extcon_usb1 {
 		compatible = "linux,extcon-usb-gpio";
 		id-gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>;
+		vbus-gpio = <&gpio6 2 GPIO_ACTIVE_HIGH>;
+		debounce = <25>;
 	}
 
 	&omap_dwc3_1 {
-- 
1.9.1

  reply	other threads:[~2016-06-08 13:48 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160608134820epcas1p4ee75a89888f2ae2adb733124a330bd2c@epcas1p4.samsung.com>
2016-06-08 13:47 ` [RFC v4 0/7] extcon: usb-gpio: fixes and improvements Krzysztof Kozlowski
2016-06-08 13:47   ` Krzysztof Kozlowski
2016-06-08 13:48   ` Krzysztof Kozlowski [this message]
2016-06-08 13:48     ` [RFC v4 1/7] Documentation: extcon: usb-gpio: update usb-gpio binding description Krzysztof Kozlowski
2016-06-10 14:00     ` Rob Herring
2016-06-10 14:00       ` Rob Herring
2016-06-10 14:00       ` Rob Herring
2016-06-08 13:48   ` [RFC v4 2/7] Revert "extcon: usb-gpio: switch to use pm wakeirq apis" Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-09  8:00     ` Roger Quadros
2016-06-09  8:00       ` Roger Quadros
2016-06-09  8:00       ` Roger Quadros
2016-06-09  8:10       ` Krzysztof Kozlowski
2016-06-09  8:10         ` Krzysztof Kozlowski
2016-06-09  8:20         ` Roger Quadros
2016-06-09  8:20           ` Roger Quadros
2016-06-09  8:20           ` Roger Quadros
2016-06-08 13:48   ` [RFC v4 3/7] extcon: Add raw VBUS and ID cable states Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-08 13:48   ` [RFC v4 4/7] extcon: usb-gpio: Add support for VBUS detection Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-09  8:38     ` Roger Quadros
2016-06-09  8:38       ` Roger Quadros
2016-06-09  8:38       ` Roger Quadros
2016-06-09  8:41       ` Roger Quadros
2016-06-09  8:41         ` Roger Quadros
2016-06-09  8:41         ` Roger Quadros
2016-06-09  8:43       ` Krzysztof Kozlowski
2016-06-09  8:43         ` Krzysztof Kozlowski
2016-06-09 12:13         ` Roger Quadros
2016-06-09 12:13           ` Roger Quadros
2016-06-09 12:13           ` Roger Quadros
2016-06-08 13:48   ` [RFC v4 5/7] extcon: usb-gpio: make debounce value configurable in devicetree Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-08 13:48   ` [RFC v4 6/7] ARM: exynos_defconfig: Enable EXTCON_USB_GPIO for Odroid XU3 USB OTG Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-08 13:48   ` [RFC v4 7/7] ARM: dts: exynos: Add extcon-usb-gpio node for Odroid XU3 Krzysztof Kozlowski
2016-06-08 13:48     ` Krzysztof Kozlowski
2016-06-09  8:35   ` [RFC v4 0/7] extcon: usb-gpio: fixes and improvements Chanwoo Choi
2016-06-09  8:35     ` Chanwoo Choi
2016-06-09  8:39     ` Krzysztof Kozlowski
2016-06-09  8:39       ` Krzysztof Kozlowski
2016-06-09  9:32       ` Chanwoo Choi
2016-06-09  9:32         ` Chanwoo Choi
2016-06-09  9:32         ` Chanwoo Choi
2016-08-01 12:23         ` Roger Quadros
2016-08-01 12:23           ` Roger Quadros
2016-08-01 12:23           ` Roger Quadros
2016-08-01 12:57           ` Chanwoo Choi
2016-08-01 12:57             ` Chanwoo Choi
2016-06-26 16:39   ` Tobias Jakobi
2016-06-26 16:39     ` Tobias Jakobi
2016-06-27  5:22     ` Krzysztof Kozlowski
2016-06-27  5:22       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465393686-16644-2-git-send-email-k.kozlowski@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=balbi@ti.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=iivanov@mm-sol.com \
    --cc=kgene@kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=peter.chen@freescale.com \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.