From: Sricharan R <sricharan@codeaurora.org> To: linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org, galak@codeaurora.org, linux-kernel@vger.kernel.org, andy.gross@linaro.org, linux-i2c@vger.kernel.org, agross@codeaurora.org, linux-arm-kernel@lists.infradead.org, nkaje@codeaurora.org, absahu@codeaurora.org Cc: sricharan@codeaurora.org Subject: [PATCH V4 2/3] i2c: qup: Fix wrong value of index variable Date: Fri, 10 Jun 2016 23:38:20 +0530 [thread overview] Message-ID: <1465582101-19391-3-git-send-email-sricharan@codeaurora.org> (raw) In-Reply-To: <1465582101-19391-1-git-send-email-sricharan@codeaurora.org> index gets incremented during check to determine if the messages can be transferred with dma. But not reset after that, resulting in wrong start value in subsequent loop, causing failure. Fix it. Signed-off-by: Sricharan R <sricharan@codeaurora.org> --- drivers/i2c/busses/i2c-qup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 43adc2d..b8116e5 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -1260,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap, } } + idx = 0; + do { if (msgs[idx].len == 0) { ret = -EINVAL; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sricharan@codeaurora.org (Sricharan R) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V4 2/3] i2c: qup: Fix wrong value of index variable Date: Fri, 10 Jun 2016 23:38:20 +0530 [thread overview] Message-ID: <1465582101-19391-3-git-send-email-sricharan@codeaurora.org> (raw) In-Reply-To: <1465582101-19391-1-git-send-email-sricharan@codeaurora.org> index gets incremented during check to determine if the messages can be transferred with dma. But not reset after that, resulting in wrong start value in subsequent loop, causing failure. Fix it. Signed-off-by: Sricharan R <sricharan@codeaurora.org> --- drivers/i2c/busses/i2c-qup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 43adc2d..b8116e5 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -1260,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap, } } + idx = 0; + do { if (msgs[idx].len == 0) { ret = -EINVAL; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2016-06-10 18:08 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-10 18:08 [PATCH V4 0/3] i2c: qup: Some misc fixes Sricharan R 2016-06-10 18:08 ` Sricharan R 2016-06-10 18:08 ` [PATCH V4 1/3] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled Sricharan R 2016-06-10 18:08 ` Sricharan R 2016-06-10 18:14 ` Sricharan 2016-06-10 18:14 ` Sricharan 2016-06-10 18:14 ` Sricharan 2016-06-18 16:20 ` Wolfram Sang 2016-06-18 16:20 ` Wolfram Sang 2016-06-18 16:20 ` Wolfram Sang 2016-06-18 16:20 ` Wolfram Sang 2016-06-10 18:08 ` Sricharan R [this message] 2016-06-10 18:08 ` [PATCH V4 2/3] i2c: qup: Fix wrong value of index variable Sricharan R 2016-06-10 18:15 ` Sricharan 2016-06-10 18:15 ` Sricharan 2016-06-10 18:15 ` Sricharan 2016-06-18 16:21 ` Wolfram Sang 2016-06-18 16:21 ` Wolfram Sang 2016-06-18 16:26 ` Wolfram Sang 2016-06-18 16:26 ` Wolfram Sang 2016-06-10 18:08 ` [PATCH V4 3/3] i2c: qup: Fix error handling Sricharan R 2016-06-10 18:08 ` Sricharan R 2016-06-10 18:15 ` Sricharan 2016-06-10 18:15 ` Sricharan 2016-06-10 18:15 ` Sricharan 2016-06-18 16:25 ` Wolfram Sang 2016-06-18 16:25 ` Wolfram Sang 2016-06-10 18:13 ` [PATCH V4 0/3] i2c: qup: Some misc fixes Sricharan 2016-06-10 18:13 ` Sricharan 2016-06-10 18:13 ` Sricharan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1465582101-19391-3-git-send-email-sricharan@codeaurora.org \ --to=sricharan@codeaurora.org \ --cc=absahu@codeaurora.org \ --cc=agross@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=galak@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nkaje@codeaurora.org \ --cc=ntelkar@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.