All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, tglx@linutronix.de, torvalds@linux-foundation.org,
	tytso@mit.edu, viro@zeniv.linux.org.uk, y2038@lists.linaro.org,
	Jan Kara <jack@suse.com>
Subject: [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time()
Date: Sun, 19 Jun 2016 17:27:08 -0700	[thread overview]
Message-ID: <1466382443-11063-10-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com>

CURRENT_TIME is not y2038 safe.

CURRENT_TIME macro is also not appropriate for filesystems
as it doesn't use the right granularity for filesystem
timestamps.

Logical Volume Integrity format is described to have the
same timestamp format for "Recording Date and time" as
the other [a,c,m]timestamps.
Hence using current_time() instead here promises to
maintain the same granularity as other timestamps.

This is also in preparation for the patch that transitions
vfs timestamps to use 64 bit time and hence make them
y2038 safe. As part of the effort current_fs_time() will be
extended to do range checks.

Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Jan Kara <jack@suse.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/udf/super.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/fs/udf/super.c b/fs/udf/super.c
index 4942549..134c63a 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1986,6 +1986,7 @@ static void udf_open_lvid(struct super_block *sb)
 	struct buffer_head *bh = sbi->s_lvid_bh;
 	struct logicalVolIntegrityDesc *lvid;
 	struct logicalVolIntegrityDescImpUse *lvidiu;
+	struct timespec ts;
 
 	if (!bh)
 		return;
@@ -1997,8 +1998,9 @@ static void udf_open_lvid(struct super_block *sb)
 	mutex_lock(&sbi->s_alloc_mutex);
 	lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
 	lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
+	ktime_get_real_ts(&ts);
 	udf_time_to_disk_stamp(&lvid->recordingDateAndTime,
-				CURRENT_TIME);
+				timespec_trunc(ts, sb->s_time_gran));
 	lvid->integrityType = cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN);
 
 	lvid->descTag.descCRC = cpu_to_le16(
@@ -2019,6 +2021,7 @@ static void udf_close_lvid(struct super_block *sb)
 	struct buffer_head *bh = sbi->s_lvid_bh;
 	struct logicalVolIntegrityDesc *lvid;
 	struct logicalVolIntegrityDescImpUse *lvidiu;
+	struct timespec ts;
 
 	if (!bh)
 		return;
@@ -2030,7 +2033,9 @@ static void udf_close_lvid(struct super_block *sb)
 	mutex_lock(&sbi->s_alloc_mutex);
 	lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
 	lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
-	udf_time_to_disk_stamp(&lvid->recordingDateAndTime, CURRENT_TIME);
+	ktime_get_real_ts(&ts);
+	udf_time_to_disk_stamp(&lvid->recordingDateAndTime,
+		timespec_trunc(ts, sb->s_time_gran));
 	if (UDF_MAX_WRITE_VERSION > le16_to_cpu(lvidiu->maxUDFWriteRev))
 		lvidiu->maxUDFWriteRev = cpu_to_le16(UDF_MAX_WRITE_VERSION);
 	if (sbi->s_udfrev > le16_to_cpu(lvidiu->minUDFReadRev))
-- 
1.9.1

  parent reply	other threads:[~2016-06-20  0:28 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20  0:26 [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros Deepa Dinamani
2016-06-20  0:26 ` [lustre-devel] " Deepa Dinamani
2016-06-20  0:26 ` [Ocfs2-devel] " Deepa Dinamani
2016-06-20  0:26 ` Deepa Dinamani
2016-06-20  0:26 ` Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 01/24] vfs: Add current_time() api Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 02/24] fs: Replace CURRENT_TIME with current_time() for inode timestamps Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 03/24] fs: Replace CURRENT_TIME_SEC " Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 04/24] fs: Replace current_fs_time() with current_time() Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 05/24] fs: jfs: Replace CURRENT_TIME_SEC by current_time() Deepa Dinamani
2016-06-20 18:04   ` [Jfs-discussion] " Dave Kleikamp
2016-06-20  0:27 ` [PATCH v2 06/24] fs: ext4: Use current_time() for inode timestamps Deepa Dinamani
2016-06-20  0:27   ` Deepa Dinamani
2016-06-22 13:40   ` Arnd Bergmann
2016-06-22 13:40     ` Arnd Bergmann
2016-06-24 23:08     ` Deepa Dinamani
2016-06-24 23:08       ` Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 07/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Deepa Dinamani
2016-06-22 13:47   ` Arnd Bergmann
2016-06-24 21:05     ` Deepa Dinamani
2016-06-24 21:14       ` [Y2038] " Arnd Bergmann
2016-06-20  0:27 ` [PATCH v2 08/24] fs: btrfs: Use ktime_get_real_ts for root ctime Deepa Dinamani
2016-06-20  9:46   ` David Sterba
2016-06-20  0:27 ` Deepa Dinamani [this message]
2016-06-22 13:54   ` [Y2038] [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time() Arnd Bergmann
2016-06-23  1:59     ` Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 10/24] fs: cifs: Replace CURRENT_TIME by current_time() Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 11/24] fs: cifs: Replace CURRENT_TIME with ktime_get_real_ts() Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 12/24] fs: cifs: Replace CURRENT_TIME by get_seconds Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 13/24] fs: f2fs: Use ktime_get_real_seconds for sit_info times Deepa Dinamani
2016-06-20  0:27   ` Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 14/24] drivers: staging: lustre: Replace CURRENT_TIME with current_time() Deepa Dinamani
2016-06-20  0:27   ` [lustre-devel] " Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 15/24] fs: ocfs2: Use time64_t to represent orphan scan times Deepa Dinamani
2016-06-20  0:27   ` [Ocfs2-devel] " Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 16/24] fs: ocfs2: Replace CURRENT_TIME with ktime_get_real_seconds() Deepa Dinamani
2016-06-20  0:27   ` [Ocfs2-devel] " Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 17/24] audit: Use timespec64 to represent audit timestamps Deepa Dinamani
2016-06-20  0:27   ` Deepa Dinamani
2016-06-20 15:16   ` Richard Guy Briggs
2016-06-20 15:16     ` Richard Guy Briggs
2016-06-20  0:27 ` [PATCH v2 18/24] fs: nfs: Make nfs boot time y2038 safe Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 19/24] fnic: Use time64_t to represent trace timestamps Deepa Dinamani
2016-06-20  0:27   ` Deepa Dinamani
2016-06-22 14:09   ` Arnd Bergmann
2016-06-23  1:51     ` Deepa Dinamani
2016-06-23  1:51       ` Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 20/24] block: Replace CURRENT_TIME with ktime_get_real_ts Deepa Dinamani
2016-06-20  0:27   ` Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 21/24] libceph: " Deepa Dinamani
2016-06-20  0:27   ` Deepa Dinamani
2016-06-20  8:33   ` Willem Jan Withagen
2016-06-22  0:56     ` Deepa Dinamani
2016-06-22  8:20       ` Willem Jan Withagen
2016-06-23  0:17         ` Deepa Dinamani
2016-06-23  7:01           ` Willem Jan Withagen
2016-06-20  0:27 ` [PATCH v2 22/24] fs: ceph: Replace current_fs_time for request stamp Deepa Dinamani
2016-06-20  0:27   ` Deepa Dinamani
2016-06-20  0:27 ` [PATCH v2 23/24] time: Delete CURRENT_TIME_SEC and CURRENT_TIME macro Deepa Dinamani
2016-06-22 15:44   ` Arnd Bergmann
2016-06-20  0:27 ` [PATCH v2 24/24] time: Delete current_fs_time() function Deepa Dinamani
2016-06-20 18:03 ` [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros Linus Torvalds
2016-06-20 18:03   ` [lustre-devel] " Linus Torvalds
2016-06-20 18:03   ` [Ocfs2-devel] " Linus Torvalds
2016-06-20 18:03   ` Linus Torvalds
2016-06-20 18:03   ` Linus Torvalds
2016-06-20 18:03   ` Linus Torvalds
2016-06-20 18:58   ` Deepa Dinamani
2016-06-20 18:58     ` [lustre-devel] " Deepa Dinamani
2016-06-20 18:58     ` [Ocfs2-devel] " Deepa Dinamani
2016-06-20 18:58     ` Deepa Dinamani
2016-06-20 18:58     ` Deepa Dinamani
2016-06-20 18:58     ` Deepa Dinamani
2016-06-21 15:00   ` [Y2038] " Arnd Bergmann
2016-06-21 15:00     ` [lustre-devel] " Arnd Bergmann
2016-06-21 15:00     ` [Ocfs2-devel] " Arnd Bergmann
2016-06-21 15:00     ` Arnd Bergmann
2016-06-21 15:00     ` Arnd Bergmann
2016-06-21 15:00     ` Arnd Bergmann
2016-06-22 15:49 ` Arnd Bergmann
2016-06-22 15:49   ` [lustre-devel] " Arnd Bergmann
2016-06-22 15:49   ` [Ocfs2-devel] " Arnd Bergmann
2016-06-22 15:49   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466382443-11063-10-git-send-email-deepa.kernel@gmail.com \
    --to=deepa.kernel@gmail.com \
    --cc=arnd@arndb.de \
    --cc=jack@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.