From: Keerthy <j-keerthy@ti.com> To: <tony@atomide.com>, <broonie@kernel.org>, <devicetree@vger.kernel.org> Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <t-kristo@ti.com>, <russ.dill@ti.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <j-keerthy@ti.com>, <linux@armlinux.org.uk>, Dave Gerlach <d-gerlach@ti.com> Subject: [PATCH 7/9] mfd: tps65218: add version check to the PMIC probe Date: Mon, 20 Jun 2016 14:13:36 +0530 [thread overview] Message-ID: <1466412218-5906-8-git-send-email-j-keerthy@ti.com> (raw) In-Reply-To: <1466412218-5906-1-git-send-email-j-keerthy@ti.com> From: Tero Kristo <t-kristo@ti.com> Version information will be needed to handle some error cases under the regulator driver, so store the information once during MFD probe. Signed-off-by: Tero Kristo <t-kristo@ti.com> Signed-off-by: Dave Gerlach <d-gerlach@ti.com> Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/mfd/tps65218.c | 9 +++++++++ include/linux/mfd/tps65218.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c index 80b9dc3..ba610ad 100644 --- a/drivers/mfd/tps65218.c +++ b/drivers/mfd/tps65218.c @@ -219,6 +219,7 @@ static int tps65218_probe(struct i2c_client *client, struct tps65218 *tps; const struct of_device_id *match; int ret; + unsigned int chipid; match = of_match_device(of_tps65218_match_table, &client->dev); if (!match) { @@ -250,6 +251,14 @@ static int tps65218_probe(struct i2c_client *client, if (ret < 0) return ret; + ret = tps65218_reg_read(tps, TPS65218_REG_CHIPID, &chipid); + if (ret) { + dev_err(tps->dev, "Failed to read chipid: %d\n", ret); + return ret; + } + + tps->rev = chipid & TPS65218_CHIPID_REV_MASK; + ret = of_platform_populate(client->dev.of_node, NULL, NULL, &client->dev); if (ret < 0) diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h index 7fdf532..85e464e 100644 --- a/include/linux/mfd/tps65218.h +++ b/include/linux/mfd/tps65218.h @@ -267,6 +267,7 @@ struct tps_info { struct tps65218 { struct device *dev; unsigned int id; + u8 rev; struct mutex tps_lock; /* lock guarding the data structure */ /* IRQ Data */ -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <j-keerthy@ti.com> To: tony@atomide.com, broonie@kernel.org, devicetree@vger.kernel.org Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, russ.dill@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, j-keerthy@ti.com, linux@armlinux.org.uk, Dave Gerlach <d-gerlach@ti.com> Subject: [PATCH 7/9] mfd: tps65218: add version check to the PMIC probe Date: Mon, 20 Jun 2016 14:13:36 +0530 [thread overview] Message-ID: <1466412218-5906-8-git-send-email-j-keerthy@ti.com> (raw) In-Reply-To: <1466412218-5906-1-git-send-email-j-keerthy@ti.com> From: Tero Kristo <t-kristo@ti.com> Version information will be needed to handle some error cases under the regulator driver, so store the information once during MFD probe. Signed-off-by: Tero Kristo <t-kristo@ti.com> Signed-off-by: Dave Gerlach <d-gerlach@ti.com> Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/mfd/tps65218.c | 9 +++++++++ include/linux/mfd/tps65218.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c index 80b9dc3..ba610ad 100644 --- a/drivers/mfd/tps65218.c +++ b/drivers/mfd/tps65218.c @@ -219,6 +219,7 @@ static int tps65218_probe(struct i2c_client *client, struct tps65218 *tps; const struct of_device_id *match; int ret; + unsigned int chipid; match = of_match_device(of_tps65218_match_table, &client->dev); if (!match) { @@ -250,6 +251,14 @@ static int tps65218_probe(struct i2c_client *client, if (ret < 0) return ret; + ret = tps65218_reg_read(tps, TPS65218_REG_CHIPID, &chipid); + if (ret) { + dev_err(tps->dev, "Failed to read chipid: %d\n", ret); + return ret; + } + + tps->rev = chipid & TPS65218_CHIPID_REV_MASK; + ret = of_platform_populate(client->dev.of_node, NULL, NULL, &client->dev); if (ret < 0) diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h index 7fdf532..85e464e 100644 --- a/include/linux/mfd/tps65218.h +++ b/include/linux/mfd/tps65218.h @@ -267,6 +267,7 @@ struct tps_info { struct tps65218 { struct device *dev; unsigned int id; + u8 rev; struct mutex tps_lock; /* lock guarding the data structure */ /* IRQ Data */ -- 1.9.1
next prev parent reply other threads:[~2016-06-20 9:02 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-20 8:43 [PATCH 0/9] regulator: Enable suspend configuration Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-20 8:43 ` [PATCH 1/9] regulator: tps65217: " Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-21 19:08 ` Mark Brown 2016-06-22 10:14 ` Keerthy 2016-06-22 10:14 ` Keerthy 2016-06-22 10:16 ` Mark Brown 2016-06-22 10:16 ` Mark Brown 2016-06-22 10:26 ` Keerthy 2016-06-22 10:26 ` Keerthy 2016-06-23 10:26 ` Mark Brown 2016-06-23 10:26 ` Mark Brown 2016-06-23 10:32 ` Keerthy 2016-06-23 10:32 ` Keerthy 2016-06-20 8:43 ` [PATCH 2/9] regulator: of: setup initial suspend state Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-22 15:29 ` Applied "regulator: of: setup initial suspend state" to the regulator tree Mark Brown 2016-06-22 15:29 ` Mark Brown 2016-06-20 8:43 ` [PATCH 3/9] regulator: tps65218: Enable suspend configuration Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-27 17:00 ` Applied "regulator: tps65218: Enable suspend configuration" to the regulator tree Mark Brown 2016-06-27 17:00 ` Mark Brown 2016-06-20 8:43 ` [PATCH 4/9] ARM: dts: AM437X-GP-EVM: AM437X-SK-EVM: Make dcdc3 dcdc5 and dcdc6 enable during suspend Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-21 11:43 ` Tony Lindgren 2016-06-21 11:43 ` Tony Lindgren 2016-06-21 11:46 ` Tony Lindgren 2016-06-20 8:43 ` [PATCH 5/9] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3 Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-27 17:00 ` Applied "regulator: tps65218: force set power-up/down strobe to 3 for dcdc3" to the regulator tree Mark Brown 2016-06-27 17:00 ` Mark Brown 2016-06-20 8:43 ` [PATCH 6/9] ARM: dts: am437x-gp-evm: disable DDR regulator in rtc-only/poweroff mode Keerthy 2016-06-20 8:43 ` Keerthy 2016-06-20 8:43 ` Keerthy [this message] 2016-06-20 8:43 ` [PATCH 7/9] mfd: tps65218: add version check to the PMIC probe Keerthy 2016-06-20 8:45 ` Keerthy 2016-06-20 8:45 ` Keerthy 2016-08-10 20:04 ` Applied "mfd: tps65218: add version check to the PMIC probe" to the regulator tree Mark Brown 2016-08-10 20:04 ` Mark Brown 2016-08-31 8:31 ` Lee Jones 2016-08-31 11:41 ` Mark Brown 2016-08-31 11:41 ` Mark Brown 2016-08-31 14:50 ` Lee Jones 2016-08-31 14:50 ` Lee Jones 2016-08-31 16:02 ` Mark Brown 2016-08-31 16:02 ` Mark Brown 2016-09-01 8:23 ` Lee Jones 2016-09-01 8:23 ` Lee Jones 2016-09-01 8:54 ` Mark Brown 2016-09-01 9:34 ` Lee Jones 2016-08-31 17:57 ` Russell King - ARM Linux 2016-08-31 17:57 ` Russell King - ARM Linux 2016-09-01 8:18 ` Lee Jones 2016-09-01 10:17 ` Russell King - ARM Linux 2016-09-01 10:17 ` Russell King - ARM Linux 2016-09-01 11:19 ` Lee Jones 2016-09-01 11:19 ` Lee Jones 2016-09-01 14:23 ` Russell King - ARM Linux 2016-09-01 14:53 ` Lee Jones 2016-06-20 8:43 ` [PATCH 8/9] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Keerthy 2016-06-20 8:43 ` Keerthy 2016-08-10 20:04 ` Applied "regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs" to the regulator tree Mark Brown 2016-08-10 20:04 ` Mark Brown 2016-08-31 15:01 ` Lee Jones 2016-08-31 15:01 ` Lee Jones 2016-09-01 10:06 ` Mark Brown 2016-06-20 8:43 ` [PATCH 9/9] ARM: dts: am437x-sk-evm: disable DDR regulator in rtc-only/poweroff mode Keerthy 2016-06-20 8:43 ` Keerthy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1466412218-5906-8-git-send-email-j-keerthy@ti.com \ --to=j-keerthy@ti.com \ --cc=broonie@kernel.org \ --cc=d-gerlach@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=russ.dill@ti.com \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.