All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, mst@redhat.com, amit.shah@redhat.com,
	quintela@redhat.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 05/13] virtio-blk: Wrap in vmstate
Date: Tue, 21 Jun 2016 20:13:59 +0100	[thread overview]
Message-ID: <1466536447-30146-6-git-send-email-dgilbert@redhat.com> (raw)
In-Reply-To: <1466536447-30146-1-git-send-email-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Forcibly convert it to a vmstate wrapper;  proper conversion
comes later.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hw/block/virtio-blk.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 284e646..8b93f9f 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -792,7 +792,7 @@ static void virtio_blk_set_status(VirtIODevice *vdev, uint8_t status)
     }
 }
 
-static void virtio_blk_save(QEMUFile *f, void *opaque)
+static void virtio_blk_save(QEMUFile *f, void *opaque, size_t size)
 {
     VirtIODevice *vdev = VIRTIO_DEVICE(opaque);
     VirtIOBlock *s = VIRTIO_BLK(vdev);
@@ -817,15 +817,12 @@ static void virtio_blk_save_device(VirtIODevice *vdev, QEMUFile *f)
     qemu_put_sbyte(f, 0);
 }
 
-static int virtio_blk_load(QEMUFile *f, void *opaque, int version_id)
+static int virtio_blk_load(QEMUFile *f, void *opaque, size_t size)
 {
     VirtIOBlock *s = opaque;
     VirtIODevice *vdev = VIRTIO_DEVICE(s);
 
-    if (version_id != 2)
-        return -EINVAL;
-
-    return virtio_load(vdev, f, version_id);
+    return virtio_load(vdev, f, 2);
 }
 
 static int virtio_blk_load_device(VirtIODevice *vdev, QEMUFile *f,
@@ -861,7 +858,6 @@ static void virtio_blk_device_realize(DeviceState *dev, Error **errp)
     VirtIOBlock *s = VIRTIO_BLK(dev);
     VirtIOBlkConf *conf = &s->conf;
     Error *err = NULL;
-    static int virtio_blk_id;
 
     if (!conf->conf.blk) {
         error_setg(errp, "drive property not set");
@@ -897,8 +893,6 @@ static void virtio_blk_device_realize(DeviceState *dev, Error **errp)
     }
 
     s->change = qemu_add_vm_change_state_handler(virtio_blk_dma_restart_cb, s);
-    register_savevm(dev, "virtio-blk", virtio_blk_id++, 2,
-                    virtio_blk_save, virtio_blk_load, s);
     blk_set_dev_ops(s->blk, &virtio_block_ops, s);
     blk_set_guest_block_size(s->blk, s->conf.conf.logical_block_size);
 
@@ -913,7 +907,6 @@ static void virtio_blk_device_unrealize(DeviceState *dev, Error **errp)
     virtio_blk_data_plane_destroy(s->dataplane);
     s->dataplane = NULL;
     qemu_del_vm_change_state_handler(s->change);
-    unregister_savevm(dev, "virtio-blk", s);
     blockdev_mark_auto_del(s->blk);
     virtio_cleanup(vdev);
 }
@@ -931,6 +924,8 @@ static void virtio_blk_instance_init(Object *obj)
                                   DEVICE(obj), NULL);
 }
 
+VMSTATE_VIRTIO_DEVICE(blk, 2, virtio_blk_load, virtio_blk_save);
+
 static Property virtio_blk_properties[] = {
     DEFINE_BLOCK_PROPERTIES(VirtIOBlock, conf.conf),
     DEFINE_BLOCK_CHS_PROPERTIES(VirtIOBlock, conf.conf),
@@ -950,6 +945,7 @@ static void virtio_blk_class_init(ObjectClass *klass, void *data)
     VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
 
     dc->props = virtio_blk_properties;
+    dc->vmsd = &vmstate_virtio_blk;
     set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
     vdc->realize = virtio_blk_device_realize;
     vdc->unrealize = virtio_blk_device_unrealize;
-- 
2.7.4

  parent reply	other threads:[~2016-06-21 19:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 19:13 [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate Dr. David Alan Gilbert (git)
2016-06-21 19:13 ` [Qemu-devel] [PATCH 01/13] virtio-net: Remove old migration version support Dr. David Alan Gilbert (git)
2016-06-27  6:46   ` Amit Shah
2016-06-21 19:13 ` [Qemu-devel] [PATCH 02/13] virtio-serial: " Dr. David Alan Gilbert (git)
2016-06-27  6:45   ` Amit Shah
2016-06-21 19:13 ` [Qemu-devel] [PATCH 03/13] virtio: Migration helper function and macro Dr. David Alan Gilbert (git)
2016-06-22 17:39   ` Cornelia Huck
2016-06-21 19:13 ` [Qemu-devel] [PATCH 04/13] virtio-scsi: Wrap in vmstate Dr. David Alan Gilbert (git)
2016-06-22 17:40   ` Cornelia Huck
2016-06-21 19:13 ` Dr. David Alan Gilbert (git) [this message]
2016-06-22 17:42   ` [Qemu-devel] [PATCH 05/13] virtio-blk: " Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 06/13] virtio-rng: " Dr. David Alan Gilbert (git)
2016-06-22 17:44   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 07/13] virtio-balloon: " Dr. David Alan Gilbert (git)
2016-06-22 17:46   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 08/13] virtio-net: " Dr. David Alan Gilbert (git)
2016-06-23  7:39   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 09/13] virtio-serial: " Dr. David Alan Gilbert (git)
2016-06-23  7:55   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 10/13] 9pfs: " Dr. David Alan Gilbert (git)
2016-06-23  8:01   ` Cornelia Huck
2016-06-30  7:02   ` Greg Kurz
2016-06-21 19:14 ` [Qemu-devel] [PATCH 11/13] virtio-input: " Dr. David Alan Gilbert (git)
2016-06-22  6:48   ` Gerd Hoffmann
2016-06-22  9:54     ` Dr. David Alan Gilbert
2016-06-22 10:29       ` Gerd Hoffmann
2016-06-23  8:07   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 12/13] virtio-gpu: " Dr. David Alan Gilbert (git)
2016-06-23  8:19   ` Cornelia Huck
2016-06-21 19:14 ` [Qemu-devel] [PATCH 13/13] virtio: Update migration docs Dr. David Alan Gilbert (git)
2016-06-23  8:23   ` Cornelia Huck
2016-06-22  6:53 ` [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate Gerd Hoffmann
2016-06-22  9:50   ` Dr. David Alan Gilbert
2016-06-22  8:39 ` Cornelia Huck
2016-06-22 10:54   ` Dr. David Alan Gilbert
2016-06-22 17:36     ` Cornelia Huck
2016-06-24  5:49 ` Michael S. Tsirkin
2016-06-24  8:02   ` Dr. David Alan Gilbert
2016-06-27  6:50 ` Amit Shah
2016-06-27  7:53   ` Dr. David Alan Gilbert
2016-06-28  9:04     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466536447-30146-6-git-send-email-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.