All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 2/3] mirror: limit niov to IOV_MAX elements, again
Date: Wed, 22 Jun 2016 15:51:03 -0400	[thread overview]
Message-ID: <1466625064-11280-3-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1466625064-11280-1-git-send-email-jsnow@redhat.com>

During the refactor of mirror_iteration in e5b43573,
we regressed the fix introduced in cae98cb8.

This patch re-adds IOV_MAX checking to cases where we
aren't checking alignment (and size) already.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 block/mirror.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/mirror.c b/block/mirror.c
index 2ba9642..377339d 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -231,11 +231,14 @@ static int mirror_do_read(MirrorBlockJob *s, int64_t sector_num,
     int sectors_per_chunk, nb_chunks;
     int ret;
     MirrorOp *op;
+    int max_sectors;
 
     sectors_per_chunk = s->granularity >> BDRV_SECTOR_BITS;
+    max_sectors = sectors_per_chunk * s->max_iov;
 
     /* We can only handle as much as buf_size at a time. */
     nb_sectors = MIN(s->buf_size >> BDRV_SECTOR_BITS, nb_sectors);
+    nb_sectors = MIN(max_sectors, nb_sectors);
     assert(nb_sectors);
     ret = nb_sectors;
 
-- 
2.4.11

  parent reply	other threads:[~2016-06-22 19:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 19:51 [Qemu-devel] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV John Snow
2016-06-22 19:51 ` [Qemu-devel] [PATCH 1/3] mirror: clarify mirror_do_read return code John Snow
2016-06-22 20:03   ` Eric Blake
2016-06-23  0:36   ` Fam Zheng
2016-06-22 19:51 ` John Snow [this message]
2016-06-22 20:29   ` [Qemu-devel] [PATCH 2/3] mirror: limit niov to IOV_MAX elements, again Eric Blake
2016-06-23  0:39   ` Fam Zheng
2016-06-22 19:51 ` [Qemu-devel] [PATCH 3/3] iotests: add small-granularity mirror test John Snow
2016-06-22 20:36   ` Eric Blake
2016-06-23  0:47   ` Fam Zheng
2016-06-28 17:05 ` [Qemu-devel] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV John Snow
2016-06-29  2:53 ` Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466625064-11280-3-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.