From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [CI 12/14] drm/i915: Remove user controllable DRM_ERROR for intel_get_pipe_from_crtc_id()
Date: Fri, 24 Jun 2016 08:00:43 +0100 [thread overview]
Message-ID: <1466751645-6529-12-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1466751645-6529-1-git-send-email-chris@chris-wilson.co.uk>
Don't emit a driver DRM_ERROR for a user passing in an invalid CRTC id,
simply report it is missing back to the user.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index c3257177d527..c3b5dc8f5e80 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14633,11 +14633,8 @@ int intel_get_pipe_from_crtc_id(struct drm_device *dev, void *data,
struct intel_crtc *crtc;
drmmode_crtc = drm_crtc_find(dev, pipe_from_crtc_id->crtc_id);
-
- if (!drmmode_crtc) {
- DRM_ERROR("no such CRTC id\n");
+ if (!drmmode_crtc)
return -ENOENT;
- }
crtc = to_intel_crtc(drmmode_crtc);
pipe_from_crtc_id->pipe = crtc->pipe;
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-24 7:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 7:00 [CI 01/14] drm/i915: Move panel's backlight setup next to panel init Chris Wilson
2016-06-24 7:00 ` [CI 02/14] drm/i915: Move registration actions to connector->late_register Chris Wilson
2016-06-24 7:00 ` [CI 03/14] drm/i915: Move backlight registration to connector registration Chris Wilson
2016-06-24 7:00 ` [CI 04/14] drm/i915: Move connector registration to driver registration Chris Wilson
2016-06-24 7:00 ` [CI 05/14] drm/i915: Register debugfs interface last Chris Wilson
2016-06-24 7:00 ` [CI 06/14] drm/i915: Demidlayer driver loading Chris Wilson
2016-06-24 7:00 ` [CI 07/14] drm/i915: Demidlayer driver unloading Chris Wilson
2016-06-24 7:00 ` [CI 08/14] drm/i915: Remove redundant drm_connector_register_all() Chris Wilson
2016-06-24 7:00 ` [CI 09/14] drm/i915: Start exploiting drm_device subclassing Chris Wilson
2016-06-24 7:00 ` [CI 10/14] drm/i915: Merge i915_dma.c into i915_drv.c Chris Wilson
2016-06-24 7:00 ` [CI 11/14] drm/i915: Remove user controllable DRM_ERROR for i915_getparam() Chris Wilson
2016-06-24 7:00 ` Chris Wilson [this message]
2016-06-24 7:00 ` [CI 13/14] drm/i915: Split out the PCI driver interface to i915_pci.c Chris Wilson
2016-06-24 7:00 ` [CI 14/14] drm/i915: Move module init/exit " Chris Wilson
2016-06-24 10:12 ` ✗ Ro.CI.BAT: failure for series starting with [CI,01/14] drm/i915: Move panel's backlight setup next to panel init Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466751645-6529-12-git-send-email-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.