From: Frank Binns <frank.binns@imgtec.com>
To: dri-devel@lists.freedesktop.org
Cc: Thierry Reding <treding@nvidia.com>, rufus.hamade@imgtec.com
Subject: [PATCH 4/6] drm/qxl: Remove dead code
Date: Fri, 24 Jun 2016 18:15:18 +0100 [thread overview]
Message-ID: <1466788520-21325-5-git-send-email-frank.binns@imgtec.com> (raw)
In-Reply-To: <1466788520-21325-1-git-send-email-frank.binns@imgtec.com>
From: Thierry Reding <treding@nvidia.com>
The QXL driver sets DRIVER_MODESET unconditionally, so testing for the
absence of the feature will always fail.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/qxl/qxl_kms.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
index 2319800..12b8dff 100644
--- a/drivers/gpu/drm/qxl/qxl_kms.c
+++ b/drivers/gpu/drm/qxl/qxl_kms.c
@@ -310,10 +310,6 @@ int qxl_driver_load(struct drm_device *dev, unsigned long flags)
struct qxl_device *qdev;
int r;
- /* require kms */
- if (!drm_core_check_feature(dev, DRIVER_MODESET))
- return -ENODEV;
-
qdev = kzalloc(sizeof(struct qxl_device), GFP_KERNEL);
if (qdev == NULL)
return -ENOMEM;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-24 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 17:15 [PATCH v2 0/6] Support render only drivers Frank Binns
2016-06-24 17:15 ` [PATCH 1/6] drm/vmwgfx: Stop checking minor type directly Frank Binns
2016-06-24 22:46 ` Sinclair Yeh
2016-07-12 11:08 ` Daniel Vetter
2016-06-24 17:15 ` [PATCH 2/6] drm: Rename DRM_MINOR_LEGACY to DRM_MINOR_PRIMARY Frank Binns
2016-07-12 11:09 ` Daniel Vetter
2016-06-24 17:15 ` [PATCH 3/6] drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time Frank Binns
2016-06-24 22:08 ` Alex Deucher
2016-06-27 9:37 ` Frank Binns
2016-06-27 15:51 ` Alex Deucher
2016-06-24 17:15 ` Frank Binns [this message]
2016-07-12 11:09 ` [PATCH 4/6] drm/qxl: Remove dead code Daniel Vetter
2016-06-24 17:15 ` [PATCH v2 5/6] drm: Introduce DRIVER_LEGACY feature Frank Binns
2016-06-24 17:15 ` [PATCH v2 6/6] drm: Separate DRIVER_MODESET and DRIVER_LEGACY Frank Binns
2016-07-12 11:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466788520-21325-5-git-send-email-frank.binns@imgtec.com \
--to=frank.binns@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=rufus.hamade@imgtec.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.