All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@free-electrons.com>
To: jdelvare@suse.com, linux@roeck-us.net, jic23@kernel.org,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	maxime.ripard@free-electrons.com, wens@csie.org,
	lee.jones@linaro.org
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	thomas.petazzoni@free-electrons.com,
	antoine.tenart@free-electrons.com
Subject: [PATCH 3/3] hwmon: iio_hwmon: defer probe when no channel is found
Date: Tue, 28 Jun 2016 10:18:17 +0200	[thread overview]
Message-ID: <1467101897-15946-4-git-send-email-quentin.schulz@free-electrons.com> (raw)
In-Reply-To: <1467101897-15946-1-git-send-email-quentin.schulz@free-electrons.com>

iio_channel_get_all returns -ENODEV when it cannot find either phandles and
properties in the Device Tree or channels whose consumer_dev_name matches
iio_hwmon in iio_map_list. The iio_map_list is filled in by iio drivers
which might be probed after iio_hwmon.

It is better to defer the probe of iio_hwmon if such error is returned by
iio_channel_get_all in order to let a chance to iio drivers to expose
channels in iio_map_list.

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
 drivers/hwmon/iio_hwmon.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/iio_hwmon.c b/drivers/hwmon/iio_hwmon.c
index b550ba5..c0da4d9 100644
--- a/drivers/hwmon/iio_hwmon.c
+++ b/drivers/hwmon/iio_hwmon.c
@@ -73,8 +73,11 @@ static int iio_hwmon_probe(struct platform_device *pdev)
 		name = dev->of_node->name;
 
 	channels = iio_channel_get_all(dev);
-	if (IS_ERR(channels))
+	if (IS_ERR(channels)) {
+		if (PTR_ERR(channels) == -ENODEV)
+			return -EPROBE_DEFER;
 		return PTR_ERR(channels);
+	}
 
 	st = devm_kzalloc(dev, sizeof(*st), GFP_KERNEL);
 	if (st == NULL) {
-- 
2.5.0


WARNING: multiple messages have this Message-ID (diff)
From: quentin.schulz@free-electrons.com (Quentin Schulz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] hwmon: iio_hwmon: defer probe when no channel is found
Date: Tue, 28 Jun 2016 10:18:17 +0200	[thread overview]
Message-ID: <1467101897-15946-4-git-send-email-quentin.schulz@free-electrons.com> (raw)
In-Reply-To: <1467101897-15946-1-git-send-email-quentin.schulz@free-electrons.com>

iio_channel_get_all returns -ENODEV when it cannot find either phandles and
properties in the Device Tree or channels whose consumer_dev_name matches
iio_hwmon in iio_map_list. The iio_map_list is filled in by iio drivers
which might be probed after iio_hwmon.

It is better to defer the probe of iio_hwmon if such error is returned by
iio_channel_get_all in order to let a chance to iio drivers to expose
channels in iio_map_list.

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
 drivers/hwmon/iio_hwmon.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/iio_hwmon.c b/drivers/hwmon/iio_hwmon.c
index b550ba5..c0da4d9 100644
--- a/drivers/hwmon/iio_hwmon.c
+++ b/drivers/hwmon/iio_hwmon.c
@@ -73,8 +73,11 @@ static int iio_hwmon_probe(struct platform_device *pdev)
 		name = dev->of_node->name;
 
 	channels = iio_channel_get_all(dev);
-	if (IS_ERR(channels))
+	if (IS_ERR(channels)) {
+		if (PTR_ERR(channels) == -ENODEV)
+			return -EPROBE_DEFER;
 		return PTR_ERR(channels);
+	}
 
 	st = devm_kzalloc(dev, sizeof(*st), GFP_KERNEL);
 	if (st == NULL) {
-- 
2.5.0

  parent reply	other threads:[~2016-06-28  8:18 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  8:45 [PATCH 0/3] add support for Allwinner SoCs ADC Quentin Schulz
2016-06-28  8:45 ` Quentin Schulz
2016-06-28  8:18 ` [PATCH 1/3] mfd: " Quentin Schulz
2016-06-28  8:18   ` Quentin Schulz
2016-06-28  8:30   ` Antoine Tenart
2016-06-28  8:30     ` Antoine Tenart
2016-06-28  8:51   ` Antoine Tenart
2016-06-28  8:51     ` Antoine Tenart
2016-07-03 11:17   ` Jonathan Cameron
2016-07-03 11:17     ` Jonathan Cameron
2016-07-03 16:49     ` Lars-Peter Clausen
2016-07-03 16:49       ` Lars-Peter Clausen
2016-07-03 17:38       ` Guenter Roeck
2016-07-03 17:38         ` Guenter Roeck
2016-06-28  8:18 ` [PATCH 2/3] iio: adc: " Quentin Schulz
2016-06-28  8:18   ` Quentin Schulz
2016-06-28  8:32   ` Antoine Tenart
2016-06-28  8:32     ` Antoine Tenart
2016-06-28  9:24   ` Peter Meerwald-Stadler
2016-06-28 13:39     ` Quentin Schulz
2016-06-28 14:18       ` Peter Meerwald-Stadler
2016-06-28 16:25         ` Jonathan Cameron
2016-07-03 11:54   ` Jonathan Cameron
2016-07-03 11:54     ` Jonathan Cameron
2016-07-03 12:48     ` Jonathan Cameron
2016-07-03 12:48       ` Jonathan Cameron
2016-07-03 15:43     ` Guenter Roeck
2016-07-03 15:43       ` Guenter Roeck
2016-07-04  7:26       ` Quentin Schulz
2016-07-04  7:26         ` Quentin Schulz
2016-07-04 16:29         ` Guenter Roeck
2016-07-04 16:29           ` Guenter Roeck
2016-07-05  7:40           ` Quentin Schulz
2016-07-05  7:40             ` Quentin Schulz
2016-06-28  8:18 ` Quentin Schulz [this message]
2016-06-28  8:18   ` [PATCH 3/3] hwmon: iio_hwmon: defer probe when no channel is found Quentin Schulz
2016-06-30  3:47   ` [3/3] " Guenter Roeck
2016-06-30  3:47     ` Guenter Roeck
2016-06-30 13:59     ` Jonathan Cameron
2016-06-30 13:59       ` Jonathan Cameron
2016-06-30 14:49       ` Lars-Peter Clausen
2016-06-30 14:49         ` Lars-Peter Clausen
2016-06-30 14:51       ` Guenter Roeck
2016-06-30 14:51         ` Guenter Roeck
2016-07-03 10:47         ` Jonathan Cameron
2016-07-03 10:47           ` Jonathan Cameron
2016-07-03 15:48           ` Guenter Roeck
2016-07-03 15:48             ` Guenter Roeck
2016-06-29  3:28 ` [PATCH 0/3] add support for Allwinner SoCs ADC Chen-Yu Tsai
2016-06-29  3:28   ` Chen-Yu Tsai
2016-07-01  9:45   ` Quentin Schulz
2016-07-01  9:45     ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467101897-15946-4-git-send-email-quentin.schulz@free-electrons.com \
    --to=quentin.schulz@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=jdelvare@suse.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maxime.ripard@free-electrons.com \
    --cc=pmeerw@pmeerw.net \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.