All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,
	Andi Shyti <andi@etezian.org>
Subject: [PATCH 4/4] spi: s3c64xx: restore removed comments
Date: Fri, 08 Jul 2016 21:18:24 +0900	[thread overview]
Message-ID: <1467980304-14093-5-git-send-email-andi.shyti@samsung.com> (raw)
In-Reply-To: <1467980304-14093-1-git-send-email-andi.shyti@samsung.com>

Patch a9e93e8 has erroneously removed some comments which are
important to understand why the bus frequency is multiplied by
two during the spi transfer.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/spi/spi-s3c64xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 1874bc5..d1fe100 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -639,6 +639,8 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
 	writel(val, regs + S3C64XX_SPI_MODE_CFG);
 
 	if (sdd->port_conf->clk_from_cmu) {
+		/* Configure Clock */
+		/* There is half-multiplier before the SPI */
 		clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
 	} else {
 		/* Configure Clock */
-- 
2.8.1

WARNING: multiple messages have this Message-ID (diff)
From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] spi: s3c64xx: restore removed comments
Date: Fri, 08 Jul 2016 21:18:24 +0900	[thread overview]
Message-ID: <1467980304-14093-5-git-send-email-andi.shyti@samsung.com> (raw)
In-Reply-To: <1467980304-14093-1-git-send-email-andi.shyti@samsung.com>

Patch a9e93e8 has erroneously removed some comments which are
important to understand why the bus frequency is multiplied by
two during the spi transfer.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/spi/spi-s3c64xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 1874bc5..d1fe100 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -639,6 +639,8 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
 	writel(val, regs + S3C64XX_SPI_MODE_CFG);
 
 	if (sdd->port_conf->clk_from_cmu) {
+		/* Configure Clock */
+		/* There is half-multiplier before the SPI */
 		clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
 	} else {
 		/* Configure Clock */
-- 
2.8.1

  parent reply	other threads:[~2016-07-08 12:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 12:18 [PATCH 0/4] spi s3c64xx ioclk handling Andi Shyti
2016-07-08 12:18 ` Andi Shyti
2016-07-08 12:18 ` [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names Andi Shyti
2016-07-08 12:18   ` Andi Shyti
2016-07-08 13:11   ` Krzysztof Kozlowski
2016-07-08 13:11     ` Krzysztof Kozlowski
2016-07-08 13:11     ` Krzysztof Kozlowski
2016-07-08 13:12     ` Krzysztof Kozlowski
2016-07-08 13:12       ` Krzysztof Kozlowski
2016-07-08 12:18 ` [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti
2016-07-08 12:18   ` Andi Shyti
2016-07-08 12:51   ` Krzysztof Kozlowski
2016-07-08 12:51     ` Krzysztof Kozlowski
2016-07-08 12:51     ` Krzysztof Kozlowski
2016-07-08 12:56     ` Andi Shyti
2016-07-08 12:56       ` Andi Shyti
2016-07-08 12:56       ` Andi Shyti
2016-07-08 13:00       ` Krzysztof Kozlowski
2016-07-08 13:00         ` Krzysztof Kozlowski
2016-07-08 12:18 ` [PATCH 3/4] spi: s3c64xx: add nexynos5433 compatible for ioclk handling Andi Shyti
2016-07-08 12:18   ` Andi Shyti
2016-07-08 13:21   ` Krzysztof Kozlowski
2016-07-08 13:21     ` Krzysztof Kozlowski
2016-07-08 12:18 ` Andi Shyti [this message]
2016-07-08 12:18   ` [PATCH 4/4] spi: s3c64xx: restore removed comments Andi Shyti
2016-07-08 12:52   ` Krzysztof Kozlowski
2016-07-08 12:52     ` Krzysztof Kozlowski
2016-07-08 12:52     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467980304-14093-5-git-send-email-andi.shyti@samsung.com \
    --to=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=broonie@kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.