All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Mark Brown <broonie@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
	Andi Shyti <andi.shyti@samsung.com>,
	Andi Shyti <andi@etezian.org>
Subject: [PATCH v3 6/7] spi: s3c64xx: restore removed comments
Date: Tue, 12 Jul 2016 19:02:15 +0900	[thread overview]
Message-ID: <1468317736-18841-7-git-send-email-andi.shyti@samsung.com> (raw)
In-Reply-To: <1468317736-18841-1-git-send-email-andi.shyti@samsung.com>

Patch a9e93e8 has erroneously removed some comments which are
important to understand why the bus frequency is multiplied by
two during the spi transfer.

Reword the previous comment to a more appropriate message.

Suggested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reviewed-by: Michael Turquette <mturquette@baylibre.com>
---
 drivers/spi/spi-s3c64xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 6da663f..5bedafc 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -639,6 +639,7 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
 	writel(val, regs + S3C64XX_SPI_MODE_CFG);
 
 	if (sdd->port_conf->clk_from_cmu) {
+		/* The src_clk clock is divided internally by 2 */
 		clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
 	} else {
 		/* Configure Clock */
-- 
2.8.1

WARNING: multiple messages have this Message-ID (diff)
From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/7] spi: s3c64xx: restore removed comments
Date: Tue, 12 Jul 2016 19:02:15 +0900	[thread overview]
Message-ID: <1468317736-18841-7-git-send-email-andi.shyti@samsung.com> (raw)
In-Reply-To: <1468317736-18841-1-git-send-email-andi.shyti@samsung.com>

Patch a9e93e8 has erroneously removed some comments which are
important to understand why the bus frequency is multiplied by
two during the spi transfer.

Reword the previous comment to a more appropriate message.

Suggested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reviewed-by: Michael Turquette <mturquette@baylibre.com>
---
 drivers/spi/spi-s3c64xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 6da663f..5bedafc 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -639,6 +639,7 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
 	writel(val, regs + S3C64XX_SPI_MODE_CFG);
 
 	if (sdd->port_conf->clk_from_cmu) {
+		/* The src_clk clock is divided internally by 2 */
 		clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
 	} else {
 		/* Configure Clock */
-- 
2.8.1

  parent reply	other threads:[~2016-07-12 10:02 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 10:02 [PATCH v3 0/7] spi s3c64xx ioclk handling Andi Shyti
2016-07-12 10:02 ` Andi Shyti
2016-07-12 10:02 ` [PATCH v3 1/7] bindings: spi-samsung: add exynos5433 spi compatible Andi Shyti
2016-07-12 10:02   ` Andi Shyti
     [not found]   ` <1468317736-18841-2-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-14 16:25     ` Mark Brown
2016-07-14 16:25       ` Mark Brown
2016-07-14 16:25       ` Mark Brown
2016-07-16 20:26     ` Rob Herring
2016-07-16 20:26       ` Rob Herring
2016-07-16 20:26       ` Rob Herring
2016-07-12 10:02 ` [PATCH v3 2/7] bindings: spi-samsung: document the clocks and the clock-name property Andi Shyti
2016-07-12 10:02   ` Andi Shyti
2016-07-16 20:30   ` Rob Herring
2016-07-16 20:30     ` Rob Herring
2016-07-18 10:30     ` Sylwester Nawrocki
2016-07-18 10:30       ` Sylwester Nawrocki
2016-07-12 10:02 ` [PATCH v3 3/7] spi: s3c64xx: rename goto labels to meaningful names Andi Shyti
2016-07-12 10:02   ` Andi Shyti
2016-07-12 10:02 ` [PATCH v3 4/7] spi: s3c64xx: use error code from clk_prepare_enable() Andi Shyti
2016-07-12 10:02   ` Andi Shyti
2016-07-12 10:02 ` [PATCH v3 5/7] spi: s3c64xx: add Exynos5433 compatible for ioclk handling Andi Shyti
2016-07-12 10:02   ` Andi Shyti
2016-07-12 10:02 ` Andi Shyti [this message]
2016-07-12 10:02   ` [PATCH v3 6/7] spi: s3c64xx: restore removed comments Andi Shyti
     [not found] ` <1468317736-18841-1-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-12 10:02   ` [PATCH v3 7/7] clk: exynos5433: remove CLK_IGNORE_UNUSED flag from SPI clocks Andi Shyti
2016-07-12 10:02     ` Andi Shyti
2016-07-12 10:02     ` Andi Shyti
2016-07-12 22:17     ` Michael Turquette
2016-07-12 22:17       ` Michael Turquette
2016-07-12 22:17       ` Michael Turquette
2016-07-12 22:17       ` Michael Turquette
2016-07-13  2:08       ` Andi Shyti
2016-07-13  2:08         ` Andi Shyti
2016-07-13  9:21       ` Sylwester Nawrocki
2016-07-13  9:21         ` Sylwester Nawrocki
     [not found]         ` <578607FD.6050705-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-13  9:54           ` Krzysztof Kozlowski
2016-07-13  9:54             ` Krzysztof Kozlowski
2016-07-13  9:54             ` Krzysztof Kozlowski
2016-07-13 12:44       ` Andi Shyti
2016-07-13 12:44         ` Andi Shyti
2016-07-13 12:44         ` Andi Shyti
2016-07-13 21:56     ` Michael Turquette
2016-07-13 21:56       ` Michael Turquette
2016-07-13 21:56       ` Michael Turquette
2016-07-13 21:56       ` Michael Turquette
  -- strict thread matches above, loose matches on Subject: below --
2016-07-11 10:33 [PATCH v2 6/7] spi: s3c64xx: restore removed comments Sylwester Nawrocki
2016-07-12  6:54 ` [PATCH v3 " Andi Shyti
2016-07-12  6:54   ` Andi Shyti
     [not found]   ` <1468306444-18512-1-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-12  8:22     ` Mark Brown
2016-07-12  8:22       ` Mark Brown
2016-07-12  8:22       ` Mark Brown
     [not found]       ` <20160712082256.GD9976-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-12  8:25         ` Andi Shyti
2016-07-12  8:25           ` Andi Shyti
2016-07-12  8:25           ` Andi Shyti
2016-07-12  9:00           ` Mark Brown
2016-07-12  9:00             ` Mark Brown
2016-07-12 18:07   ` Michael Turquette
2016-07-12 18:07     ` Michael Turquette
2016-07-12 18:07     ` Michael Turquette
2016-07-12 18:07     ` Michael Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468317736-18841-7-git-send-email-andi.shyti@samsung.com \
    --to=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.