All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jianhong.Yin" <yin-jianhong@163.com>
To: linux-nfs@vger.kernel.org
Cc: steved@redhat.com, "Jianhong.Yin" <yin-jianhong@163.com>
Subject: [PATCH] exportfs: fix export point checking
Date: Thu, 14 Jul 2016 13:35:59 +0800	[thread overview]
Message-ID: <1468474559-24168-1-git-send-email-yin-jianhong@163.com> (raw)

NFS does not support regular file export and mount,
use S_ISLNK instead S_ISREG
---
 utils/exportfs/exportfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index 5db348b..74baa08 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -585,8 +585,8 @@ validate_export(nfs_export *exp)
 		xlog(L_ERROR, "Failed to stat %s: %m", path);
 		return;
 	}
-	if (!S_ISDIR(stb.st_mode) && !S_ISREG(stb.st_mode)) {
-		xlog(L_ERROR, "%s is neither a directory nor a file. "
+	if (!S_ISDIR(stb.st_mode) && !S_ISLNK(stb.st_mode)) {
+		xlog(L_ERROR, "%s is neither a directory nor a symlink. "
 			"Remote access will fail", path);
 		return;
 	}
-- 
2.5.5


             reply	other threads:[~2016-07-14  5:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14  5:35 Jianhong.Yin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-07-09  5:15 [PATCH] exportfs: fix export point checking Jianhong.Yin
2016-07-18 17:33 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468474559-24168-1-git-send-email-yin-jianhong@163.com \
    --to=yin-jianhong@163.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.