All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: tiwai@suse.de, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, Helen Koike <helen.koike@collabora.co.uk>
Subject: [PATCH 5/5] ALSA: soc-tpa6130a2: add static qualifier for file local symbols
Date: Tue, 26 Jul 2016 22:41:57 +0900	[thread overview]
Message-ID: <1469540517-32466-6-git-send-email-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <1469540517-32466-1-git-send-email-o-takashi@sakamocchi.jp>

Sparse reports a below warning.

tpa6130a2.c:193:33: warning: symbol 'tpa6130a2_component_driver' was not declared. Should it be static?

These two symbols are just used inner the file, thus it's better to add
static qualifier.

This commit adds it.

Fixes: cb7e62256e99 ('ASoC: tpa6130a2: Register component')
CC: Helen Koike <helen.koike@collabora.co.uk>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/soc/codecs/tpa6130a2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
index f1ea052..8c67f3a 100644
--- a/sound/soc/codecs/tpa6130a2.c
+++ b/sound/soc/codecs/tpa6130a2.c
@@ -190,7 +190,7 @@ static const struct snd_soc_dapm_route tpa6130a2_dapm_routes[] = {
 	{ "Right PGA", NULL, "Power" },
 };
 
-struct snd_soc_component_driver tpa6130a2_component_driver = {
+static struct snd_soc_component_driver tpa6130a2_component_driver = {
 	.name = "tpa6130a2",
 	.probe = tpa6130a2_component_probe,
 	.dapm_widgets = tpa6130a2_dapm_widgets,
-- 
2.7.4

      parent reply	other threads:[~2016-07-26 13:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 13:41 [PATCH 0/5] ALSA: soc: fix sparse warnings Takashi Sakamoto
2016-07-26 13:41 ` [PATCH 1/5] ALSA: soc-da7219: fix inappropriate condition statement Takashi Sakamoto
2016-07-26 14:14   ` Adam Thomson
2016-09-28 18:27   ` Applied "ASoC: da7219: fix inappropriate condition statement" to the asoc tree Mark Brown
2016-07-26 13:41 ` [PATCH 2/5] ALSA: soc-sst-bxt-rt298: fix obsoleted initializers for array Takashi Sakamoto
2016-07-27  3:14   ` Vinod Koul
2016-09-27 16:18   ` Applied "ASoC: sst-bxt-rt298: fix obsoleted initializers for array" to the asoc tree Mark Brown
2016-07-26 13:41 ` [PATCH 3/5] ALSA: soc-sst-bxt-da7219_max98357a: fix obsoleted initializers for array Takashi Sakamoto
2016-07-27  3:15   ` Vinod Koul
2016-07-27  3:38     ` Takashi Sakamoto
2016-07-27  6:00       ` Vinod Koul
2016-07-26 13:41 ` [PATCH 4/5] ALSA: soc-rt5616: add static qualifier for file local symbols Takashi Sakamoto
2016-09-27 16:18   ` Applied "ASoC: rt5616: add static qualifier for file local symbols" to the asoc tree Mark Brown
2016-07-26 13:41 ` Takashi Sakamoto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469540517-32466-6-git-send-email-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=helen.koike@collabora.co.uk \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.