All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: joe@perches.com, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 23/26] sh_eth: constify local structures
Date: Sun, 11 Sep 2016 15:06:05 +0200	[thread overview]
Message-ID: <1473599168-30561-24-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr>

For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.

Done using Coccinelle.
Based on a suggestion by Joe Perches <joe@perches.com>.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
The semantic patch seems too long for a commit log, but is in the cover
letter.

 drivers/net/ethernet/renesas/sh_eth.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 1f8240a..d2ed57f 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -654,7 +654,7 @@ static void sh_eth_set_rate_sh7724(struct net_device *ndev)
 }
 
 /* SH7724 */
-static struct sh_eth_cpu_data sh7724_data = {
+static const struct sh_eth_cpu_data sh7724_data = {
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_sh7724,
 
@@ -692,7 +692,7 @@ static void sh_eth_set_rate_sh7757(struct net_device *ndev)
 }
 
 /* SH7757 */
-static struct sh_eth_cpu_data sh7757_data = {
+static const struct sh_eth_cpu_data sh7757_data = {
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_sh7757,
 
@@ -757,7 +757,7 @@ static void sh_eth_set_rate_giga(struct net_device *ndev)
 }
 
 /* SH7757(GETHERC) */
-static struct sh_eth_cpu_data sh7757_data_giga = {
+static const struct sh_eth_cpu_data sh7757_data_giga = {
 	.chip_reset	= sh_eth_chip_reset_giga,
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_giga,
@@ -788,7 +788,7 @@ static struct sh_eth_cpu_data sh7757_data_giga = {
 };
 
 /* SH7734 */
-static struct sh_eth_cpu_data sh7734_data = {
+static const struct sh_eth_cpu_data sh7734_data = {
 	.chip_reset	= sh_eth_chip_reset,
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_gether,
@@ -817,7 +817,7 @@ static struct sh_eth_cpu_data sh7734_data = {
 };
 
 /* SH7763 */
-static struct sh_eth_cpu_data sh7763_data = {
+static const struct sh_eth_cpu_data sh7763_data = {
 	.chip_reset	= sh_eth_chip_reset,
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_gether,
@@ -844,7 +844,7 @@ static struct sh_eth_cpu_data sh7763_data = {
 	.irq_flags	= IRQF_SHARED,
 };
 
-static struct sh_eth_cpu_data sh7619_data = {
+static const struct sh_eth_cpu_data sh7619_data = {
 	.register_type	= SH_ETH_REG_FAST_SH3_SH2,
 
 	.eesipr_value	= DMAC_M_RFRMER | DMAC_M_ECI | 0x003fffff,
@@ -855,7 +855,7 @@ static struct sh_eth_cpu_data sh7619_data = {
 	.hw_swap	= 1,
 };
 
-static struct sh_eth_cpu_data sh771x_data = {
+static const struct sh_eth_cpu_data sh771x_data = {
 	.register_type	= SH_ETH_REG_FAST_SH3_SH2,
 
 	.eesipr_value	= DMAC_M_RFRMER | DMAC_M_ECI | 0x003fffff,

WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: joe@perches.com, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 23/26] sh_eth: constify local structures
Date: Sun, 11 Sep 2016 13:06:05 +0000	[thread overview]
Message-ID: <1473599168-30561-24-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr>

For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.

Done using Coccinelle.
Based on a suggestion by Joe Perches <joe@perches.com>.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
The semantic patch seems too long for a commit log, but is in the cover
letter.

 drivers/net/ethernet/renesas/sh_eth.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 1f8240a..d2ed57f 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -654,7 +654,7 @@ static void sh_eth_set_rate_sh7724(struct net_device *ndev)
 }
 
 /* SH7724 */
-static struct sh_eth_cpu_data sh7724_data = {
+static const struct sh_eth_cpu_data sh7724_data = {
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_sh7724,
 
@@ -692,7 +692,7 @@ static void sh_eth_set_rate_sh7757(struct net_device *ndev)
 }
 
 /* SH7757 */
-static struct sh_eth_cpu_data sh7757_data = {
+static const struct sh_eth_cpu_data sh7757_data = {
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_sh7757,
 
@@ -757,7 +757,7 @@ static void sh_eth_set_rate_giga(struct net_device *ndev)
 }
 
 /* SH7757(GETHERC) */
-static struct sh_eth_cpu_data sh7757_data_giga = {
+static const struct sh_eth_cpu_data sh7757_data_giga = {
 	.chip_reset	= sh_eth_chip_reset_giga,
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_giga,
@@ -788,7 +788,7 @@ static struct sh_eth_cpu_data sh7757_data_giga = {
 };
 
 /* SH7734 */
-static struct sh_eth_cpu_data sh7734_data = {
+static const struct sh_eth_cpu_data sh7734_data = {
 	.chip_reset	= sh_eth_chip_reset,
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_gether,
@@ -817,7 +817,7 @@ static struct sh_eth_cpu_data sh7734_data = {
 };
 
 /* SH7763 */
-static struct sh_eth_cpu_data sh7763_data = {
+static const struct sh_eth_cpu_data sh7763_data = {
 	.chip_reset	= sh_eth_chip_reset,
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_gether,
@@ -844,7 +844,7 @@ static struct sh_eth_cpu_data sh7763_data = {
 	.irq_flags	= IRQF_SHARED,
 };
 
-static struct sh_eth_cpu_data sh7619_data = {
+static const struct sh_eth_cpu_data sh7619_data = {
 	.register_type	= SH_ETH_REG_FAST_SH3_SH2,
 
 	.eesipr_value	= DMAC_M_RFRMER | DMAC_M_ECI | 0x003fffff,
@@ -855,7 +855,7 @@ static struct sh_eth_cpu_data sh7619_data = {
 	.hw_swap	= 1,
 };
 
-static struct sh_eth_cpu_data sh771x_data = {
+static const struct sh_eth_cpu_data sh771x_data = {
 	.register_type	= SH_ETH_REG_FAST_SH3_SH2,
 
 	.eesipr_value	= DMAC_M_RFRMER | DMAC_M_ECI | 0x003fffff,


  parent reply	other threads:[~2016-09-11 13:28 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-11 13:05 [PATCH 00/26] constify local structures Julia Lawall
2016-09-11 13:05 ` Julia Lawall
2016-09-11 13:05 ` Julia Lawall
2016-09-11 13:05 ` [PATCH 01/26] ALSA: pci: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-12  6:19   ` Takashi Iwai
2016-09-12  6:19     ` Takashi Iwai
2016-09-12  6:19     ` Takashi Iwai
2016-09-11 13:05 ` [PATCH 02/26] lib: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-11 13:05 ` [PATCH 03/26] staging: rtl8192e: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-11 13:05 ` [PATCH 04/26] matroxfb: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-27  8:14   ` Tomi Valkeinen
2016-09-27  8:14     ` Tomi Valkeinen
2016-09-11 13:05 ` [PATCH 05/26] ARCNET: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-12 12:31   ` Julia Lawall
2016-09-12 12:31     ` Julia Lawall
2016-09-11 13:05 ` [PATCH 06/26] ath: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-14 17:02   ` [06/26] " Kalle Valo
2016-09-14 17:02     ` Kalle Valo
2016-09-11 13:05 ` [PATCH 07/26] net/mlx4_core: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-12  4:59   ` Leon Romanovsky
2016-09-12  4:59     ` Leon Romanovsky
2016-09-11 13:05 ` [PATCH 08/26] iwlegacy: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-12 11:24   ` Stanislaw Gruszka
2016-09-12 11:24     ` Stanislaw Gruszka
     [not found] ` <1473599168-30561-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2016-09-11 13:05   ` [PATCH 09/26] i40iw: " Julia Lawall
2016-09-11 13:05     ` Julia Lawall
2016-09-11 13:05     ` Julia Lawall
2016-09-11 13:05 ` [PATCH 10/26] tpm: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-11 17:09   ` Jarkko Sakkinen
2016-09-11 17:09     ` Jarkko Sakkinen
2016-09-11 17:09     ` Jarkko Sakkinen
2016-09-12  8:47     ` Julia Lawall
2016-09-12  8:47       ` Julia Lawall
2016-09-12 19:27   ` Jarkko Sakkinen
2016-09-12 19:27     ` Jarkko Sakkinen
2016-09-12 19:27     ` Jarkko Sakkinen
2016-09-11 13:05 ` [PATCH 11/26] can: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-12 12:33   ` Julia Lawall
2016-09-12 12:33     ` Julia Lawall
2016-09-11 13:05 ` [PATCH 12/26] [SCSI] hptiop: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-12 12:35   ` Julia Lawall
2016-09-12 12:35     ` Julia Lawall
2016-09-11 13:05 ` [PATCH 13/26] [media]: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-11 13:05 ` [PATCH 14/26] spi: dw-pci: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-12 12:01   ` Julia Lawall
2016-09-12 12:01     ` Julia Lawall
2016-09-12 12:01     ` Julia Lawall
2016-09-11 13:05 ` [PATCH 15/26] platform/chrome: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-11 13:05 ` [PATCH 16/26] ezusb: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-11 13:05 ` [PATCH 17/26] intel_telemetry_debugfs: " Julia Lawall
2016-09-11 13:05   ` Julia Lawall
2016-09-28 23:52   ` Darren Hart
2016-09-28 23:52     ` Darren Hart
2016-09-29  5:19     ` Julia Lawall
2016-09-29  5:19       ` Julia Lawall
2016-09-30  0:07       ` Darren Hart
2016-09-30  0:07         ` Darren Hart
2016-09-11 13:06 ` [PATCH 18/26] intel_scu_ipc: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-12 12:37   ` Julia Lawall
2016-09-12 12:37     ` Julia Lawall
2016-09-11 13:06 ` [PATCH 19/26] intel_pstate: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-12  6:42   ` Viresh Kumar
2016-09-12  6:54     ` Viresh Kumar
2016-09-14  0:59     ` Rafael J. Wysocki
2016-09-14  0:59       ` Rafael J. Wysocki
2016-09-11 13:06 ` [PATCH 20/26] stmmac: pci: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-12 12:08   ` Julia Lawall
2016-09-12 12:08     ` Julia Lawall
2016-09-11 13:06 ` [PATCH 21/26] rtlwifi: rtl818x: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-11 13:06 ` [PATCH 22/26] esas2r: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-11 13:06 ` Julia Lawall [this message]
2016-09-11 13:06   ` [PATCH 23/26] sh_eth: " Julia Lawall
2016-09-11 18:14   ` Sergei Shtylyov
2016-09-11 18:14     ` Sergei Shtylyov
2016-09-12  8:55     ` Julia Lawall
2016-09-12  8:55       ` Julia Lawall
2016-09-12  9:43     ` Julia Lawall
2016-09-12  9:43       ` Julia Lawall
2016-09-11 13:06 ` [PATCH 24/26] ACPI / APD: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-14  0:54   ` Rafael J. Wysocki
2016-09-14  0:54     ` Rafael J. Wysocki
2016-09-11 13:06 ` [PATCH 25/26] pch_gbe: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-12  2:48   ` David Miller
2016-09-12  2:48     ` David Miller
2016-09-12  9:07     ` Julia Lawall
2016-09-12  9:07       ` Julia Lawall
2016-09-12 16:33       ` David Miller
2016-09-12 16:33         ` David Miller
2016-09-12 12:25   ` Julia Lawall
2016-09-12 12:25     ` Julia Lawall
2016-09-11 13:06 ` [PATCH 26/26] sgi-xp: " Julia Lawall
2016-09-11 13:06   ` Julia Lawall
2016-09-11 17:21 ` [PATCH 00/26] " Jarkko Sakkinen
2016-09-11 17:21   ` Jarkko Sakkinen
2016-09-11 17:21   ` Jarkko Sakkinen
2016-09-12  8:54   ` Julia Lawall
2016-09-12  8:54     ` Julia Lawall
2016-09-12  8:54     ` Julia Lawall
2016-09-12 13:16     ` Jarkko Sakkinen
2016-09-12 13:16       ` Jarkko Sakkinen
2016-09-12 13:16       ` Jarkko Sakkinen
2016-09-12 13:16       ` Jarkko Sakkinen
2016-09-12 13:23       ` Julia Lawall
2016-09-12 13:23         ` Julia Lawall
2016-09-12 13:23         ` Julia Lawall
2016-09-12 13:43       ` Felipe Balbi
2016-09-12 13:43         ` Felipe Balbi
2016-09-12 13:43         ` Felipe Balbi
2016-09-12 13:43         ` Felipe Balbi
2016-09-12 13:52         ` Julia Lawall
2016-09-12 13:52           ` Julia Lawall
2016-09-12 13:52           ` Julia Lawall
2016-09-12 18:50           ` Jarkko Sakkinen
2016-09-12 18:50             ` Jarkko Sakkinen
2016-09-12 18:50             ` Jarkko Sakkinen
2016-09-12 18:50             ` Jarkko Sakkinen
2016-09-12 13:57         ` Geert Uytterhoeven
2016-09-12 13:57           ` Geert Uytterhoeven
2016-09-12 13:57           ` Geert Uytterhoeven
2016-09-12 13:57           ` Geert Uytterhoeven
2016-09-12 20:14         ` Jarkko Sakkinen
2016-09-12 20:14           ` Jarkko Sakkinen
2016-09-12 20:14           ` Jarkko Sakkinen
2016-09-12 21:11           ` Julia Lawall
2016-09-12 21:11             ` Julia Lawall
2016-09-12 21:11             ` Julia Lawall
2016-09-12 21:11             ` Julia Lawall
2016-09-11 17:56 ` Joe Perches
2016-09-11 17:56   ` Joe Perches
2016-09-11 17:56   ` Joe Perches
2016-09-11 19:11   ` Julia Lawall
2016-09-11 19:11     ` Julia Lawall
2016-09-11 19:11     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473599168-30561-24-git-send-email-Julia.Lawall@lip6.fr \
    --to=julia.lawall@lip6.fr \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.