All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 06/18] block: Assert that bdrv_release_dirty_bitmap succeeded
Date: Wed, 14 Sep 2016 18:40:50 +0200	[thread overview]
Message-ID: <1473871262-409-7-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1473871262-409-1-git-send-email-mreitz@redhat.com>

From: Fam Zheng <famz@redhat.com>

We use a loop over bs->dirty_bitmaps to make sure the caller is
only releasing a bitmap owned by bs. Let's also assert that in this case
the caller is releasing a bitmap that does exist.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 1470096763-14033-7-git-send-email-jsnow@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block/dirty-bitmap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 860acc9..31d5296 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -305,6 +305,9 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
             }
         }
     }
+    if (bitmap) {
+        abort();
+    }
 }
 
 void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)
-- 
2.5.5

  parent reply	other threads:[~2016-09-14 16:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 16:40 [Qemu-devel] [PULL 00/18] Block layer patches Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 01/18] block: Hide HBitmap in block dirty bitmap interface Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 02/18] HBitmap: Introduce "meta" bitmap to track bit changes Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 03/18] tests: Add test code for meta bitmap Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 04/18] block: Support meta dirty bitmap Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 05/18] block: Add two dirty bitmap getters Max Reitz
2016-09-14 16:40 ` Max Reitz [this message]
2016-09-14 16:40 ` [Qemu-devel] [PULL 07/18] hbitmap: serialization Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 08/18] block: BdrvDirtyBitmap serialization interface Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 09/18] tests: Add test code for hbitmap serialization Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 10/18] block: More operations for meta dirty bitmap Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 11/18] qemu-img: add the 'dd' subcommand Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 12/18] qemu-img: add skip option to dd Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 13/18] blockdev: prepare iSCSI block driver for dynamic loading Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 14/18] blockdev: Add dynamic generation of module_block.h Max Reitz
2016-09-14 16:40 ` [Qemu-devel] [PULL 15/18] blockdev: Add dynamic module loading for block drivers Max Reitz
2016-09-14 16:41 ` [Qemu-devel] [PULL 16/18] blockdev: Modularize nfs block driver Max Reitz
2016-09-14 16:41 ` [Qemu-devel] [PULL 17/18] commit: get the overlay node before manipulating the backing chain Max Reitz
2016-09-14 16:41 ` [Qemu-devel] [PULL 18/18] iotest 055: refactor and speed up Max Reitz
2016-09-14 20:16 ` [Qemu-devel] [PULL 00/18] Block layer patches no-reply
2016-09-15 16:10 ` Peter Maydell
2016-09-17 21:32   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473871262-409-7-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.