All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>, linux-nvdimm@lists.01.org
Subject: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()
Date: Tue, 27 Sep 2016 18:43:33 +0200	[thread overview]
Message-ID: <1474994615-29553-5-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1474994615-29553-1-git-send-email-jack@suse.cz>

So far we did not set BH_New for newly allocated blocks for DAX inodes
in __xfs_get_blocks() because we wanted to avoid zeroing done in generic
DAX code which was racy. Now the zeroing is gone so we can remove this
workaround and return BH_New for newly allocated blocks. DAX will use this
information to properly update mappings of the file.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/xfs/xfs_aops.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 4a28fa91e3b1..b25b7b5a1e6e 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -1245,11 +1245,8 @@ __xfs_get_blocks(
 		goto out_unlock;
 	}
 
-	if (IS_DAX(inode) && create) {
+	if (IS_DAX(inode) && create)
 		ASSERT(!ISUNWRITTEN(&imap));
-		/* zeroing is not needed at a higher layer */
-		new = 0;
-	}
 
 	/* trim mapping down to size requested */
 	xfs_map_trim_size(inode, iblock, bh_result, &imap, offset, size);
-- 
2.6.6

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: linux-nvdimm@lists.01.org,
	Dan Williams <dan.j.williams@intel.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Jan Kara <jack@suse.cz>
Subject: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()
Date: Tue, 27 Sep 2016 18:43:33 +0200	[thread overview]
Message-ID: <1474994615-29553-5-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1474994615-29553-1-git-send-email-jack@suse.cz>

So far we did not set BH_New for newly allocated blocks for DAX inodes
in __xfs_get_blocks() because we wanted to avoid zeroing done in generic
DAX code which was racy. Now the zeroing is gone so we can remove this
workaround and return BH_New for newly allocated blocks. DAX will use this
information to properly update mappings of the file.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/xfs/xfs_aops.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 4a28fa91e3b1..b25b7b5a1e6e 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -1245,11 +1245,8 @@ __xfs_get_blocks(
 		goto out_unlock;
 	}
 
-	if (IS_DAX(inode) && create) {
+	if (IS_DAX(inode) && create)
 		ASSERT(!ISUNWRITTEN(&imap));
-		/* zeroing is not needed at a higher layer */
-		new = 0;
-	}
 
 	/* trim mapping down to size requested */
 	xfs_map_trim_size(inode, iblock, bh_result, &imap, offset, size);
-- 
2.6.6


  parent reply	other threads:[~2016-09-27 16:43 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27 16:43 [PATCH 0/6] dax: Page invalidation fixes Jan Kara
2016-09-27 16:43 ` Jan Kara
2016-09-27 16:43 ` [PATCH 1/6] dax: Do not warn about BH_New buffers Jan Kara
2016-09-27 16:43   ` Jan Kara
     [not found]   ` <1474994615-29553-2-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30  8:53     ` Christoph Hellwig
2016-09-30  8:53       ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 2/6] ext2: Return BH_New buffers for zeroed blocks Jan Kara
2016-09-27 16:43   ` Jan Kara
     [not found]   ` <1474994615-29553-3-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30  8:53     ` Christoph Hellwig
2016-09-30  8:53       ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 3/6] ext4: Remove clearing of BH_New bit " Jan Kara
2016-09-27 16:43   ` Jan Kara
     [not found]   ` <1474994615-29553-4-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30  8:53     ` Christoph Hellwig
2016-09-30  8:53       ` Christoph Hellwig
2016-09-27 16:43 ` Jan Kara [this message]
2016-09-27 16:43   ` [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks() Jan Kara
     [not found]   ` <1474994615-29553-5-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-27 17:01     ` Christoph Hellwig
2016-09-27 17:01       ` Christoph Hellwig
2016-09-27 17:17       ` Jan Kara
2016-09-28  0:22         ` Dave Chinner
2016-10-03 14:44           ` Jan Kara
2016-10-03 14:44             ` Jan Kara
     [not found]         ` <20160927171707.GA30327-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-09-28  2:13           ` Christoph Hellwig
2016-09-28  2:13             ` Christoph Hellwig
2016-10-03 14:42             ` Jan Kara
     [not found]               ` <20161003144246.GA14183-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-10-03 16:39                 ` Christoph Hellwig
2016-10-03 16:39                   ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 5/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-09-27 16:43   ` Jan Kara
2016-09-28  0:18   ` Dave Chinner
2016-09-28  0:18     ` Dave Chinner
2016-10-03 14:52     ` Jan Kara
2016-10-03 14:52       ` Jan Kara
     [not found]   ` <1474994615-29553-6-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30  8:57     ` Christoph Hellwig
2016-09-30  8:57       ` Christoph Hellwig
2016-10-03 12:56       ` Jan Kara
2016-09-27 16:43 ` [PATCH 6/6] dax: Avoid page invalidation races and unnecessary radix tree traversals Jan Kara
2016-09-27 16:43   ` Jan Kara
2016-09-28  0:20   ` Dave Chinner
2016-09-28  0:20     ` Dave Chinner
2016-10-03 14:58     ` Jan Kara
2016-10-03 14:58       ` Jan Kara
2016-10-03 23:40       ` Dave Chinner
2016-10-03 23:40         ` Dave Chinner
     [not found]   ` <1474994615-29553-7-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30  8:55     ` Christoph Hellwig
2016-09-30  8:55       ` Christoph Hellwig
     [not found]       ` <20160930085544.GD22381-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-10-03 15:02         ` Jan Kara
2016-10-03 15:02           ` Jan Kara
     [not found] ` <1474994615-29553-1-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-09-30  8:59   ` [PATCH 0/6] dax: Page invalidation fixes Christoph Hellwig
2016-09-30  8:59     ` Christoph Hellwig
2016-10-03 13:01     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474994615-29553-5-git-send-email-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.