From: Neil Armstrong <narmstrong@baylibre.com>
To: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sudeep.holla@arm.com
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-amlogic@lists.infradead.org, khilman@baylibre.com,
heiko@sntech.de, wxt@rock-chips.com, frank.wang@rock-chips.com
Subject: [PATCH v4 3/8] scpi: Do not fail if get_capabilities is not implemented
Date: Wed, 5 Oct 2016 09:33:29 +0200 [thread overview]
Message-ID: <1475652814-30619-4-git-send-email-narmstrong@baylibre.com> (raw)
In-Reply-To: <1475652814-30619-1-git-send-email-narmstrong@baylibre.com>
On Amlogic SCPI legacy implementation, the GET_CAPABILITIES is not
supported, failover by using 0.0.0 version.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/firmware/arm_scpi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
index 6244eb1..1fb3bbf 100644
--- a/drivers/firmware/arm_scpi.c
+++ b/drivers/firmware/arm_scpi.c
@@ -807,6 +807,10 @@ static int scpi_init_versions(struct scpi_drvinfo *info)
info->protocol_version = le32_to_cpu(caps.protocol_version);
info->firmware_version = le32_to_cpu(caps.platform_version);
}
+ /* Ignore error if not implemented */
+ if (scpi_info->is_legacy && ret == -EOPNOTSUPP)
+ return 0;
+
return ret;
}
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/8] scpi: Do not fail if get_capabilities is not implemented
Date: Wed, 5 Oct 2016 09:33:29 +0200 [thread overview]
Message-ID: <1475652814-30619-4-git-send-email-narmstrong@baylibre.com> (raw)
In-Reply-To: <1475652814-30619-1-git-send-email-narmstrong@baylibre.com>
On Amlogic SCPI legacy implementation, the GET_CAPABILITIES is not
supported, failover by using 0.0.0 version.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/firmware/arm_scpi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
index 6244eb1..1fb3bbf 100644
--- a/drivers/firmware/arm_scpi.c
+++ b/drivers/firmware/arm_scpi.c
@@ -807,6 +807,10 @@ static int scpi_init_versions(struct scpi_drvinfo *info)
info->protocol_version = le32_to_cpu(caps.protocol_version);
info->firmware_version = le32_to_cpu(caps.platform_version);
}
+ /* Ignore error if not implemented */
+ if (scpi_info->is_legacy && ret == -EOPNOTSUPP)
+ return 0;
+
return ret;
}
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 3/8] scpi: Do not fail if get_capabilities is not implemented
Date: Wed, 5 Oct 2016 09:33:29 +0200 [thread overview]
Message-ID: <1475652814-30619-4-git-send-email-narmstrong@baylibre.com> (raw)
In-Reply-To: <1475652814-30619-1-git-send-email-narmstrong@baylibre.com>
On Amlogic SCPI legacy implementation, the GET_CAPABILITIES is not
supported, failover by using 0.0.0 version.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/firmware/arm_scpi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
index 6244eb1..1fb3bbf 100644
--- a/drivers/firmware/arm_scpi.c
+++ b/drivers/firmware/arm_scpi.c
@@ -807,6 +807,10 @@ static int scpi_init_versions(struct scpi_drvinfo *info)
info->protocol_version = le32_to_cpu(caps.protocol_version);
info->firmware_version = le32_to_cpu(caps.platform_version);
}
+ /* Ignore error if not implemented */
+ if (scpi_info->is_legacy && ret == -EOPNOTSUPP)
+ return 0;
+
return ret;
}
--
1.9.1
next prev parent reply other threads:[~2016-10-05 7:33 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 7:33 [PATCH v4 0/8] Add support for legacy SCPI protocol Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` [PATCH v4 1/8] scpi: Add cmd indirection table to prepare for legacy commands Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` [PATCH v4 2/8] scpi: Add alternative legacy structures, functions and macros Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-10 14:36 ` Sudeep Holla
2016-10-10 14:36 ` Sudeep Holla
2016-10-10 14:36 ` Sudeep Holla
2016-10-17 8:25 ` Neil Armstrong
2016-10-17 8:25 ` Neil Armstrong
2016-10-17 8:25 ` Neil Armstrong
2016-10-17 11:16 ` Sudeep Holla
2016-10-17 11:16 ` Sudeep Holla
2016-10-17 11:16 ` Sudeep Holla
2016-10-19 10:28 ` Neil Armstrong
2016-10-19 10:28 ` Neil Armstrong
2016-10-19 10:28 ` Neil Armstrong
2016-10-19 10:37 ` Sudeep Holla
2016-10-19 10:37 ` Sudeep Holla
2016-10-19 10:37 ` Sudeep Holla
2016-10-19 10:42 ` Sudeep Holla
2016-10-19 10:42 ` Sudeep Holla
2016-10-19 10:42 ` Sudeep Holla
2016-10-05 7:33 ` Neil Armstrong [this message]
2016-10-05 7:33 ` [PATCH v4 3/8] scpi: Do not fail if get_capabilities is not implemented Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` [PATCH v4 4/8] scpi: Add support for Legacy match table for Amlogic GXBB SoC Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` [PATCH v4 5/8] scpi: grow MAX_DVFS_OPPS to 16 entries Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` [PATCH v4 6/8] dt-bindings: Add support for Amlogic GXBB SCPI Interface Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-29 18:39 ` Olof Johansson
2016-10-29 18:39 ` Olof Johansson
2016-10-29 18:39 ` Olof Johansson
2016-10-29 18:39 ` Olof Johansson
2016-11-02 22:20 ` Sudeep Holla
2016-11-02 22:20 ` Sudeep Holla
2016-11-02 22:20 ` Sudeep Holla
2016-11-03 3:51 ` Rob Herring
2016-11-03 3:51 ` Rob Herring
2016-11-03 3:51 ` Rob Herring
2016-11-03 4:37 ` Sudeep Holla
2016-11-03 4:37 ` Sudeep Holla
2016-11-03 4:37 ` Sudeep Holla
2016-11-03 8:48 ` Neil Armstrong
2016-11-03 8:48 ` Neil Armstrong
2016-11-03 8:48 ` Neil Armstrong
2016-11-03 8:48 ` Neil Armstrong
2016-10-05 7:33 ` [PATCH v4 7/8] ARM64: dts: meson-gxbb: Add SRAM node Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` [PATCH v4 8/8] ARM64: dts: meson-gxbb: Add SCPI with cpufreq & sensors Nodes Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
2016-10-05 7:33 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475652814-30619-4-git-send-email-narmstrong@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=frank.wang@rock-chips.com \
--cc=heiko@sntech.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.