From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> To: <ath10k@lists.infradead.org> Cc: <mohammed@codeaurora.org>, <linux-wireless@vger.kernel.org>, "Mohammed Shafi Shajakhan" <mohammed@qti.qualcomm.com> Subject: [PATCH v2 2/2] ath10k: Remove extraneous error message in tx alloc Date: Thu, 6 Oct 2016 14:09:48 +0530 [thread overview] Message-ID: <1475743188-12007-2-git-send-email-mohammed@qca.qualcomm.com> (raw) In-Reply-To: <1475743188-12007-1-git-send-email-mohammed@qca.qualcomm.com> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> --- [v2 rebased over top of tree] drivers/net/wireless/ath/ath10k/htt_tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c index 786fbd7..4255c1a 100644 --- a/drivers/net/wireless/ath/ath10k/htt_tx.c +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c @@ -283,10 +283,8 @@ static int ath10k_htt_tx_alloc_cont_frag_desc(struct ath10k_htt *htt) htt->frag_desc.vaddr = dma_alloc_coherent(ar->dev, size, &htt->frag_desc.paddr, GFP_KERNEL); - if (!htt->frag_desc.vaddr) { - ath10k_err(ar, "failed to alloc fragment desc memory\n"); + if (!htt->frag_desc.vaddr) return -ENOMEM; - } return 0; } -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> To: ath10k@lists.infradead.org Cc: mohammed@codeaurora.org, linux-wireless@vger.kernel.org, Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> Subject: [PATCH v2 2/2] ath10k: Remove extraneous error message in tx alloc Date: Thu, 6 Oct 2016 14:09:48 +0530 [thread overview] Message-ID: <1475743188-12007-2-git-send-email-mohammed@qca.qualcomm.com> (raw) In-Reply-To: <1475743188-12007-1-git-send-email-mohammed@qca.qualcomm.com> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> --- [v2 rebased over top of tree] drivers/net/wireless/ath/ath10k/htt_tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c index 786fbd7..4255c1a 100644 --- a/drivers/net/wireless/ath/ath10k/htt_tx.c +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c @@ -283,10 +283,8 @@ static int ath10k_htt_tx_alloc_cont_frag_desc(struct ath10k_htt *htt) htt->frag_desc.vaddr = dma_alloc_coherent(ar->dev, size, &htt->frag_desc.paddr, GFP_KERNEL); - if (!htt->frag_desc.vaddr) { - ath10k_err(ar, "failed to alloc fragment desc memory\n"); + if (!htt->frag_desc.vaddr) return -ENOMEM; - } return 0; } -- 1.9.1 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-10-06 8:40 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-06 8:39 [PATCH v2 1/2] ath10k: clean up HTT tx buffer allocation and free Mohammed Shafi Shajakhan 2016-10-06 8:39 ` Mohammed Shafi Shajakhan 2016-10-06 8:39 ` Mohammed Shafi Shajakhan [this message] 2016-10-06 8:39 ` [PATCH v2 2/2] ath10k: Remove extraneous error message in tx alloc Mohammed Shafi Shajakhan 2016-10-11 11:36 ` [v2,1/2] ath10k: clean up HTT tx buffer allocation and free Kalle Valo 2016-10-11 11:36 ` Kalle Valo 2016-10-12 7:09 ` Mohammed Shafi Shajakhan 2016-10-12 7:09 ` Mohammed Shafi Shajakhan 2016-10-12 7:35 ` Valo, Kalle 2016-10-12 7:35 ` Valo, Kalle
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1475743188-12007-2-git-send-email-mohammed@qca.qualcomm.com \ --to=mohammed@qti.qualcomm.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=mohammed@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.