All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, linux@arm.linux.org.uk,
	herbert@gondor.apana.org.au
Cc: steve.capper@linaro.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 4/5] crypto: arm/sha1-ce - enable module autoloading based on CPU feature bits
Date: Tue, 18 Oct 2016 11:52:18 +0100	[thread overview]
Message-ID: <1476787939-21889-5-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1476787939-21889-1-git-send-email-ard.biesheuvel@linaro.org>

Make the module autoloadable by tying it to the CPU feature bit that
describes whether the optional instructions it relies on are implemented
by the current CPU.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 arch/arm/crypto/sha1-ce-glue.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/crypto/sha1-ce-glue.c b/arch/arm/crypto/sha1-ce-glue.c
index 80bc2fcd241a..555f72b5e659 100644
--- a/arch/arm/crypto/sha1-ce-glue.c
+++ b/arch/arm/crypto/sha1-ce-glue.c
@@ -11,6 +11,7 @@
 #include <crypto/internal/hash.h>
 #include <crypto/sha.h>
 #include <crypto/sha1_base.h>
+#include <linux/cpufeature.h>
 #include <linux/crypto.h>
 #include <linux/module.h>
 
@@ -82,8 +83,6 @@ static struct shash_alg alg = {
 
 static int __init sha1_ce_mod_init(void)
 {
-	if (!(elf_hwcap2 & HWCAP2_SHA1))
-		return -ENODEV;
 	return crypto_register_shash(&alg);
 }
 
@@ -92,5 +91,5 @@ static void __exit sha1_ce_mod_fini(void)
 	crypto_unregister_shash(&alg);
 }
 
-module_init(sha1_ce_mod_init);
+module_cpu_feature_match(SHA1, sha1_ce_mod_init);
 module_exit(sha1_ce_mod_fini);
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] crypto: arm/sha1-ce - enable module autoloading based on CPU feature bits
Date: Tue, 18 Oct 2016 11:52:18 +0100	[thread overview]
Message-ID: <1476787939-21889-5-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1476787939-21889-1-git-send-email-ard.biesheuvel@linaro.org>

Make the module autoloadable by tying it to the CPU feature bit that
describes whether the optional instructions it relies on are implemented
by the current CPU.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 arch/arm/crypto/sha1-ce-glue.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/crypto/sha1-ce-glue.c b/arch/arm/crypto/sha1-ce-glue.c
index 80bc2fcd241a..555f72b5e659 100644
--- a/arch/arm/crypto/sha1-ce-glue.c
+++ b/arch/arm/crypto/sha1-ce-glue.c
@@ -11,6 +11,7 @@
 #include <crypto/internal/hash.h>
 #include <crypto/sha.h>
 #include <crypto/sha1_base.h>
+#include <linux/cpufeature.h>
 #include <linux/crypto.h>
 #include <linux/module.h>
 
@@ -82,8 +83,6 @@ static struct shash_alg alg = {
 
 static int __init sha1_ce_mod_init(void)
 {
-	if (!(elf_hwcap2 & HWCAP2_SHA1))
-		return -ENODEV;
 	return crypto_register_shash(&alg);
 }
 
@@ -92,5 +91,5 @@ static void __exit sha1_ce_mod_fini(void)
 	crypto_unregister_shash(&alg);
 }
 
-module_init(sha1_ce_mod_init);
+module_cpu_feature_match(SHA1, sha1_ce_mod_init);
 module_exit(sha1_ce_mod_fini);
-- 
2.7.4

  parent reply	other threads:[~2016-10-18 10:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 10:52 [PATCH 0/5] ARM: add module autoloading support for crypto modules Ard Biesheuvel
2016-10-18 10:52 ` Ard Biesheuvel
2016-10-18 10:52 ` [PATCH 1/5] ARM: wire up HWCAP2 feature bits to the CPU modalias Ard Biesheuvel
2016-10-18 10:52   ` Ard Biesheuvel
2016-10-29 10:08   ` Ard Biesheuvel
2016-10-29 10:08     ` Ard Biesheuvel
2016-10-31 16:13     ` Russell King - ARM Linux
2016-10-31 16:13       ` Russell King - ARM Linux
2017-01-02 21:06       ` Ard Biesheuvel
2017-01-02 21:06         ` Ard Biesheuvel
2017-01-02 23:40         ` Russell King - ARM Linux
2017-01-02 23:40           ` Russell King - ARM Linux
2017-01-04 16:42           ` Ard Biesheuvel
2017-01-04 16:42             ` Ard Biesheuvel
2016-10-18 10:52 ` [PATCH 2/5] crypto: arm/aes-ce - enable module autoloading based on CPU feature bits Ard Biesheuvel
2016-10-18 10:52   ` Ard Biesheuvel
2016-10-18 10:52 ` [PATCH 3/5] crypto: arm/ghash-ce " Ard Biesheuvel
2016-10-18 10:52   ` Ard Biesheuvel
2016-10-18 10:52 ` Ard Biesheuvel [this message]
2016-10-18 10:52   ` [PATCH 4/5] crypto: arm/sha1-ce " Ard Biesheuvel
2016-10-18 10:52 ` [PATCH 5/5] crypto: arm/sha2-ce " Ard Biesheuvel
2016-10-18 10:52   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476787939-21889-5-git-send-email-ard.biesheuvel@linaro.org \
    --to=ard.biesheuvel@linaro.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=steve.capper@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.