All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, jbeulich@suse.com,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	roger.pau@citrix.com
Subject: [PATCH 05/10] acpi: Make pmtimer optional in FADT
Date: Sun,  6 Nov 2016 16:42:38 -0500	[thread overview]
Message-ID: <1478468563-5396-6-git-send-email-boris.ostrovsky@oracle.com> (raw)
In-Reply-To: <1478468563-5396-1-git-send-email-boris.ostrovsky@oracle.com>

PM timer is not supported by PVH guests.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 tools/firmware/hvmloader/util.c | 3 ++-
 tools/libacpi/build.c           | 5 +++++
 tools/libacpi/libacpi.h         | 1 +
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c
index 6e0cfe7..1d78973 100644
--- a/tools/firmware/hvmloader/util.c
+++ b/tools/firmware/hvmloader/util.c
@@ -948,7 +948,8 @@ void hvmloader_acpi_build_tables(struct acpi_config *config,
     if ( !strncmp(xenstore_read("platform/acpi_s4", "1"), "1", 1)  )
         config->table_flags |= ACPI_HAS_SSDT_S4;
 
-    config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | ACPI_HAS_WAET);
+    config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC |
+                            ACPI_HAS_WAET | ACPI_HAS_PMTIMER);
 
     config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS;
 
diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c
index 47dae01..58822d3 100644
--- a/tools/libacpi/build.c
+++ b/tools/libacpi/build.c
@@ -574,6 +574,11 @@ int acpi_build_tables(struct acpi_ctxt *ctxt, struct acpi_config *config)
 
     fadt = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_fadt), 16);
     if (!fadt) goto oom;
+    if ( !(config->table_flags & ACPI_HAS_PMTIMER) )
+    {
+        Fadt.pm_tmr_blk = 0;
+        memset(&Fadt.x_pm_tmr_blk, 0, sizeof(Fadt.x_pm_tmr_blk));
+    }
     memcpy(fadt, &Fadt, sizeof(struct acpi_20_fadt));
     fadt->dsdt   = ctxt->mem_ops.v2p(ctxt, dsdt);
     fadt->x_dsdt = ctxt->mem_ops.v2p(ctxt, dsdt);
diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h
index 1d388f9..bda692e 100644
--- a/tools/libacpi/libacpi.h
+++ b/tools/libacpi/libacpi.h
@@ -30,6 +30,7 @@
 #define ACPI_HAS_TCPA        (1<<7)
 #define ACPI_HAS_IOAPIC      (1<<8)
 #define ACPI_HAS_WAET        (1<<9)
+#define ACPI_HAS_PMTIMER     (1<<10)
 
 struct xen_vmemrange;
 struct acpi_numa {
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-11-06 21:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-06 21:42 [PATCH 00/10] PVH VCPU hotplug support Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 01/10] x86/domctl: Add XEN_DOMCTL_set_avail_vcpus Boris Ostrovsky
2016-11-07 15:30   ` Konrad Rzeszutek Wilk
2016-11-07 18:24     ` Boris Ostrovsky
2016-11-08 19:07   ` Daniel De Graaf
2016-11-06 21:42 ` [PATCH 02/10] acpi: Define ACPI IO registers for PVH guests Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 03/10] pvh: Set online VCPU map to avail_vcpus Boris Ostrovsky
2016-11-07 15:36   ` Konrad Rzeszutek Wilk
2016-11-07 15:52     ` Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 04/10] acpi: Power and Sleep ACPI buttons are not emulated Boris Ostrovsky
2016-11-07 15:38   ` Konrad Rzeszutek Wilk
2016-11-07 15:54     ` Boris Ostrovsky
2016-11-07 17:24     ` annie li
2016-11-06 21:42 ` Boris Ostrovsky [this message]
2016-11-07 15:39   ` [PATCH 05/10] acpi: Make pmtimer optional in FADT Konrad Rzeszutek Wilk
2016-11-06 21:42 ` [PATCH 06/10] acpi: PVH guests need _E02 method Boris Ostrovsky
2016-11-07 15:45   ` Konrad Rzeszutek Wilk
2016-11-07 16:08     ` Boris Ostrovsky
2016-11-07 16:08       ` Konrad Rzeszutek Wilk
2016-11-06 21:42 ` [PATCH 07/10] pvh/ioreq: Install handlers for ACPI-related PVH IO accesses Boris Ostrovsky
2016-11-07  9:39   ` Paul Durrant
2016-11-07 14:01     ` Boris Ostrovsky
2016-11-07 14:00       ` Paul Durrant
2016-11-06 21:42 ` [PATCH 08/10] pvh/acpi: Handle ACPI accesses for PVH guests Boris Ostrovsky
2016-11-07  9:51   ` Paul Durrant
2016-11-08 16:14     ` Boris Ostrovsky
2016-11-07 15:55   ` Konrad Rzeszutek Wilk
2016-11-07 16:20     ` Boris Ostrovsky
2016-11-07 16:47     ` Jan Beulich
2016-11-06 21:42 ` [PATCH 09/10] events/x86: Define SCI virtual interrupt Boris Ostrovsky
2016-11-07 16:05   ` Konrad Rzeszutek Wilk
2016-11-07 16:29     ` Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 10/10] pvh: Send an SCI on VCPU hotplug event Boris Ostrovsky
2016-11-07 11:41 ` [PATCH 00/10] PVH VCPU hotplug support Andrew Cooper
2016-11-07 14:19   ` Boris Ostrovsky
2016-11-07 14:46     ` Andrew Cooper
2016-11-07 15:30       ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478468563-5396-6-git-send-email-boris.ostrovsky@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.