All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
	Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
	Christoph Hellwig <hch@lst.de>,
	Matthew Wilcox <willy@infradead.org>,
	Logan Gunthorpe <logang@deltatee.com>,
	linux-block@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 8/9] iov_iter, block: Make bio structs pin pages rather than ref'ing if appropriate
Date: Thu, 12 Jan 2023 14:58:49 +0000	[thread overview]
Message-ID: <147887.1673535529@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y8AWY991ilrO5Yco@infradead.org>

Christoph Hellwig <hch@infradead.org> wrote:

> But given that all calls for the same iter type return the same
> cleanup_mode by defintion I'm not even sure we need any of this
> debug checking, and might as well just do:
> 
> 	if (cleanup_mode & FOLL_GET)
>  		bio_set_flag(bio, BIO_PAGE_REFFED);
>  	else if (cleanup_mode & FOLL_PIN)
>  		bio_set_flag(bio, BIO_PAGE_PINNED);

That's kind of what I'm doing - though I've left out the else just in case the
VM decides to indicate back both FOLL_GET and FOLL_PIN.  I'm not sure why it
would but...

David


  parent reply	other threads:[~2023-01-12 15:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 14:27 [PATCH v5 0/9] iov_iter: Add extraction helpers David Howells
2023-01-11 14:27 ` [PATCH v5 1/9] iov_iter: Change the direction macros into an enum David Howells
2023-01-11 14:27 ` [PATCH v5 2/9] iov_iter: Use the direction in the iterator functions David Howells
2023-01-11 14:27 ` [PATCH v5 3/9] iov_iter: Use IOCB/IOMAP_WRITE if available rather than iterator direction David Howells
2023-01-12  7:54   ` Christoph Hellwig
2023-01-12 10:31   ` David Howells
2023-01-12 14:08     ` Christoph Hellwig
2023-01-12 17:37       ` Al Viro
2023-01-12 21:49         ` Bart Van Assche
2023-01-13  5:32           ` Christoph Hellwig
2023-01-14  1:33             ` Martin K. Petersen
2023-01-14  1:34           ` Martin K. Petersen
2023-01-14  1:58             ` Al Viro
2023-01-13  5:30         ` Christoph Hellwig
2023-01-12 21:56   ` Al Viro
2023-01-13  5:33     ` Christoph Hellwig
2023-01-11 14:28 ` [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-01-12  7:55   ` Christoph Hellwig
2023-01-12 21:15   ` Al Viro
2023-01-12 21:36     ` Al Viro
2023-01-13  5:26     ` Christoph Hellwig
2023-01-11 14:28 ` [PATCH v5 5/9] netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator David Howells
2023-01-11 14:28 ` [PATCH v5 6/9] netfs: Add a function to extract an iterator into a scatterlist David Howells
2023-01-11 14:28 ` [PATCH v5 7/9] bio: Rename BIO_NO_PAGE_REF to BIO_PAGE_REFFED and invert the meaning David Howells
2023-01-12  7:32   ` Christoph Hellwig
2023-01-11 14:28 ` [PATCH v5 8/9] iov_iter, block: Make bio structs pin pages rather than ref'ing if appropriate David Howells
2023-01-12  7:44   ` Christoph Hellwig
2023-01-12 10:28   ` David Howells
2023-01-12 14:09     ` Christoph Hellwig
2023-01-12 14:17       ` Christoph Hellwig
2023-01-12 14:58       ` David Howells [this message]
2023-01-12 15:02         ` Christoph Hellwig
2023-01-11 14:28 ` [PATCH v5 9/9] bio: Fix bio_flagged() so that it can be combined David Howells
2023-01-12  7:33   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=147887.1673535529@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.