All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jsnow@redhat.com
Subject: [Qemu-devel] [PULL 2/9] ahci-test: Create smaller test ISO images
Date: Fri, 11 Nov 2016 13:49:48 -0500	[thread overview]
Message-ID: <1478890195-30841-3-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1478890195-30841-1-git-send-email-jsnow@redhat.com>

These can simply be the size of the number of sectors we're reading,
plus one for a buffer. We don't need them to be any larger.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 1477970211-25754-3-git-send-email-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/ahci-test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 70bcafa..a271cad 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -1494,9 +1494,10 @@ static void ahci_test_cdrom(int nsectors, bool dma)
         .atapi_dma = dma,
         .post_cb = ahci_cb_cmp_buff,
     };
+    uint64_t iso_size = ATAPI_SECTOR_SIZE * (nsectors + 1);
 
     /* Prepare ISO and fill 'tx' buffer */
-    fd = prepare_iso(1024 * 1024, &tx, &iso);
+    fd = prepare_iso(iso_size, &tx, &iso);
     opts.opaque = tx;
 
     /* Standard startup wonkery, but use ide-cd and our special iso file */
-- 
2.7.4

  parent reply	other threads:[~2016-11-11 18:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 18:49 [Qemu-devel] [PULL 0/9] Ide patches John Snow
2016-11-11 18:49 ` [Qemu-devel] [PULL 1/9] atapi: classify read_cd as conditionally returning data John Snow
2016-11-11 18:49 ` John Snow [this message]
2016-11-11 18:49 ` [Qemu-devel] [PULL 3/9] ahci-test: test atapi read_cd with bcl, nb_sectors = 0 John Snow
2016-11-11 18:49 ` [Qemu-devel] [PULL 4/9] block-backend: Always notify on blk_eject John Snow
2016-11-11 18:49 ` [Qemu-devel] [PULL 5/9] libqtest: add qmp_eventwait_ref John Snow
2016-11-11 18:49 ` [Qemu-devel] [PULL 6/9] libqos/ahci: Support expected errors John Snow
2016-11-11 18:49 ` [Qemu-devel] [PULL 7/9] libqos/ahci: Add ATAPI tray macros John Snow
2016-11-11 18:49 ` [Qemu-devel] [PULL 8/9] libqos/ahci: Add get_sense and test_ready John Snow
2016-11-11 18:49 ` [Qemu-devel] [PULL 9/9] ahci-test: add QMP tray test for ATAPI John Snow
2016-11-13  3:32 ` [Qemu-devel] [PULL 0/9] Ide patches no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478890195-30841-3-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.