All of lore.kernel.org
 help / color / mirror / Atom feed
From: peng.liang5@zte.com.cn
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: zhang.kai16@zte.com.cn, PengLiang <peng.liang5@zte.com.cn>,
	dm-devel@redhat.com
Subject: [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue
Date: Fri, 25 Nov 2016 14:36:04 +0800	[thread overview]
Message-ID: <1480055764-11124-1-git-send-email-peng.liang5@zte.com.cn> (raw)

From: PengLiang <peng.liang5@zte.com.cn>

If no_path_retry set to queue, we should make sure dev_loss_tmo update to MAX_DEV_LOSS_TMO.
But, it will be limit to 600 if fast_io_fail_tmo set to off or 0 meanwhile.

Signed-off-by: PengLiang <peng.liang5@zte.com.cn>
---
 libmultipath/discovery.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index aaa915c..05b0842 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -608,7 +608,8 @@ sysfs_set_rport_tmo(struct multipath *mpp, struct path *pp)
 				goto out;
 			}
 		}
-	} else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO) {
+	} else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO &&
+		mpp->no_path_retry != NO_PATH_RETRY_QUEUE) {
 		condlog(3, "%s: limiting dev_loss_tmo to %d, since "
 			"fast_io_fail is not set",
 			rport_id, DEFAULT_DEV_LOSS_TMO);
-- 
2.8.1.windows.1

             reply	other threads:[~2016-11-25  6:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  6:36 peng.liang5 [this message]
2016-11-26  9:05 ` [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue Christophe Varoqui
2016-11-29  0:16 ` Benjamin Marzinski
2016-12-01  1:06 peng.liang5
2016-12-01 16:44 ` Benjamin Marzinski
2016-12-07  6:42 peng.liang5
2016-12-07  6:57 ` Hannes Reinecke
2016-12-07 17:08 ` Benjamin Marzinski
2016-12-08  1:38 peng.liang5

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480055764-11124-1-git-send-email-peng.liang5@zte.com.cn \
    --to=peng.liang5@zte.com.cn \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=zhang.kai16@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.