From: Aniroop Mathur <a.mathur@samsung.com>
To: daniel.stone@nokia.com, timo.o.karjalainen@nokia.com,
felipe.balbi@nokia.com, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: s.samuel@samsung.com, r.mahale@samsung.com,
aniroop.mathur@gmail.com, Aniroop Mathur <a.mathur@samsung.com>
Subject: [PATCH] Input: keyboard: lm8323 - Change msleep to usleep_range for small msecs
Date: Mon, 28 Nov 2016 22:40:09 +0530 [thread overview]
Message-ID: <1480353009-1483-1-git-send-email-a.mathur@samsung.com> (raw)
msleep(1~20) may not do what the caller intends, and will often sleep longer.
(~20 ms actual sleep for any value given in the 1~20ms range)
This is not the desired behaviour for many cases like device resume time,
device suspend time, device enable time, retry logic, etc.
Thus, change msleep to usleep_range for precise wakeups.
Signed-off-by: Aniroop Mathur <a.mathur@samsung.com>
---
drivers/input/keyboard/lm8323.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
index 21bea52..14679e9 100644
--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c
@@ -689,7 +689,7 @@ static int lm8323_probe(struct i2c_client *client,
break;
}
- msleep(1);
+ usleep_range(1000, 1100);
}
lm8323_configure(lm);
--
2.6.2
next reply other threads:[~2016-11-28 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 17:10 Aniroop Mathur [this message]
2016-12-03 16:58 ` [PATCH] Input: keyboard: lm8323 - Change msleep to usleep_range for small msecs Aniroop Mathur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480353009-1483-1-git-send-email-a.mathur@samsung.com \
--to=a.mathur@samsung.com \
--cc=aniroop.mathur@gmail.com \
--cc=daniel.stone@nokia.com \
--cc=dmitry.torokhov@gmail.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r.mahale@samsung.com \
--cc=s.samuel@samsung.com \
--cc=timo.o.karjalainen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.