From: Sarangdhar Joshi <spjoshi@codeaurora.org> To: Ohad Ben-Cohen <ohad@wizery.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Santosh Shilimkar <ssantosh@kernel.org> Cc: Sarangdhar Joshi <spjoshi@codeaurora.org>, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Dave Gerlach <d-gerlach@ti.com>, Suman Anna <s-anna@ti.com>, Stephen Boyd <sboyd@codeaurora.org>, Trilok Soni <tsoni@codeaurora.org> Subject: [PATCH 2/2] remoteproc: Remove firmware_loading_complete Date: Thu, 15 Dec 2016 16:03:52 -0800 [thread overview] Message-ID: <1481846632-4778-2-git-send-email-spjoshi@codeaurora.org> (raw) In-Reply-To: <1481846632-4778-1-git-send-email-spjoshi@codeaurora.org> rproc_del() waits on firmware_loading_complete in order to make sure rproc_add() completed successfully before calling rproc_shutdown(). However since rproc_add() will always be called before rproc_del(), we do not need to wait on firmware_loading_complete. Drop this completion variable altogether. Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> --- Sending this patch again since I had missed usage of firmware_loading_complete in drivers/soc/ti/wkup_m3_ipc.c drivers/remoteproc/remoteproc_core.c | 12 +----------- include/linux/remoteproc.h | 2 -- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 953ee29..862fa4e 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -975,17 +975,12 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context) rproc_boot(rproc); release_firmware(fw); - /* allow rproc_del() contexts, if any, to proceed */ - complete_all(&rproc->firmware_loading_complete); } static int rproc_add_virtio_devices(struct rproc *rproc) { int ret; - /* rproc_del() calls must wait until async loader completes */ - init_completion(&rproc->firmware_loading_complete); - /* * We must retrieve early virtio configuration info from * the firmware (e.g. whether to register a virtio device, @@ -997,10 +992,8 @@ static int rproc_add_virtio_devices(struct rproc *rproc) ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_HOTPLUG, rproc->firmware, &rproc->dev, GFP_KERNEL, rproc, rproc_fw_config_virtio); - if (ret < 0) { + if (ret < 0) dev_err(&rproc->dev, "request_firmware_nowait err: %d\n", ret); - complete_all(&rproc->firmware_loading_complete); - } return ret; } @@ -1483,9 +1476,6 @@ int rproc_del(struct rproc *rproc) if (!rproc) return -EINVAL; - /* if rproc is just being registered, wait */ - wait_for_completion(&rproc->firmware_loading_complete); - /* if rproc is marked always-on, rproc_add() booted it */ /* TODO: make sure this works with rproc->power > 1 */ if (rproc->auto_boot) diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index e2f3a32..19d84a0 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -397,7 +397,6 @@ enum rproc_crash_type { * @num_traces: number of trace buffers * @carveouts: list of physically contiguous memory allocations * @mappings: list of iommu mappings we initiated, needed on shutdown - * @firmware_loading_complete: marks e/o asynchronous firmware loading * @bootaddr: address of first instruction to boot rproc with (optional) * @rvdevs: list of remote virtio devices * @subdevs: list of subdevices, to following the running state @@ -428,7 +427,6 @@ struct rproc { int num_traces; struct list_head carveouts; struct list_head mappings; - struct completion firmware_loading_complete; u32 bootaddr; struct list_head rvdevs; struct list_head subdevs; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: spjoshi@codeaurora.org (Sarangdhar Joshi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] remoteproc: Remove firmware_loading_complete Date: Thu, 15 Dec 2016 16:03:52 -0800 [thread overview] Message-ID: <1481846632-4778-2-git-send-email-spjoshi@codeaurora.org> (raw) In-Reply-To: <1481846632-4778-1-git-send-email-spjoshi@codeaurora.org> rproc_del() waits on firmware_loading_complete in order to make sure rproc_add() completed successfully before calling rproc_shutdown(). However since rproc_add() will always be called before rproc_del(), we do not need to wait on firmware_loading_complete. Drop this completion variable altogether. Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> --- Sending this patch again since I had missed usage of firmware_loading_complete in drivers/soc/ti/wkup_m3_ipc.c drivers/remoteproc/remoteproc_core.c | 12 +----------- include/linux/remoteproc.h | 2 -- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 953ee29..862fa4e 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -975,17 +975,12 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context) rproc_boot(rproc); release_firmware(fw); - /* allow rproc_del() contexts, if any, to proceed */ - complete_all(&rproc->firmware_loading_complete); } static int rproc_add_virtio_devices(struct rproc *rproc) { int ret; - /* rproc_del() calls must wait until async loader completes */ - init_completion(&rproc->firmware_loading_complete); - /* * We must retrieve early virtio configuration info from * the firmware (e.g. whether to register a virtio device, @@ -997,10 +992,8 @@ static int rproc_add_virtio_devices(struct rproc *rproc) ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_HOTPLUG, rproc->firmware, &rproc->dev, GFP_KERNEL, rproc, rproc_fw_config_virtio); - if (ret < 0) { + if (ret < 0) dev_err(&rproc->dev, "request_firmware_nowait err: %d\n", ret); - complete_all(&rproc->firmware_loading_complete); - } return ret; } @@ -1483,9 +1476,6 @@ int rproc_del(struct rproc *rproc) if (!rproc) return -EINVAL; - /* if rproc is just being registered, wait */ - wait_for_completion(&rproc->firmware_loading_complete); - /* if rproc is marked always-on, rproc_add() booted it */ /* TODO: make sure this works with rproc->power > 1 */ if (rproc->auto_boot) diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index e2f3a32..19d84a0 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -397,7 +397,6 @@ enum rproc_crash_type { * @num_traces: number of trace buffers * @carveouts: list of physically contiguous memory allocations * @mappings: list of iommu mappings we initiated, needed on shutdown - * @firmware_loading_complete: marks e/o asynchronous firmware loading * @bootaddr: address of first instruction to boot rproc with (optional) * @rvdevs: list of remote virtio devices * @subdevs: list of subdevices, to following the running state @@ -428,7 +427,6 @@ struct rproc { int num_traces; struct list_head carveouts; struct list_head mappings; - struct completion firmware_loading_complete; u32 bootaddr; struct list_head rvdevs; struct list_head subdevs; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-12-16 0:03 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-16 0:03 [PATCH 1/2] soc: ti: Use remoteproc auto_boot feature Sarangdhar Joshi 2016-12-16 0:03 ` Sarangdhar Joshi 2016-12-16 0:03 ` Sarangdhar Joshi [this message] 2016-12-16 0:03 ` [PATCH 2/2] remoteproc: Remove firmware_loading_complete Sarangdhar Joshi 2016-12-16 8:26 ` loic pallardy 2016-12-16 8:26 ` loic pallardy 2016-12-16 8:26 ` loic pallardy 2016-12-16 19:28 ` Bjorn Andersson 2016-12-16 19:28 ` Bjorn Andersson 2016-12-17 2:41 ` Sarangdhar Joshi 2016-12-17 2:41 ` Sarangdhar Joshi 2016-12-17 2:41 ` Sarangdhar Joshi 2016-12-22 3:16 ` [PATCH 1/2] soc: ti: Use remoteproc auto_boot feature Suman Anna 2016-12-22 3:16 ` Suman Anna 2016-12-22 3:16 ` Suman Anna 2016-12-22 13:02 ` Bjorn Andersson 2016-12-22 13:02 ` Bjorn Andersson 2016-12-23 0:07 ` Sarangdhar Joshi 2016-12-23 0:07 ` Sarangdhar Joshi 2016-12-23 16:55 ` Suman Anna 2016-12-23 16:55 ` Suman Anna 2016-12-23 16:55 ` Suman Anna 2016-12-23 0:01 ` Sarangdhar Joshi 2016-12-23 0:01 ` Sarangdhar Joshi 2016-12-23 17:05 ` Suman Anna 2016-12-23 17:05 ` Suman Anna 2016-12-23 17:05 ` Suman Anna 2016-12-23 23:57 ` Suman Anna 2016-12-23 23:57 ` Suman Anna 2016-12-23 23:57 ` Suman Anna 2017-01-03 23:52 ` Sarangdhar Joshi 2017-01-03 23:52 ` Sarangdhar Joshi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1481846632-4778-2-git-send-email-spjoshi@codeaurora.org \ --to=spjoshi@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=d-gerlach@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=ohad@wizery.com \ --cc=s-anna@ti.com \ --cc=sboyd@codeaurora.org \ --cc=ssantosh@kernel.org \ --cc=tsoni@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.