From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: minyard@acm.org, Corey Minyard <cminyard@mvista.com>
Subject: [Qemu-devel] [PATCH 02/19] i2c-smbus: Use a int for return
Date: Fri, 30 Dec 2016 09:21:33 -0600 [thread overview]
Message-ID: <1483111310-24808-3-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1483111310-24808-1-git-send-email-minyard@acm.org>
From: Corey Minyard <cminyard@mvista.com>
The return value from getting the data may be an error, so
use an integer to hold it.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
hw/i2c/smbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c
index 2d1b79a..c631a1c 100644
--- a/hw/i2c/smbus.c
+++ b/hw/i2c/smbus.c
@@ -222,7 +222,7 @@ int smbus_quick_command(I2CBus *bus, uint8_t addr, int read)
int smbus_receive_byte(I2CBus *bus, uint8_t addr)
{
- uint8_t data;
+ int data;
if (i2c_start_transfer(bus, addr, 1)) {
return -1;
--
2.7.4
next prev parent reply other threads:[~2016-12-30 15:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 15:21 [Qemu-devel] [PATCH 01/18] Patch set to get full IPMI over SMBus minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 01/19] i2c: Allow I2C devices to NAK start events minyard
2016-12-30 15:21 ` minyard [this message]
2016-12-30 15:21 ` [Qemu-devel] [PATCH 03/19] i2c:pm_smbus: Clean up some style issues minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 04/19] i2c:pm_smbus: Fix the semantics of block I2C transfers minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 05/19] i2c:pm_smbus: Make the I2C block read command read-only minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 06/19] i2c:pm_smbus: Add block transfer capability minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 07/19] i2c:pm_smbus: Fix state transfer minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 08/19] i2c:pm_smbus: Add interrupt handling minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 09/19] i2c:pm_smbus: Add the ability to force block transfer enable minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 10/19] ipmi: Add an SMBus IPMI interface minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 11/19] acpi: Add i2c serial bus CRS handling minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 12/19] ipmi: Fix SSIF ACPI handling to use the right CRS minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 13/19] pc: Add _enabled to the end of some boolean flags minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 14/19] pc: Add an SMB0 ACPI device to q35 minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 15/19] hw: Add an IRQ interface minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 16/19] isa: Add an irq device minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 17/19] i2c: Allow SMBus device to NAK start events minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 18/19] i2c: Add an SMBus alert device minyard
2016-12-30 15:21 ` [Qemu-devel] [PATCH 19/19] ipmi_smbus: Add alert capability to the IPMI SSIF code minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483111310-24808-3-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.