From: Guenter Roeck <linux@roeck-us.net> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>, Chen-Yu Tsai <wens@csie.org>, Hans de Goede <hdegoede@redhat.com>, linux-arm-kernel@lists.infradead.org, Maxime Ripard <maxime.ripard@free-electrons.com> Subject: [PATCH 09/33] Input: sun4i-lradc-keys - Drop unnecessary call to platform_set_drvdata and other changes Date: Wed, 18 Jan 2017 09:46:30 -0800 [thread overview] Message-ID: <1484761614-12225-10-git-send-email-linux@roeck-us.net> (raw) In-Reply-To: <1484761614-12225-1-git-send-email-linux@roeck-us.net> There is no call to platform_get_drvdata() or dev_get_drvdata(). Drop the unnecessary call to platform_set_drvdata(). Other relevant changes: Simplify error return This conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Replace 'if (e) return e; return 0;' with 'return e;' - Drop platform_set_drvdata() Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/input/keyboard/sun4i-lradc-keys.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c index cc8f7ddcee53..c153d956778c 100644 --- a/drivers/input/keyboard/sun4i-lradc-keys.c +++ b/drivers/input/keyboard/sun4i-lradc-keys.c @@ -257,12 +257,7 @@ static int sun4i_lradc_probe(struct platform_device *pdev) if (error) return error; - error = input_register_device(lradc->input); - if (error) - return error; - - platform_set_drvdata(pdev, lradc); - return 0; + return input_register_device(lradc->input); } static const struct of_device_id sun4i_lradc_of_match[] = { -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/33] Input: sun4i-lradc-keys - Drop unnecessary call to platform_set_drvdata and other changes Date: Wed, 18 Jan 2017 09:46:30 -0800 [thread overview] Message-ID: <1484761614-12225-10-git-send-email-linux@roeck-us.net> (raw) In-Reply-To: <1484761614-12225-1-git-send-email-linux@roeck-us.net> There is no call to platform_get_drvdata() or dev_get_drvdata(). Drop the unnecessary call to platform_set_drvdata(). Other relevant changes: Simplify error return This conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Replace 'if (e) return e; return 0;' with 'return e;' - Drop platform_set_drvdata() Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/input/keyboard/sun4i-lradc-keys.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c index cc8f7ddcee53..c153d956778c 100644 --- a/drivers/input/keyboard/sun4i-lradc-keys.c +++ b/drivers/input/keyboard/sun4i-lradc-keys.c @@ -257,12 +257,7 @@ static int sun4i_lradc_probe(struct platform_device *pdev) if (error) return error; - error = input_register_device(lradc->input); - if (error) - return error; - - platform_set_drvdata(pdev, lradc); - return 0; + return input_register_device(lradc->input); } static const struct of_device_id sun4i_lradc_of_match[] = { -- 2.7.4
next prev parent reply other threads:[~2017-01-18 17:54 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-18 17:46 [PATCH 00/33] Input: Automated coccinelle cleanup Guenter Roeck 2017-01-18 17:46 ` [PATCH 01/33] Input: adp5520-keys - Drop unnecessary error messages and other changes Guenter Roeck 2017-01-18 17:46 ` [PATCH 02/33] Input: bcm-keypad - Drop unnecessary call to platform_set_drvdata " Guenter Roeck 2017-01-18 17:46 ` [PATCH 03/33] Input: cap11xx - Drop unnecessary call to i2c_set_clientdata " Guenter Roeck 2017-01-18 17:46 ` [PATCH 04/33] Input: cros_ec_keyb - Drop unnecessary call to dev_set_drvdata " Guenter Roeck 2017-01-18 18:39 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 05/33] Input: imx_keypad - Drop unnecessary error messages " Guenter Roeck 2017-01-18 17:46 ` [PATCH 06/33] Input: samsung-keypad " Guenter Roeck 2017-01-18 17:46 ` [PATCH 07/33] Input: sh_keysc " Guenter Roeck 2017-01-18 17:46 ` [PATCH 08/33] Input: spear-keyboard " Guenter Roeck 2017-01-19 3:56 ` Viresh Kumar 2017-01-18 17:46 ` Guenter Roeck [this message] 2017-01-18 17:46 ` [PATCH 09/33] Input: sun4i-lradc-keys - Drop unnecessary call to platform_set_drvdata " Guenter Roeck 2017-02-02 7:45 ` Chen-Yu Tsai 2017-02-02 7:45 ` Chen-Yu Tsai 2017-01-18 17:46 ` [PATCH 10/33] Input: twl4030_keypad " Guenter Roeck 2017-01-18 19:45 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 11/33] Input: ab8500-ponkey " Guenter Roeck 2017-01-18 19:45 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 12/33] Input: axp20x-pek - Use devm_add_action_or_reset " Guenter Roeck 2017-02-02 7:43 ` Chen-Yu Tsai 2017-01-18 17:46 ` [PATCH 13/33] Input: bfin_rotary - Use 'dev' instead of dereferencing it " Guenter Roeck 2017-01-18 19:39 ` Dmitry Torokhov 2017-01-18 20:35 ` Guenter Roeck 2017-01-19 4:58 ` Joe Perches 2017-01-19 8:25 ` Guenter Roeck 2017-01-18 17:46 ` [PATCH 14/33] Input: gpio_decoder - Drop unnecessary call to platform_set_drvdata " Guenter Roeck 2017-01-18 19:40 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 15/33] Input: kxtj9 - Drop unnecessary error messages " Guenter Roeck 2017-01-18 17:46 ` [PATCH 16/33] Input: mma8450 - Drop unnecessary call to i2c_set_clientdata " Guenter Roeck 2017-01-18 19:41 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 17/33] Input: retu-pwrbutton - Simplify error return " Guenter Roeck 2017-01-18 17:46 ` [PATCH 18/33] Input: soc_button_array - Use 'dev' instead of dereferencing it " Guenter Roeck 2017-01-18 19:42 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 19/33] Input: tps65218-pwrbutton - Drop unnecessary call to platform_set_drvdata " Guenter Roeck 2017-01-18 19:44 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 20/33] Input: elan_i2c_core - Use 'dev' instead of dereferencing it " Guenter Roeck 2017-01-18 17:46 ` [PATCH 21/33] Input: arc_ps2 - Drop unnecessary error messages " Guenter Roeck 2017-01-18 17:46 ` [PATCH 22/33] Input: at32psif " Guenter Roeck 2017-01-18 19:13 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 23/33] Input: xilinx_ps2 - Use 'dev' instead of dereferencing it " Guenter Roeck 2017-01-18 17:46 ` Guenter Roeck 2017-01-18 17:46 ` Guenter Roeck 2017-01-18 19:17 ` Dmitry Torokhov 2017-01-18 19:17 ` Dmitry Torokhov 2017-01-18 19:17 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 24/33] Input: ar1021_i2c - Drop unnecessary call to i2c_set_clientdata " Guenter Roeck 2017-01-18 19:21 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 25/33] Input: atmel-wm97xx - Drop unnecessary error messages " Guenter Roeck 2017-01-18 19:23 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 26/33] Input: atmel_mxt_ts " Guenter Roeck 2017-01-18 17:46 ` [PATCH 27/33] Input: eeti_ts " Guenter Roeck 2017-01-18 19:26 ` Dmitry Torokhov 2017-01-18 17:46 ` [PATCH 28/33] Input: egalax_ts - Drop unnecessary call to i2c_set_clientdata " Guenter Roeck 2017-01-18 19:31 ` Dmitry Torokhov 2017-01-18 20:32 ` Guenter Roeck 2017-01-18 17:46 ` [PATCH 29/33] Input: melfas_mip4 - Use devm_add_action_or_reset " Guenter Roeck 2017-01-18 19:28 ` Dmitry Torokhov 2017-01-18 20:36 ` [PATCH 30/33] Input: raydium_i2c_ts - Simplify error return " Guenter Roeck 2017-01-18 20:36 ` [PATCH 31/33] Input: rohm_bu21023 - Use 'dev' instead of dereferencing it " Guenter Roeck 2017-01-18 20:36 ` [PATCH 32/33] Input: sis_i2c - Drop unnecessary call to i2c_set_clientdata " Guenter Roeck 2017-01-18 22:27 ` Dmitry Torokhov 2017-01-18 20:36 ` [PATCH 33/33] Input: sx8654 " Guenter Roeck 2017-03-14 6:43 ` [PATCH 30/33] Input: raydium_i2c_ts - Simplify error return " Jeffrey Lin (林義章) 2017-01-19 1:42 ` [PATCH 00/33] Input: Automated coccinelle cleanup Joe Perches 2017-01-19 5:04 ` Guenter Roeck 2017-01-19 5:06 ` Joe Perches 2017-01-19 8:19 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1484761614-12225-10-git-send-email-linux@roeck-us.net \ --to=linux@roeck-us.net \ --cc=dmitry.torokhov@gmail.com \ --cc=hdegoede@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.