All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	dm-devel@redhat.com
Subject: [PATCH 04/16] dm: remove incomple BLOCK_PC support
Date: Mon, 23 Jan 2017 16:29:09 +0100	[thread overview]
Message-ID: <1485185361-29786-5-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1485185361-29786-1-git-send-email-hch@lst.de>

DM tries to copy a few fields around for BLOCK_PC requests, but given
that no dm-target ever wires up scsi_cmd_ioctl BLOCK_PC can't actually
be sent to dm.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-rq.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index 93f6e9f..3f12916 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -270,19 +270,6 @@ static void dm_end_request(struct request *clone, int error)
 	struct mapped_device *md = tio->md;
 	struct request *rq = tio->orig;
 
-	if (rq->cmd_type == REQ_TYPE_BLOCK_PC) {
-		rq->errors = clone->errors;
-		rq->resid_len = clone->resid_len;
-
-		if (rq->sense)
-			/*
-			 * We are using the sense buffer of the original
-			 * request.
-			 * So setting the length of the sense data is enough.
-			 */
-			rq->sense_len = clone->sense_len;
-	}
-
 	free_rq_clone(clone);
 	rq_end_stats(md, rq);
 	if (!rq->q->mq_ops)
@@ -511,9 +498,6 @@ static int setup_clone(struct request *clone, struct request *rq,
 	if (r)
 		return r;
 
-	clone->cmd = rq->cmd;
-	clone->cmd_len = rq->cmd_len;
-	clone->sense = rq->sense;
 	clone->end_io = end_clone_request;
 	clone->end_io_data = tio;
 
-- 
2.1.4


  parent reply	other threads:[~2017-01-23 15:29 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 15:29 split scsi passthrough fields out of struct request Christoph Hellwig
2017-01-23 15:29 ` [PATCH 01/16] block: fix elevator init check Christoph Hellwig
2017-01-24  7:02   ` Hannes Reinecke
2017-01-24  7:02     ` Hannes Reinecke
2017-01-24 15:06   ` Jens Axboe
2017-01-24 15:06     ` Jens Axboe
2017-01-24 15:10     ` Christoph Hellwig
2017-01-23 15:29 ` [PATCH 02/16] block: simplify blk_init_allocated_queue Christoph Hellwig
2017-01-24  7:37   ` Hannes Reinecke
2017-01-24  7:37     ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 03/16] block: allow specifying size for extra command data Christoph Hellwig
2017-01-24  8:10   ` Hannes Reinecke
2017-01-24  8:10     ` Hannes Reinecke
2017-01-23 15:29 ` Christoph Hellwig [this message]
2017-01-24  8:22   ` [PATCH 04/16] dm: remove incomple BLOCK_PC support Hannes Reinecke
2017-01-24  8:22     ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 05/16] dm: always defer request allocation to the owner of the request_queue Christoph Hellwig
2017-01-24  8:29   ` Hannes Reinecke
2017-01-24  8:29     ` Hannes Reinecke
2017-01-24 10:05   ` Mike Snitzer
2017-01-24 14:20     ` Christoph Hellwig
2017-01-24 16:39       ` Mike Snitzer
2017-01-24 19:52         ` Christoph Hellwig
2017-01-26  4:23         ` Junichi Nomura
2017-01-26  4:23           ` Junichi Nomura
2017-01-23 15:29 ` [PATCH 06/16] scsi_dh_rdac: switch to scsi_execute_req_flags() Christoph Hellwig
2017-01-23 15:29 ` [PATCH 07/16] scsi_dh_emc: " Christoph Hellwig
2017-01-23 15:29 ` [PATCH 08/16] scsi_dh_hp_sw: " Christoph Hellwig
2017-01-23 15:29 ` [PATCH 09/16] scsi: remove gfp_flags member in scsi_host_cmd_pool Christoph Hellwig
2017-01-24  8:31   ` Hannes Reinecke
2017-01-24 12:08   ` Johannes Thumshirn
2017-01-24 12:08     ` Johannes Thumshirn
2017-01-23 15:29 ` [PATCH 10/16] scsi: respect unchecked_isa_dma for blk-mq Christoph Hellwig
2017-01-24 11:06   ` Hannes Reinecke
2017-01-24 11:06     ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 11/16] scsi: remove scsi_cmd_dma_pool Christoph Hellwig
2017-01-24 11:07   ` Hannes Reinecke
2017-01-24 11:07     ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 12/16] scsi: remove __scsi_alloc_queue Christoph Hellwig
2017-01-24 11:08   ` Hannes Reinecke
2017-01-24 11:08     ` Hannes Reinecke
2017-01-24 11:24   ` Johannes Thumshirn
2017-01-24 11:24     ` Johannes Thumshirn
2017-01-23 15:29 ` [PATCH 13/16] scsi: allocate scsi_cmnd structures as part of struct request Christoph Hellwig
2017-01-24 12:57   ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 14/16] block/bsg: move queue creation into bsg_setup_queue Christoph Hellwig
2017-01-23 15:29 ` [PATCH 15/16] block: split scsi_request out of struct request Christoph Hellwig
2017-01-24  0:33   ` Bart Van Assche
2017-01-24  0:33     ` Bart Van Assche
2017-01-24  8:09     ` hch
2017-01-24 16:31       ` Bart Van Assche
2017-01-24 16:31         ` Bart Van Assche
2017-01-24 13:21   ` Hannes Reinecke
2017-01-24 13:21     ` Hannes Reinecke
2017-01-26 19:12   ` Bart Van Assche
2017-01-26 19:12     ` Bart Van Assche
2017-01-26 19:37     ` Christoph Hellwig
2017-01-26 19:37       ` Christoph Hellwig
2017-01-26 19:42       ` Jens Axboe
2017-01-26 19:42         ` Jens Axboe
2017-01-23 15:29 ` [PATCH 16/16] block: don't assign cmd_flags in __blk_rq_prep_clone Christoph Hellwig
2017-01-24 13:22   ` Hannes Reinecke
2017-01-24 13:22     ` Hannes Reinecke
2017-01-23 15:39 ` split scsi passthrough fields out of struct request Jens Axboe
2017-01-23 15:46   ` Christoph Hellwig
2017-01-24  0:30 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485185361-29786-5-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.