From: Himanshu Madhani <himanshu.madhani@cavium.com>
To: target-devel@vger.kernel.org, Bart.VanAssche@sandisk.com,
hch@infradead.org, nab@linux-iscsi.org
Cc: giridhar.malavali@cavium.com, linux-scsi@vger.kernel.org,
himanshu.madhani@cavium.com
Subject: [PATCH 10/15] qla2xxx: Fix request queue corruption.
Date: Thu, 2 Feb 2017 11:42:33 -0800 [thread overview]
Message-ID: <1486064558-365-11-git-send-email-himanshu.madhani@cavium.com> (raw)
In-Reply-To: <1486064558-365-1-git-send-email-himanshu.madhani@cavium.com>
From: Quinn Tran <quinn.tran@cavium.com>
When FW notify driver or driver detects low FW resource,
driver tries to send out Busy SCSI Status to tell Initiator
side to back off. During the send process, the lock was not held.
Signed-off-by: Quinn Tran <quinn.tran@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
---
drivers/scsi/qla2xxx/qla_target.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index ab9f4e7..1bd4eff 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5187,16 +5187,22 @@ static int __qlt_send_busy(struct scsi_qla_host *vha,
static int
qlt_chk_qfull_thresh_hold(struct scsi_qla_host *vha,
- struct atio_from_isp *atio)
+ struct atio_from_isp *atio, uint8_t ha_locked)
{
struct qla_hw_data *ha = vha->hw;
uint16_t status;
+ unsigned long flags;
if (ha->tgt.num_pend_cmds < Q_FULL_THRESH_HOLD(ha))
return 0;
+ if (!ha_locked)
+ spin_lock_irqsave(&ha->hardware_lock, flags);
status = temp_sam_status;
qlt_send_busy(vha, atio, status);
+ if (!ha_locked)
+ spin_unlock_irqrestore(&ha->hardware_lock, flags);
+
return 1;
}
@@ -5241,7 +5247,7 @@ static void qlt_24xx_atio_pkt(struct scsi_qla_host *vha,
if (likely(atio->u.isp24.fcp_cmnd.task_mgmt_flags == 0)) {
- rc = qlt_chk_qfull_thresh_hold(vha, atio);
+ rc = qlt_chk_qfull_thresh_hold(vha, atio, ha_locked);
if (rc != 0) {
tgt->atio_irq_cmd_count--;
return;
@@ -5364,7 +5370,7 @@ static void qlt_response_pkt(struct scsi_qla_host *vha, response_t *pkt)
break;
}
- rc = qlt_chk_qfull_thresh_hold(vha, atio);
+ rc = qlt_chk_qfull_thresh_hold(vha, atio, 1);
if (rc != 0) {
tgt->irq_cmd_count--;
return;
--
1.8.3.1
next prev parent reply other threads:[~2017-02-02 19:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 19:42 [PATCH 00/15] qla2xxx: Bug Fixes and updates for target Himanshu Madhani
2017-02-02 19:42 ` [PATCH 01/15] qla2xxx: Fix delayed response to command for loop mode/direct connect Himanshu Madhani
2017-02-02 19:42 ` [PATCH 02/15] qla2xxx: Allow relogin to proceed if remote login did not finish Himanshu Madhani
2017-02-02 19:42 ` [PATCH 03/15] qla2xxx: Allow vref count to timeout on vport delete Himanshu Madhani
2017-02-02 19:42 ` [PATCH 04/15] qla2xxx: Use IOCB interface to submit non-critical MBX Himanshu Madhani
2017-02-02 19:42 ` [PATCH 05/15] qla2xxx: Add DebugFS node to display Port Database Himanshu Madhani
2017-02-02 19:42 ` [PATCH 06/15] qla2xxx: Improve T10-DIF/PI handling in driver Himanshu Madhani
2017-02-02 19:42 ` [PATCH 07/15] qla2xxx: Export DIF stats via debugfs Himanshu Madhani
2017-02-02 19:42 ` [PATCH 08/15] qla2xxx: Change scsi host lookup method Himanshu Madhani
2017-02-02 19:42 ` [PATCH 09/15] qla2xxx: Fix memory leak for abts processing Himanshu Madhani
2017-02-02 19:42 ` Himanshu Madhani [this message]
2017-02-02 19:42 ` [PATCH 11/15] qla2xxx: Fix inadequate lock protection for ABTS Himanshu Madhani
2017-02-02 19:42 ` [PATCH 12/15] qla2xxx: Fix warnings about inconsistent indenting Himanshu Madhani
2017-02-02 19:42 ` [PATCH 13/15] qla2xxx: Add async new target notification Himanshu Madhani
2017-02-02 19:42 ` [PATCH 14/15] qla2xxx: Fix sess_lock & hardware_lock lock order problem Himanshu Madhani
2017-02-02 19:42 ` [PATCH 15/15] qla2xxx: Update driver version to 9.00.00.00-k Himanshu Madhani
2017-02-03 16:26 ` [PATCH 00/15] qla2xxx: Bug Fixes and updates for target Bart Van Assche
2017-02-03 17:25 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486064558-365-11-git-send-email-himanshu.madhani@cavium.com \
--to=himanshu.madhani@cavium.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=giridhar.malavali@cavium.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.