All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Willy Tarreau <w@1wt.eu>
Subject: ARM: dts: rockchip: add the MiQi board's fan definition
Date: Sat, 11 Feb 2017 09:56:55 +0100	[thread overview]
Message-ID: <1486803415-14680-1-git-send-email-w@1wt.eu> (raw)

The MiQi board is sold with an enclosure in which a fan is connected
to the second LED output, and configured by default in "heartbeat"
mode so that it rotates slowly and increases when the CPU load
increases, ensuring appropriate cooling by default. This LED output
is called "Fan" in the original kernel and connected to GPIO18
(gpiochip 0, pin 18). Here we called it "miqi:green:fan" to stay
consistent with the kernel's naming conventions.

It's worth noting that without this patch the fan doesn't work at
all, risking to make the board overheat.

Fixes: 162718c (v4.7)
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
---
 arch/arm/boot/dts/rk3288-miqi.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-miqi.dts b/arch/arm/boot/dts/rk3288-miqi.dts
index 2f4c635..ef702db 100644
--- a/arch/arm/boot/dts/rk3288-miqi.dts
+++ b/arch/arm/boot/dts/rk3288-miqi.dts
@@ -67,6 +67,12 @@
 	leds {
 		compatible = "gpio-leds";
 
+		fan {
+			gpios = <&gpio0 18 GPIO_ACTIVE_HIGH>;
+			label = "miqi:green:fan";
+			linux,default-trigger = "heartbeat";
+		};
+
 		work {
 			gpios = <&gpio7 2 GPIO_ACTIVE_HIGH>;
 			label = "miqi:green:user";
-- 
2.8.0.rc2.1.gbe9624a

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: w@1wt.eu (Willy Tarreau)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: dts: rockchip: add the MiQi board's fan definition
Date: Sat, 11 Feb 2017 09:56:55 +0100	[thread overview]
Message-ID: <1486803415-14680-1-git-send-email-w@1wt.eu> (raw)

The MiQi board is sold with an enclosure in which a fan is connected
to the second LED output, and configured by default in "heartbeat"
mode so that it rotates slowly and increases when the CPU load
increases, ensuring appropriate cooling by default. This LED output
is called "Fan" in the original kernel and connected to GPIO18
(gpiochip 0, pin 18). Here we called it "miqi:green:fan" to stay
consistent with the kernel's naming conventions.

It's worth noting that without this patch the fan doesn't work at
all, risking to make the board overheat.

Fixes: 162718c (v4.7)
Cc: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
---
 arch/arm/boot/dts/rk3288-miqi.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-miqi.dts b/arch/arm/boot/dts/rk3288-miqi.dts
index 2f4c635..ef702db 100644
--- a/arch/arm/boot/dts/rk3288-miqi.dts
+++ b/arch/arm/boot/dts/rk3288-miqi.dts
@@ -67,6 +67,12 @@
 	leds {
 		compatible = "gpio-leds";
 
+		fan {
+			gpios = <&gpio0 18 GPIO_ACTIVE_HIGH>;
+			label = "miqi:green:fan";
+			linux,default-trigger = "heartbeat";
+		};
+
 		work {
 			gpios = <&gpio7 2 GPIO_ACTIVE_HIGH>;
 			label = "miqi:green:user";
-- 
2.8.0.rc2.1.gbe9624a

             reply	other threads:[~2017-02-11  8:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11  8:56 Willy Tarreau [this message]
2017-02-11  8:56 ` ARM: dts: rockchip: add the MiQi board's fan definition Willy Tarreau
     [not found] ` <1486803415-14680-1-git-send-email-w-K+wRfnb2/UA@public.gmane.org>
2017-02-11 16:33   ` Heiko Stuebner
2017-02-11 16:33     ` Heiko Stuebner
2017-02-11 17:45     ` Willy Tarreau
2017-02-11 17:45       ` Willy Tarreau
     [not found]       ` <20170211174554.GA14513-K+wRfnb2/UA@public.gmane.org>
2017-02-12  1:41         ` Heiko Stuebner
2017-02-12  1:41           ` Heiko Stuebner
2017-02-12  7:17           ` Willy Tarreau
2017-02-12  7:17             ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486803415-14680-1-git-send-email-w@1wt.eu \
    --to=w@1wt.eu \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.