All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: akpm@linux-foundation.org
Cc: jack@suse.com, dave.hansen@linux.intel.com,
	alexander.kapshuk@gmail.com, linux-nvdimm@lists.01.org,
	mawilcox@microsoft.com, linux-xfs@vger.kernel.org,
	linux-mm@kvack.org, vbabka@suse.cz, keescook@google.com,
	linux-ext4@vger.kernel.org, kirill.shutemov@linux.intel.com
Subject: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear()
Date: Wed, 15 Feb 2017 13:31:08 -0700	[thread overview]
Message-ID: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> (raw)

The fix introduced by e4decc90 to fix the UP case for 32bit x86, however
that broke the SMP case that was working previously. Add ifdef so the dummy
function only show up for 32bit UP case only.

Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build

Reported-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 arch/x86/include/asm/pgtable-3level.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/pgtable-3level.h b/arch/x86/include/asm/pgtable-3level.h
index 50d35e3..8f50fb3 100644
--- a/arch/x86/include/asm/pgtable-3level.h
+++ b/arch/x86/include/asm/pgtable-3level.h
@@ -121,9 +121,11 @@ static inline void native_pmd_clear(pmd_t *pmd)
 	*(tmp + 1) = 0;
 }
 
+#ifndef CONFIG_SMP
 static inline void native_pud_clear(pud_t *pudp)
 {
 }
+#endif
 
 static inline void pud_clear(pud_t *pudp)
 {

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Dave Jiang <dave.jiang@intel.com>
To: akpm@linux-foundation.org
Cc: keescook@google.com, mawilcox@microsoft.com,
	linux-nvdimm@lists.01.org, dave.hansen@linux.intel.com,
	linux-xfs@vger.kernel.org, linux-mm@kvack.org,
	kirill.shutemov@linux.intel.com, jack@suse.com,
	dan.j.williams@intel.com, linux-ext4@vger.kernel.org,
	ross.zwisler@linux.intel.com, vbabka@suse.cz,
	alexander.kapshuk@gmail.com
Subject: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear()
Date: Wed, 15 Feb 2017 13:31:08 -0700	[thread overview]
Message-ID: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> (raw)

The fix introduced by e4decc90 to fix the UP case for 32bit x86, however
that broke the SMP case that was working previously. Add ifdef so the dummy
function only show up for 32bit UP case only.

Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build

Reported-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 arch/x86/include/asm/pgtable-3level.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/pgtable-3level.h b/arch/x86/include/asm/pgtable-3level.h
index 50d35e3..8f50fb3 100644
--- a/arch/x86/include/asm/pgtable-3level.h
+++ b/arch/x86/include/asm/pgtable-3level.h
@@ -121,9 +121,11 @@ static inline void native_pmd_clear(pmd_t *pmd)
 	*(tmp + 1) = 0;
 }
 
+#ifndef CONFIG_SMP
 static inline void native_pud_clear(pud_t *pudp)
 {
 }
+#endif
 
 static inline void pud_clear(pud_t *pudp)
 {

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Jiang <dave.jiang@intel.com>
To: akpm@linux-foundation.org
Cc: keescook@google.com, mawilcox@microsoft.com,
	linux-nvdimm@lists.01.org, dave.hansen@linux.intel.com,
	linux-xfs@vger.kernel.org, linux-mm@kvack.org,
	kirill.shutemov@linux.intel.com, jack@suse.com,
	dan.j.williams@intel.com, linux-ext4@vger.kernel.org,
	ross.zwisler@linux.intel.com, vbabka@suse.cz,
	alexander.kapshuk@gmail.com
Subject: [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear()
Date: Wed, 15 Feb 2017 13:31:08 -0700	[thread overview]
Message-ID: <148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com> (raw)

The fix introduced by e4decc90 to fix the UP case for 32bit x86, however
that broke the SMP case that was working previously. Add ifdef so the dummy
function only show up for 32bit UP case only.

Fix: e4decc90 mm,x86: native_pud_clear missing on i386 build

Reported-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 arch/x86/include/asm/pgtable-3level.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/pgtable-3level.h b/arch/x86/include/asm/pgtable-3level.h
index 50d35e3..8f50fb3 100644
--- a/arch/x86/include/asm/pgtable-3level.h
+++ b/arch/x86/include/asm/pgtable-3level.h
@@ -121,9 +121,11 @@ static inline void native_pmd_clear(pmd_t *pmd)
 	*(tmp + 1) = 0;
 }
 
+#ifndef CONFIG_SMP
 static inline void native_pud_clear(pud_t *pudp)
 {
 }
+#endif
 
 static inline void pud_clear(pud_t *pudp)
 {


             reply	other threads:[~2017-02-15 20:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 20:31 Dave Jiang [this message]
2017-02-15 20:31 ` [PATCH] mm,x86: fix SMP x86 32bit build for native_pud_clear() Dave Jiang
2017-02-15 20:31 ` Dave Jiang
2017-02-16 15:42 ` Dave Hansen
2017-02-16 15:42   ` Dave Hansen
2017-02-16 15:42   ` Dave Hansen
2017-02-16 15:42   ` Dave Hansen
2017-02-16 16:27   ` Dave Jiang
2017-02-16 16:27     ` Dave Jiang
2017-02-16 16:27     ` Dave Jiang
2017-02-16 16:27     ` Dave Jiang
2017-02-27 18:31 ` Laura Abbott
2017-02-27 18:31   ` Laura Abbott
2017-02-27 19:29   ` Boris Ostrovsky
2017-02-27 19:29     ` Boris Ostrovsky
2017-02-27 19:35     ` Dave Jiang
2017-02-27 19:35       ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148719066814.31111.3239231168815337012.stgit@djiang5-desk3.ch.intel.com \
    --to=dave.jiang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.kapshuk@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=jack@suse.com \
    --cc=keescook@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mawilcox@microsoft.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.