All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: [PATCH 01/10] x86/cpuid: Disallow policy updates once the domain is running
Date: Mon, 20 Feb 2017 11:00:25 +0000	[thread overview]
Message-ID: <1487588434-4359-2-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1487588434-4359-1-git-send-email-andrew.cooper3@citrix.com>

On real hardware, the bulk of CPUID data is system-specific and constant.
Hold the toolstack to the same behaviour when constructing domains.

Values which are expected to change dynamically (e.g. OSXSAVE) are unaffected
and continue to function as before.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
 xen/arch/x86/domctl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 3b5c3c9..fc42cb1 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -941,6 +941,8 @@ long arch_do_domctl(
     case XEN_DOMCTL_set_cpuid:
         if ( d == currd ) /* no domain_pause() */
             ret = -EINVAL;
+        else if ( d->creation_finished )
+            ret = -EEXIST; /* No changing once the domain is running. */
         else
         {
             domain_pause(d);
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-20 11:00 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 11:00 [PATCH 00/10] x86/cpuid: Remove the legacy infrastructure Andrew Cooper
2017-02-20 11:00 ` Andrew Cooper [this message]
2017-02-21 16:37   ` [PATCH 01/10] x86/cpuid: Disallow policy updates once the domain is running Jan Beulich
2017-02-20 11:00 ` [PATCH 02/10] x86/gen-cpuid: Clarify the intended meaning of AVX wrt feature dependencies Andrew Cooper
2017-02-21 16:40   ` Jan Beulich
2017-02-21 16:41     ` Andrew Cooper
2017-02-21 16:47     ` Jan Beulich
2017-02-21 16:53       ` Andrew Cooper
2017-02-21 17:07         ` Jan Beulich
2017-02-21 17:12           ` Andrew Cooper
2017-02-21 17:17             ` Jan Beulich
2017-02-21 17:42               ` Andrew Cooper
2017-02-22  7:13                 ` Jan Beulich
2017-02-20 11:00 ` [PATCH 03/10] x86/cpuid: Handle leaf 0x1 in guest_cpuid() Andrew Cooper
2017-02-21 16:59   ` Jan Beulich
2017-02-21 17:13     ` Andrew Cooper
2017-02-21 17:20       ` Jan Beulich
2017-02-21 17:29         ` Andrew Cooper
2017-02-22  7:16           ` Jan Beulich
2017-02-20 11:00 ` [PATCH 04/10] x86/cpuid: Handle leaf 0x4 " Andrew Cooper
2017-02-21 17:16   ` Jan Beulich
2017-02-21 17:35     ` Andrew Cooper
2017-02-22  7:23       ` Jan Beulich
2017-02-22  7:55         ` Andrew Cooper
2017-03-10 16:27   ` [PATCH v2 " Andrew Cooper
2017-03-13 12:03     ` Jan Beulich
2017-03-13 12:51       ` Andrew Cooper
2017-03-13 13:05         ` Jan Beulich
2017-03-13 13:24           ` Andrew Cooper
2017-03-13 13:36             ` Jan Beulich
2017-02-20 11:00 ` [PATCH 05/10] x86/cpuid: Handle leaf 0x5 " Andrew Cooper
2017-02-21 17:22   ` Jan Beulich
2017-02-20 11:00 ` [PATCH 06/10] x86/cpuid: Handle leaf 0x6 " Andrew Cooper
2017-02-21 17:25   ` Jan Beulich
2017-02-21 17:40     ` Andrew Cooper
2017-02-21 17:44       ` Andrew Cooper
2017-02-22  7:31       ` Jan Beulich
2017-02-22  8:23         ` Andrew Cooper
2017-02-22  9:12           ` Andrew Cooper
2017-02-22  9:26             ` Jan Beulich
2017-02-27 14:30               ` Andrew Cooper
2017-03-10 16:32   ` [PATCH v2 " Andrew Cooper
2017-03-13 12:04     ` Jan Beulich
2017-02-20 11:00 ` [PATCH 07/10] x86/cpuid: Handle leaf 0xa " Andrew Cooper
2017-02-22  9:11   ` Jan Beulich
2017-02-20 11:00 ` [PATCH 08/10] x86/cpuid: Handle leaf 0xb " Andrew Cooper
2017-02-22  9:16   ` Jan Beulich
2017-02-22 10:22     ` Andrew Cooper
2017-02-22 10:37       ` Jan Beulich
2017-02-27 15:05         ` Andrew Cooper
2017-03-10 16:44   ` [PATCH v2 " Andrew Cooper
2017-03-13 12:13     ` Jan Beulich
2017-02-20 11:00 ` [PATCH 09/10] x86/cpuid: Drop legacy CPUID infrastructure Andrew Cooper
2017-02-22  9:19   ` Jan Beulich
2017-02-20 11:00 ` [PATCH 10/10] x86/cpuid: Always enable faulting for the control domain Andrew Cooper
2017-02-22  9:23   ` Jan Beulich
2017-02-22 10:00     ` Andrew Cooper
2017-02-22 10:10       ` Jan Beulich
2017-02-27 15:10         ` Andrew Cooper
2017-02-28  9:31           ` Jan Beulich
2017-03-10 17:10             ` Andrew Cooper
2017-03-13 11:48               ` Jan Beulich
2017-03-14 15:06                 ` Wei Liu
2017-03-14 15:13                   ` Jan Beulich
2017-03-14 16:05                     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487588434-4359-2-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.