From: Sergio Prado <sergio.prado@e-labworks.com> To: kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sergio Prado <sergio.prado@e-labworks.com> Subject: [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx Date: Thu, 2 Mar 2017 18:23:19 -0300 [thread overview] Message-ID: <1488489799-18136-1-git-send-email-sergio.prado@e-labworks.com> (raw) We are getting a NULL pointer dereference when working with external interrupts on s3c24xx: Unable to handle kernel NULL pointer dereference at virtual address 000000a8 pgd = c0104000 [000000a8] *pgd=00000000 Internal error: Oops: 5 [#1] ARM Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 4.10.0-rc8mini2440-sub-00047-g0722f57bfae9-dirty #3 Hardware name: Samsung S3C2416 (Flattened Device Tree) task: c07399f8 task.stack: c0734000 PC is at s3c24xx_demux_eint4_7+0x24/0x10c LR is at s3c24xx_demux_eint4_7+0x108/0x10c The problem is in the function s3c24xx_demux_eint() when dereferencing bank->eint_base. At this point, we cannot get the bank pointer from the irq_desc structure since it is pointing to the hardware irq, not virq. So let's get the bank pointer directly from data->drvdata. This is a regression from commit 8b1bd11c1f8f529057369c5b3702d13fd24e2765. Tested on FriendlyARM mini2440. Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> --- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c index b82a003546ae..1b8d887796e8 100644 --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c @@ -356,8 +356,8 @@ static inline void s3c24xx_demux_eint(struct irq_desc *desc, { struct s3c24xx_eint_data *data = irq_desc_get_handler_data(desc); struct irq_chip *chip = irq_desc_get_chip(desc); - struct irq_data *irqd = irq_desc_get_irq_data(desc); - struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd); + struct samsung_pinctrl_drv_data *d = data->drvdata; + struct samsung_pin_bank *bank = d->pin_banks; unsigned int pend, mask; chained_irq_enter(chip, desc); -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: sergio.prado@e-labworks.com (Sergio Prado) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx Date: Thu, 2 Mar 2017 18:23:19 -0300 [thread overview] Message-ID: <1488489799-18136-1-git-send-email-sergio.prado@e-labworks.com> (raw) We are getting a NULL pointer dereference when working with external interrupts on s3c24xx: Unable to handle kernel NULL pointer dereference at virtual address 000000a8 pgd = c0104000 [000000a8] *pgd=00000000 Internal error: Oops: 5 [#1] ARM Modules linked in: CPU: 0 PID: 0 Comm: swapper Not tainted 4.10.0-rc8mini2440-sub-00047-g0722f57bfae9-dirty #3 Hardware name: Samsung S3C2416 (Flattened Device Tree) task: c07399f8 task.stack: c0734000 PC is at s3c24xx_demux_eint4_7+0x24/0x10c LR is at s3c24xx_demux_eint4_7+0x108/0x10c The problem is in the function s3c24xx_demux_eint() when dereferencing bank->eint_base. At this point, we cannot get the bank pointer from the irq_desc structure since it is pointing to the hardware irq, not virq. So let's get the bank pointer directly from data->drvdata. This is a regression from commit 8b1bd11c1f8f529057369c5b3702d13fd24e2765. Tested on FriendlyARM mini2440. Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> --- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c index b82a003546ae..1b8d887796e8 100644 --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c @@ -356,8 +356,8 @@ static inline void s3c24xx_demux_eint(struct irq_desc *desc, { struct s3c24xx_eint_data *data = irq_desc_get_handler_data(desc); struct irq_chip *chip = irq_desc_get_chip(desc); - struct irq_data *irqd = irq_desc_get_irq_data(desc); - struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd); + struct samsung_pinctrl_drv_data *d = data->drvdata; + struct samsung_pin_bank *bank = d->pin_banks; unsigned int pend, mask; chained_irq_enter(chip, desc); -- 1.9.1
next reply other threads:[~2017-03-02 21:23 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-02 21:23 Sergio Prado [this message] 2017-03-02 21:23 ` [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx Sergio Prado 2017-03-04 8:15 ` Krzysztof Kozlowski 2017-03-04 8:15 ` Krzysztof Kozlowski 2017-03-04 11:45 ` Tomasz Figa 2017-03-04 11:45 ` Tomasz Figa 2017-03-04 11:45 ` Tomasz Figa 2017-03-06 13:15 ` Sergio Prado 2017-03-06 13:15 ` Sergio Prado 2017-03-06 13:15 ` Sergio Prado 2017-03-08 16:34 ` Krzysztof Kozlowski 2017-03-08 16:34 ` Krzysztof Kozlowski 2017-03-09 5:56 ` Tomasz Figa 2017-03-09 5:56 ` Tomasz Figa 2017-03-09 5:56 ` Tomasz Figa 2017-03-09 6:42 ` Krzysztof Kozlowski 2017-03-09 6:42 ` Krzysztof Kozlowski 2017-03-09 6:42 ` Krzysztof Kozlowski 2017-03-21 1:31 ` Tomasz Figa 2017-03-21 1:31 ` Tomasz Figa 2017-03-21 1:31 ` Tomasz Figa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1488489799-18136-1-git-send-email-sergio.prado@e-labworks.com \ --to=sergio.prado@e-labworks.com \ --cc=javier@osg.samsung.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.