From: Dave Jiang <dave.jiang@intel.com>
To: akpm@linux-foundation.org
Cc: mawilcox@microsoft.com, linux-nvdimm@lists.01.org,
dave.hansen@linux.intel.com, linux-mm@kvack.org, jack@suse.com,
kirill.shutemov@linux.intel.com
Subject: [PATCH] x86, mm: fix NOHIGHMEM && X86_PAE build config for native_pud_clear()
Date: Mon, 06 Mar 2017 15:18:18 -0700 [thread overview]
Message-ID: <148883869853.70777.12180810304957921737.stgit@djiang5-desk3.ch.intel.com> (raw)
Looks like a 32bit x86 build failure case where X86_PAE and NOHIMEM
are on. This was reported by kbuild test bot.
In file included from include/linux/mm.h:68:0,
from include/linux/highmem.h:7,
from include/linux/bio.h:21,
from include/linux/writeback.h:205,
from include/linux/memcontrol.h:30,
from include/linux/swap.h:8,
from include/linux/suspend.h:4,
from arch/x86/kernel/asm-offsets.c:12:
arch/x86/include/asm/pgtable.h: In function 'native_local_pudp_get_and_clear':
>> arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' [-Werror=implicit-function-declaration]
native_pud_clear(pudp);
^~~~~~~~~~~~~~~~
Fixes: a00cc7d9dd93d ("mm, x86: add support for PUD-sized transparent
hugepages")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
arch/x86/include/asm/pgtable-3level.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/pgtable-3level.h b/arch/x86/include/asm/pgtable-3level.h
index 72277b1..d337738 100644
--- a/arch/x86/include/asm/pgtable-3level.h
+++ b/arch/x86/include/asm/pgtable-3level.h
@@ -121,8 +121,9 @@ static inline void native_pmd_clear(pmd_t *pmd)
*(tmp + 1) = 0;
}
-#if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \
- defined(CONFIG_PARAVIRT))
+#if !defined(CONFIG_SMP) || \
+ (defined(CONFIG_HIGHMEM64G) && defined(CONFIG_PARAVIRT)) || \
+ (defined(CONFIG_NOHIGHMEM) && defined(CONFIG_X86_PAE))
static inline void native_pud_clear(pud_t *pudp)
{
}
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jiang <dave.jiang@intel.com>
To: akpm@linux-foundation.org
Cc: dave.hansen@linux.intel.com, mawilcox@microsoft.com,
linux-nvdimm@lists.01.org, linux-mm@kvack.org, jack@suse.com,
dan.j.williams@intel.com, ross.zwisler@linux.intel.com,
kirill.shutemov@linux.intel.com
Subject: [PATCH] x86, mm: fix NOHIGHMEM && X86_PAE build config for native_pud_clear()
Date: Mon, 06 Mar 2017 15:18:18 -0700 [thread overview]
Message-ID: <148883869853.70777.12180810304957921737.stgit@djiang5-desk3.ch.intel.com> (raw)
Looks like a 32bit x86 build failure case where X86_PAE and NOHIMEM
are on. This was reported by kbuild test bot.
In file included from include/linux/mm.h:68:0,
from include/linux/highmem.h:7,
from include/linux/bio.h:21,
from include/linux/writeback.h:205,
from include/linux/memcontrol.h:30,
from include/linux/swap.h:8,
from include/linux/suspend.h:4,
from arch/x86/kernel/asm-offsets.c:12:
arch/x86/include/asm/pgtable.h: In function 'native_local_pudp_get_and_clear':
>> arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' [-Werror=implicit-function-declaration]
native_pud_clear(pudp);
^~~~~~~~~~~~~~~~
Fixes: a00cc7d9dd93d ("mm, x86: add support for PUD-sized transparent
hugepages")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
arch/x86/include/asm/pgtable-3level.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/pgtable-3level.h b/arch/x86/include/asm/pgtable-3level.h
index 72277b1..d337738 100644
--- a/arch/x86/include/asm/pgtable-3level.h
+++ b/arch/x86/include/asm/pgtable-3level.h
@@ -121,8 +121,9 @@ static inline void native_pmd_clear(pmd_t *pmd)
*(tmp + 1) = 0;
}
-#if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \
- defined(CONFIG_PARAVIRT))
+#if !defined(CONFIG_SMP) || \
+ (defined(CONFIG_HIGHMEM64G) && defined(CONFIG_PARAVIRT)) || \
+ (defined(CONFIG_NOHIGHMEM) && defined(CONFIG_X86_PAE))
static inline void native_pud_clear(pud_t *pudp)
{
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-03-06 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 22:18 Dave Jiang [this message]
2017-03-06 22:18 ` [PATCH] x86, mm: fix NOHIGHMEM && X86_PAE build config for native_pud_clear() Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148883869853.70777.12180810304957921737.stgit@djiang5-desk3.ch.intel.com \
--to=dave.jiang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=jack@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mawilcox@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.