From: lixiubo@cmss.chinamobile.com
To: agrover@redhat.com, nab@linux-iscsi.org, mchristi@redhat.com
Cc: shli@kernel.org, sheng@yasker.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, namei.unix@gmail.com,
bryantly@linux.vnet.ibm.com,
Xiubo Li <lixiubo@cmss.chinamobile.com>
Subject: [PATCHv3 4/5] target/user: Fix wrongly calculating of the base_command_size
Date: Mon, 20 Mar 2017 17:09:23 +0800 [thread overview]
Message-ID: <1490000964-15732-5-git-send-email-lixiubo@cmss.chinamobile.com> (raw)
In-Reply-To: <1490000964-15732-1-git-send-email-lixiubo@cmss.chinamobile.com>
From: Xiubo Li <lixiubo@cmss.chinamobile.com>
The t_data_nents and t_bidi_data_nents are all the numbers of the
segments, and we couldn't be sure the size of the data area block
will equal to size of the segment.
Use the actually block number needed intead of the sum of segments.
Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
---
drivers/target/target_core_user.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 780c30f..e3daf15 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -598,8 +598,7 @@ static bool is_ring_space_avail(struct tcmu_dev *udev, struct tcmu_cmd *cmd,
* expensive to tell how many regions are freed in the bitmap
*/
base_command_size = max(offsetof(struct tcmu_cmd_entry,
- req.iov[se_cmd->t_bidi_data_nents +
- se_cmd->t_data_nents]),
+ req.iov[tcmu_cmd->dbi_len]),
sizeof(struct tcmu_cmd_entry));
command_size = base_command_size
+ round_up(scsi_command_size(se_cmd->t_task_cdb), TCMU_OP_ALIGN_SIZE);
--
1.8.3.1
next prev parent reply other threads:[~2017-03-20 9:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:09 [PATCHv3 0/5] Dynamic growing data area support lixiubo
2017-03-20 9:09 ` [PATCHv3 1/5] tcmu: Add dynamic growing data area feature support lixiubo
2017-03-20 9:09 ` [PATCHv3 2/5] tcmu: Add global data block pool support lixiubo
2017-03-20 9:09 ` [PATCHv3 3/5] target/user: Fix possible overwrite of t_data_sg's last iov[] lixiubo
2017-03-21 19:10 ` Mike Christie
2017-03-20 9:09 ` lixiubo [this message]
2017-03-20 9:09 ` [PATCHv3 5/5] target/user: Clean up tcmu_queue_cmd_ring lixiubo
2017-03-21 5:24 ` [PATCHv3 0/5] Dynamic growing data area support Nicholas A. Bellinger
2017-03-21 5:34 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490000964-15732-5-git-send-email-lixiubo@cmss.chinamobile.com \
--to=lixiubo@cmss.chinamobile.com \
--cc=agrover@redhat.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=namei.unix@gmail.com \
--cc=sheng@yasker.org \
--cc=shli@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.