All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PATCH 1/3] libqtest: Ignore QMP events when parsing the response for HMP commands
Date: Tue, 21 Mar 2017 11:39:50 +0100	[thread overview]
Message-ID: <1490092792-30957-2-git-send-email-thuth@redhat.com> (raw)
In-Reply-To: <1490092792-30957-1-git-send-email-thuth@redhat.com>

When running certain HMP commands (like "device_del") via QMP, we
can sometimes get a QMP event in the response first, so that the
"g_assert(ret)" statement in qtest_hmp() triggers and the test
fails. So ignore such QMP events when looking for the real
return value from QMP.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/libqtest.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/libqtest.c b/tests/libqtest.c
index a5c3d2b..c9b2d76 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -580,6 +580,12 @@ char *qtest_hmpv(QTestState *s, const char *fmt, va_list ap)
                      " 'arguments': {'command-line': %s}}",
                      cmd);
     ret = g_strdup(qdict_get_try_str(resp, "return"));
+    while (ret == NULL && qdict_get_try_str(resp, "event")) {
+        /* Ignore asynchronous QMP events */
+        QDECREF(resp);
+        resp = qtest_qmp_receive(s);
+        ret = g_strdup(qdict_get_try_str(resp, "return"));
+    }
     g_assert(ret);
     QDECREF(resp);
     g_free(cmd);
-- 
1.8.3.1

  reply	other threads:[~2017-03-21 10:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 10:39 [Qemu-devel] [PATCH 0/3] Add a tester for HMP commands Thomas Huth
2017-03-21 10:39 ` Thomas Huth [this message]
2017-03-23  8:52   ` [Qemu-devel] [PATCH 1/3] libqtest: Ignore QMP events when parsing the response " Stefan Hajnoczi
2017-03-23  8:59     ` Thomas Huth
2017-03-21 10:39 ` [Qemu-devel] [PATCH 2/3] libqtest: Add a generic function to run a callback function for every machine Thomas Huth
2017-03-23  8:53   ` Stefan Hajnoczi
2017-03-27 14:24   ` Dr. David Alan Gilbert
2017-03-28  6:35     ` Thomas Huth
2017-03-28  8:17       ` Dr. David Alan Gilbert
2017-03-29 15:59         ` Thomas Huth
2017-03-21 10:39 ` [Qemu-devel] [PATCH 3/3] tests: Add a tester for HMP commands Thomas Huth
2017-03-23  8:56   ` Stefan Hajnoczi
2017-03-27 13:31 ` [Qemu-devel] [PATCH 0/3] " Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490092792-30957-2-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.