From: Leo Yan <leo.yan@linaro.org> To: Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Wei Xu <xuwei5@hisilicon.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Stephen Boyd <sboyd@codeaurora.org>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Mike Leach <mike.leach@linaro.org>, Sudeep Holla <sudeep.holla@arm.com> Cc: Leo Yan <leo.yan@linaro.org> Subject: [PATCH v6 1/8] coresight: bindings for CPU debug module Date: Thu, 6 Apr 2017 21:30:54 +0800 [thread overview] Message-ID: <1491485461-22800-2-git-send-email-leo.yan@linaro.org> (raw) In-Reply-To: <1491485461-22800-1-git-send-email-leo.yan@linaro.org> According to ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter 'Part H: External debug', the CPU can integrate debug module and it can support self-hosted debug and external debug. Especially for supporting self-hosted debug, this means the program can access the debug module from mmio region; and usually the mmio region is integrated with coresight. So add document for binding debug component, includes binding to APB clock; and also need specify the CPU node which the debug module is dedicated to specific CPU. Suggested-by: Mike Leach <mike.leach@linaro.org> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Leo Yan <leo.yan@linaro.org> --- .../bindings/arm/coresight-cpu-debug.txt | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt diff --git a/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt new file mode 100644 index 0000000..2982912 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt @@ -0,0 +1,49 @@ +* CoreSight CPU Debug Component: + +CoreSight CPU debug component are compliant with the ARMv8 architecture +reference manual (ARM DDI 0487A.k) Chapter 'Part H: External debug'. The +external debug module is mainly used for two modes: self-hosted debug and +external debug, and it can be accessed from mmio region from Coresight +and eventually the debug module connects with CPU for debugging. And the +debug module provides sample-based profiling extension, which can be used +to sample CPU program counter, secure state and exception level, etc; +usually every CPU has one dedicated debug module to be connected. + +Required properties: + +- compatible : should be "arm,coresight-cpu-debug"; supplemented with + "arm,primecell" since this driver is using the AMBA bus + interface. + +- reg : physical base address and length of the register set. + +- clocks : the clock associated to this component. + +- clock-names : the name of the clock referenced by the code. Since we are + using the AMBA framework, the name of the clock providing + the interconnect should be "apb_pclk" and the clock is + mandatory. The interface between the debug logic and the + processor core is clocked by the internal CPU clock, so it + is enabled with CPU clock by default. + +- cpu : the CPU phandle the debug module is affined to. When omitted + the module is considered to belong to CPU0. + +Optional properties: + +- power-domains: a phandle to the debug power domain. We use "power-domains" + binding to turn on the debug logic if it has own dedicated + power domain and if necessary to use "cpuidle.off=1" or + "nohlt" in the kernel command line or sysfs node to + constrain idle states to ensure registers in the CPU power + domain are accessible. + +Example: + + debug@f6590000 { + compatible = "arm,coresight-cpu-debug","arm,primecell"; + reg = <0 0xf6590000 0 0x1000>; + clocks = <&sys_ctrl HI6220_DAPB_CLK>; + clock-names = "apb_pclk"; + cpu = <&cpu0>; + }; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: leo.yan@linaro.org (Leo Yan) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 1/8] coresight: bindings for CPU debug module Date: Thu, 6 Apr 2017 21:30:54 +0800 [thread overview] Message-ID: <1491485461-22800-2-git-send-email-leo.yan@linaro.org> (raw) In-Reply-To: <1491485461-22800-1-git-send-email-leo.yan@linaro.org> According to ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter 'Part H: External debug', the CPU can integrate debug module and it can support self-hosted debug and external debug. Especially for supporting self-hosted debug, this means the program can access the debug module from mmio region; and usually the mmio region is integrated with coresight. So add document for binding debug component, includes binding to APB clock; and also need specify the CPU node which the debug module is dedicated to specific CPU. Suggested-by: Mike Leach <mike.leach@linaro.org> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Leo Yan <leo.yan@linaro.org> --- .../bindings/arm/coresight-cpu-debug.txt | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt diff --git a/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt new file mode 100644 index 0000000..2982912 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt @@ -0,0 +1,49 @@ +* CoreSight CPU Debug Component: + +CoreSight CPU debug component are compliant with the ARMv8 architecture +reference manual (ARM DDI 0487A.k) Chapter 'Part H: External debug'. The +external debug module is mainly used for two modes: self-hosted debug and +external debug, and it can be accessed from mmio region from Coresight +and eventually the debug module connects with CPU for debugging. And the +debug module provides sample-based profiling extension, which can be used +to sample CPU program counter, secure state and exception level, etc; +usually every CPU has one dedicated debug module to be connected. + +Required properties: + +- compatible : should be "arm,coresight-cpu-debug"; supplemented with + "arm,primecell" since this driver is using the AMBA bus + interface. + +- reg : physical base address and length of the register set. + +- clocks : the clock associated to this component. + +- clock-names : the name of the clock referenced by the code. Since we are + using the AMBA framework, the name of the clock providing + the interconnect should be "apb_pclk" and the clock is + mandatory. The interface between the debug logic and the + processor core is clocked by the internal CPU clock, so it + is enabled with CPU clock by default. + +- cpu : the CPU phandle the debug module is affined to. When omitted + the module is considered to belong to CPU0. + +Optional properties: + +- power-domains: a phandle to the debug power domain. We use "power-domains" + binding to turn on the debug logic if it has own dedicated + power domain and if necessary to use "cpuidle.off=1" or + "nohlt" in the kernel command line or sysfs node to + constrain idle states to ensure registers in the CPU power + domain are accessible. + +Example: + + debug at f6590000 { + compatible = "arm,coresight-cpu-debug","arm,primecell"; + reg = <0 0xf6590000 0 0x1000>; + clocks = <&sys_ctrl HI6220_DAPB_CLK>; + clock-names = "apb_pclk"; + cpu = <&cpu0>; + }; -- 2.7.4
next prev parent reply other threads:[~2017-04-06 13:31 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-06 13:30 [PATCH v6 0/8] coresight: enable debug module Leo Yan 2017-04-06 13:30 ` Leo Yan 2017-04-06 13:30 ` Leo Yan 2017-04-06 13:30 ` Leo Yan [this message] 2017-04-06 13:30 ` [PATCH v6 1/8] coresight: bindings for CPU " Leo Yan 2017-04-06 13:30 ` [PATCH v6 2/8] doc: Add documentation for Coresight CPU debug Leo Yan 2017-04-06 13:30 ` Leo Yan [not found] ` <1491485461-22800-3-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-04-19 17:25 ` Mathieu Poirier 2017-04-19 17:25 ` Mathieu Poirier 2017-04-19 17:25 ` Mathieu Poirier 2017-04-06 13:30 ` [PATCH v6 3/8] coresight: of_get_coresight_platform_data: Add missing of_node_put Leo Yan 2017-04-06 13:30 ` Leo Yan 2017-04-18 15:09 ` Mathieu Poirier 2017-04-18 15:09 ` Mathieu Poirier 2017-04-06 13:30 ` [PATCH v6 4/8] coresight: refactor with function of_coresight_get_cpu Leo Yan 2017-04-06 13:30 ` Leo Yan 2017-04-06 13:30 ` [PATCH v6 5/8] coresight: use const for device_node structures Leo Yan 2017-04-06 13:30 ` Leo Yan [not found] ` <1491485461-22800-6-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-04-18 15:24 ` Mathieu Poirier 2017-04-18 15:24 ` Mathieu Poirier 2017-04-18 15:24 ` Mathieu Poirier [not found] ` <20170418152447.GB22806-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-04-18 23:13 ` Leo Yan 2017-04-18 23:13 ` Leo Yan 2017-04-18 23:13 ` Leo Yan [not found] ` <1491485461-22800-1-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-04-06 13:30 ` [PATCH v6 6/8] coresight: add support for CPU debug module Leo Yan 2017-04-06 13:30 ` Leo Yan 2017-04-06 13:30 ` Leo Yan [not found] ` <1491485461-22800-7-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2017-04-18 17:40 ` Mathieu Poirier 2017-04-18 17:40 ` Mathieu Poirier 2017-04-18 17:40 ` Mathieu Poirier 2017-04-19 0:18 ` Leo Yan 2017-04-19 0:18 ` Leo Yan 2017-04-19 14:52 ` Mathieu Poirier 2017-04-19 14:52 ` Mathieu Poirier 2017-04-19 14:52 ` Mathieu Poirier 2017-04-19 15:30 ` Leo Yan 2017-04-19 15:30 ` Leo Yan 2017-04-19 15:30 ` Leo Yan 2017-04-19 16:50 ` Mathieu Poirier 2017-04-19 16:50 ` Mathieu Poirier 2017-04-19 16:50 ` Mathieu Poirier 2017-04-19 13:23 ` Suzuki K Poulose 2017-04-19 13:23 ` Suzuki K Poulose 2017-04-19 14:28 ` Leo Yan 2017-04-19 14:28 ` Leo Yan 2017-04-19 14:32 ` Suzuki K Poulose 2017-04-19 14:32 ` Suzuki K Poulose 2017-04-19 14:32 ` Suzuki K Poulose 2017-04-19 15:07 ` Leo Yan 2017-04-19 15:07 ` Leo Yan 2017-04-19 17:49 ` Mathieu Poirier 2017-04-19 17:49 ` Mathieu Poirier 2017-04-19 17:49 ` Mathieu Poirier 2017-04-06 13:31 ` [PATCH v6 7/8] arm64: dts: hi6220: register " Leo Yan 2017-04-06 13:31 ` Leo Yan 2017-04-06 13:31 ` [PATCH v6 8/8] arm64: dts: qcom: msm8916: Add debug unit Leo Yan 2017-04-06 13:31 ` Leo Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1491485461-22800-2-git-send-email-leo.yan@linaro.org \ --to=leo.yan@linaro.org \ --cc=andy.gross@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=sudeep.holla@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=will.deacon@arm.com \ --cc=xuwei5@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.