From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "paolo.valente@linaro.org" <paolo.valente@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"fchecconi@gmail.com" <fchecconi@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"avanzini.arianna@gmail.com" <avanzini.arianna@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tj@kernel.org" <tj@kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH V3 00/16] Introduce the BFQ I/O scheduler
Date: Wed, 12 Apr 2017 15:30:30 +0000 [thread overview]
Message-ID: <1492011029.2764.3.camel@sandisk.com> (raw)
In-Reply-To: <17416A05-8401-4B03-B46C-78A8976C5B8E@linaro.org>
On Wed, 2017-04-12 at 08:01 +0200, Paolo Valente wrote:
> Where is my mistake?
I think in the Makefile. How about the patch below? Please note that I'm no
Kbuild expert.
diff --git a/block/Makefile b/block/Makefile
index 546066ee7fa6..b3711af6b637 100644
--- a/block/Makefile
+++ b/block/Makefile
@@ -20,7 +20,8 @@ obj-$(CONFIG_IOSCHED_NOOP) =A0=A0=A0+=3D noop-iosched.o
=A0obj-$(CONFIG_IOSCHED_DEADLINE) +=3D deadline-iosched.o
=A0obj-$(CONFIG_IOSCHED_CFQ) =A0=A0=A0=A0=A0+=3D cfq-iosched.o
=A0obj-$(CONFIG_MQ_IOSCHED_DEADLINE) =A0=A0=A0=A0=A0+=3D mq-deadline.o
-obj-$(CONFIG_IOSCHED_BFQ) =A0=A0=A0=A0=A0+=3D bfq-iosched.o bfq-wf2q.o bfq=
-cgroup.o
+bfq-y =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0:=3D bfq-iosched.o bfq-wf2q.o bfq-cgroup.o
+obj-$(CONFIG_IOSCHED_BFQ) =A0=A0=A0=A0=A0+=3D bfq.o
=A0=A0=A0obj-$(CONFIG_BLOCK_COMPAT) =A0=A0=A0=A0+=3D compat_ioctl.o
=A0obj-$(CONFIG_BLK_CMDLINE_PARSER) =A0=A0=A0=A0=A0=A0+=3D cmdline-parser.o
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "paolo.valente@linaro.org" <paolo.valente@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"fchecconi@gmail.com" <fchecconi@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"avanzini.arianna@gmail.com" <avanzini.arianna@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tj@kernel.org" <tj@kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH V3 00/16] Introduce the BFQ I/O scheduler
Date: Wed, 12 Apr 2017 15:30:30 +0000 [thread overview]
Message-ID: <1492011029.2764.3.camel@sandisk.com> (raw)
In-Reply-To: <17416A05-8401-4B03-B46C-78A8976C5B8E@linaro.org>
On Wed, 2017-04-12 at 08:01 +0200, Paolo Valente wrote:
> Where is my mistake?
I think in the Makefile. How about the patch below? Please note that I'm no
Kbuild expert.
diff --git a/block/Makefile b/block/Makefile
index 546066ee7fa6..b3711af6b637 100644
--- a/block/Makefile
+++ b/block/Makefile
@@ -20,7 +20,8 @@ obj-$(CONFIG_IOSCHED_NOOP) += noop-iosched.o
obj-$(CONFIG_IOSCHED_DEADLINE) += deadline-iosched.o
obj-$(CONFIG_IOSCHED_CFQ) += cfq-iosched.o
obj-$(CONFIG_MQ_IOSCHED_DEADLINE) += mq-deadline.o
-obj-$(CONFIG_IOSCHED_BFQ) += bfq-iosched.o bfq-wf2q.o bfq-cgroup.o
+bfq-y := bfq-iosched.o bfq-wf2q.o bfq-cgroup.o
+obj-$(CONFIG_IOSCHED_BFQ) += bfq.o
obj-$(CONFIG_BLOCK_COMPAT) += compat_ioctl.o
obj-$(CONFIG_BLK_CMDLINE_PARSER) += cmdline-parser.o
next prev parent reply other threads:[~2017-04-12 15:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 13:42 [PATCH V3 00/16] Introduce the BFQ I/O scheduler Paolo Valente
2017-04-11 13:43 ` [PATCH V3 01/16] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler Paolo Valente
2017-04-12 20:19 ` kbuild test robot
2017-04-12 21:49 ` kbuild test robot
2017-04-11 13:43 ` [PATCH V3 02/16] block, bfq: add full hierarchical scheduling and cgroups support Paolo Valente
2017-04-11 21:47 ` Tejun Heo
2017-04-12 5:22 ` Paolo Valente
2017-04-12 5:22 ` Paolo Valente
2017-04-18 7:04 ` Tejun Heo
2017-04-19 5:33 ` Paolo Valente
2017-04-19 5:33 ` Paolo Valente
2017-04-19 7:08 ` Paolo Valente
2017-04-19 7:08 ` Paolo Valente
2017-04-13 1:59 ` kbuild test robot
2017-04-11 13:43 ` [PATCH V3 03/16] block, bfq: improve throughput boosting Paolo Valente
2017-04-11 13:43 ` [PATCH V3 04/16] block, bfq: modify the peak-rate estimator Paolo Valente
2017-04-11 13:43 ` [PATCH V3 05/16] block, bfq: add more fairness with writes and slow processes Paolo Valente
2017-04-11 13:43 ` [PATCH V3 06/16] block, bfq: improve responsiveness Paolo Valente
2017-04-11 13:43 ` [PATCH V3 07/16] block, bfq: reduce I/O latency for soft real-time applications Paolo Valente
2017-04-11 13:43 ` [PATCH V3 08/16] block, bfq: preserve a low latency also with NCQ-capable drives Paolo Valente
2017-04-11 13:43 ` [PATCH V3 09/16] block, bfq: reduce latency during request-pool saturation Paolo Valente
2017-04-11 13:43 ` [PATCH V3 10/16] block, bfq: add Early Queue Merge (EQM) Paolo Valente
2017-04-11 13:43 ` [PATCH V3 11/16] block, bfq: reduce idling only in symmetric scenarios Paolo Valente
2017-04-11 13:43 ` [PATCH V3 12/16] block, bfq: boost the throughput on NCQ-capable flash-based devices Paolo Valente
2017-04-11 13:43 ` [PATCH V3 13/16] block, bfq: boost the throughput with random I/O on NCQ-capable HDDs Paolo Valente
2017-04-11 13:43 ` [PATCH V3 14/16] block, bfq: handle bursts of queue activations Paolo Valente
2017-04-11 13:43 ` [PATCH V3 15/16] block, bfq: remove all get and put of I/O contexts Paolo Valente
2017-04-11 13:43 ` [PATCH V3 16/16] block, bfq: split bfq-iosched.c into multiple source files Paolo Valente
2017-04-11 14:37 ` [PATCH V3 00/16] Introduce the BFQ I/O scheduler Bart Van Assche
2017-04-11 14:37 ` Bart Van Assche
2017-04-11 17:37 ` Paolo Valente
2017-04-11 17:37 ` Paolo Valente
2017-04-11 18:31 ` Bart Van Assche
2017-04-11 18:31 ` Bart Van Assche
2017-04-12 6:01 ` Paolo Valente
2017-04-12 6:01 ` Paolo Valente
2017-04-12 15:30 ` Bart Van Assche [this message]
2017-04-12 15:30 ` Bart Van Assche
2017-04-12 16:08 ` Paolo Valente
2017-04-12 16:08 ` Paolo Valente
2017-04-16 8:14 ` Heinz Diehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492011029.2764.3.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=avanzini.arianna@gmail.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=fchecconi@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.