All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org
Cc: joculator@gmail.com, al1img@gmail.com, vlad.babchuk@gmail.com,
	andrii.anisov@gmail.com, olekstysh@gmail.com,
	boris.ostrovsky@oracle.com, dmitry.torokhov@gmail.com,
	jgross@suse.com, andr2000@gmail.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH 1/2] xen/input: use string constants from PV protocol
Date: Thu, 13 Apr 2017 14:38:03 +0300	[thread overview]
Message-ID: <1492083484-31786-2-git-send-email-andr2000@gmail.com> (raw)
In-Reply-To: <1492083484-31786-1-git-send-email-andr2000@gmail.com>

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Xen input para-virtual protocol defines string constants
used by both back and frontend. Use those instead of
explicit strings in the frontend driver.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 drivers/input/misc/xen-kbdfront.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index 2fc7895373ab..01c27b4c3288 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -135,14 +135,17 @@ static int xenkbd_probe(struct xenbus_device *dev,
 		goto error_nomem;
 
 	/* Set input abs params to match backend screen res */
-	abs = xenbus_read_unsigned(dev->otherend, "feature-abs-pointer", 0);
-	ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend, "width",
+	abs = xenbus_read_unsigned(dev->otherend,
+				   XENKBD_FIELD_FEAT_ABS_POINTER, 0);
+	ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend,
+						  XENKBD_FIELD_WIDTH,
 						  ptr_size[KPARAM_X]);
-	ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend, "height",
+	ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend,
+						  XENKBD_FIELD_HEIGHT,
 						  ptr_size[KPARAM_Y]);
 	if (abs) {
 		ret = xenbus_write(XBT_NIL, dev->nodename,
-				   "request-abs-pointer", "1");
+				   XENKBD_FIELD_REQ_ABS_POINTER, "1");
 		if (ret) {
 			pr_warning("xenkbd: can't request abs-pointer");
 			abs = 0;
@@ -271,14 +274,15 @@ static int xenkbd_connect_backend(struct xenbus_device *dev,
 		xenbus_dev_fatal(dev, ret, "starting transaction");
 		goto error_irqh;
 	}
-	ret = xenbus_printf(xbt, dev->nodename, "page-ref", "%lu",
+	ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_RING_REF, "%lu",
 			    virt_to_gfn(info->page));
 	if (ret)
 		goto error_xenbus;
-	ret = xenbus_printf(xbt, dev->nodename, "page-gref", "%u", info->gref);
+	ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_RING_GREF,
+			    "%u", info->gref);
 	if (ret)
 		goto error_xenbus;
-	ret = xenbus_printf(xbt, dev->nodename, "event-channel", "%u",
+	ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_EVT_CHANNEL, "%u",
 			    evtchn);
 	if (ret)
 		goto error_xenbus;
@@ -353,7 +357,7 @@ static void xenkbd_backend_changed(struct xenbus_device *dev,
 }
 
 static const struct xenbus_device_id xenkbd_ids[] = {
-	{ "vkbd" },
+	{ XENKBD_DRIVER_NAME },
 	{ "" }
 };
 
@@ -390,4 +394,4 @@ module_exit(xenkbd_cleanup);
 
 MODULE_DESCRIPTION("Xen virtual keyboard/pointer device frontend");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("xen:vkbd");
+MODULE_ALIAS("xen:" XENKBD_DRIVER_NAME);
-- 
2.7.4

  parent reply	other threads:[~2017-04-13 11:38 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13 11:38 [PATCH 0/2] xen/input: add multi-touch support Oleksandr Andrushchenko
2017-04-13 11:38 ` [PATCH 1/2] xen/input: use string constants from PV protocol Oleksandr Andrushchenko
2017-04-13 11:38 ` Oleksandr Andrushchenko [this message]
2017-04-21  2:11   ` Dmitry Torokhov
2017-04-21  2:11   ` Dmitry Torokhov
2017-04-21  6:42     ` Oleksandr Andrushchenko
2017-04-21  6:42     ` Oleksandr Andrushchenko
2017-05-05  4:43       ` Oleksandr Andrushchenko
2017-05-12 13:43         ` Oleksandr Andrushchenko
2017-05-12 13:43         ` Oleksandr Andrushchenko
2017-05-22 13:24           ` Oleksandr Andrushchenko
2017-05-22 13:24           ` Oleksandr Andrushchenko
2017-05-05  4:43       ` Oleksandr Andrushchenko
2017-05-30 12:37     ` Oleksandr Andrushchenko
2017-05-30 12:37     ` Oleksandr Andrushchenko
2017-04-13 11:38 ` [PATCH 2/2] xen/input: add multi-touch support Oleksandr Andrushchenko
2017-04-13 11:38 ` Oleksandr Andrushchenko
2017-04-21  2:10   ` Dmitry Torokhov
2017-04-21  6:40     ` Oleksandr Andrushchenko
2017-04-21  6:40     ` Oleksandr Andrushchenko
2017-05-05  4:45       ` Oleksandr Andrushchenko
2017-05-12 13:44         ` Oleksandr Andrushchenko
2017-05-12 13:44         ` Oleksandr Andrushchenko
2017-05-22 13:25           ` Oleksandr Andrushchenko
2017-05-22 13:25           ` Oleksandr Andrushchenko
2017-05-05  4:45       ` Oleksandr Andrushchenko
2017-05-30  5:51       ` Dmitry Torokhov
2017-05-30 12:50         ` Oleksandr Andrushchenko
2017-05-30 12:50         ` Oleksandr Andrushchenko
2017-05-30 16:37           ` Dmitry Torokhov
2017-05-30 16:37           ` Dmitry Torokhov
2017-05-31  9:06             ` Oleksandr Andrushchenko
2017-06-07  7:15               ` Oleksandr Andrushchenko
2017-06-07  7:15               ` Oleksandr Andrushchenko
2017-06-07 16:56               ` Dmitry Torokhov
2017-06-07 16:56               ` Dmitry Torokhov
2017-06-08  6:45                 ` Oleksandr Andrushchenko
2017-06-19 10:00                   ` Oleksandr Andrushchenko
2017-06-19 10:00                   ` Oleksandr Andrushchenko
2017-06-21  7:24                   ` Dmitry Torokhov
2017-06-21  7:24                   ` Dmitry Torokhov
2017-06-21  8:54                     ` Oleksandr Andrushchenko
2017-06-21  8:54                     ` Oleksandr Andrushchenko
2017-06-08  6:45                 ` Oleksandr Andrushchenko
2017-05-31  9:06             ` Oleksandr Andrushchenko
2017-05-30  5:51       ` Dmitry Torokhov
2017-04-21  2:10   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492083484-31786-2-git-send-email-andr2000@gmail.com \
    --to=andr2000@gmail.com \
    --cc=al1img@gmail.com \
    --cc=andrii.anisov@gmail.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jgross@suse.com \
    --cc=joculator@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=olekstysh@gmail.com \
    --cc=vlad.babchuk@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.