From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 1/2] sg-report-flight: Do not try to print nonexistent FirstTip info
Date: Thu, 20 Apr 2017 13:07:24 +0000 [thread overview]
Message-ID: <1492693645-4714-1-git-send-email-ian.jackson@eu.citrix.com> (raw)
The use of $info->{FirstTip}{flight} autovivifies $info->{FirstTip}.
Defend $pinfo against the use of an autovivified empty hashref.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
sg-report-flight | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sg-report-flight b/sg-report-flight
index 7d2bc66..5b8f67a 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -586,7 +586,7 @@ sub print_pushgate_summary () {
my $f = $info->{$flightkey};
my $count = $info->{$countkey};
bodyprintf "%-20s", $what;
- if ($f) {
+ if ($f && %$f) {
bodyprintf(" %6d %s %4d days",
$f->{flight},
show_abs_time($f->{started}),
--
1.7.10.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2017-04-20 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 13:07 Ian Jackson [this message]
2017-04-20 13:07 ` [PATCH 2/2] sg-report-flight: Do not report many non-regressions as allowable Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492693645-4714-1-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.