All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
To: <dmitry.torokhov@gmail.com>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Martin Kepplinger <martin.kepplinger@ginzinger.com>
Subject: [PATCH 2/2] input: touchscreen: ar1021_i2c: replace magic number with definition
Date: Thu, 27 Apr 2017 14:22:36 +0200	[thread overview]
Message-ID: <1493295756-17812-2-git-send-email-martin.kepplinger@ginzinger.com> (raw)
In-Reply-To: <1493295756-17812-1-git-send-email-martin.kepplinger@ginzinger.com>

We now have a few of this device's definitions. Let's avoid magic numbers
and use them.

Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---
 drivers/input/touchscreen/ar1021_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
index 2a76231..edd5268 100644
--- a/drivers/input/touchscreen/ar1021_i2c.c
+++ b/drivers/input/touchscreen/ar1021_i2c.c
@@ -44,7 +44,7 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id)
 		goto out;
 
 	/* sync bit set ? */
-	if ((data[0] & 0x80) == 0)
+	if ((data[0] & AR1021_TOUCH) == 0)
 		goto out;
 
 	button = data[0] & BIT(0);
-- 
2.1.4

WARNING: multiple messages have this Message-ID (diff)
From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Martin Kepplinger <martin.kepplinger@ginzinger.com>
Subject: [PATCH 2/2] input: touchscreen: ar1021_i2c: replace magic number with definition
Date: Thu, 27 Apr 2017 14:22:36 +0200	[thread overview]
Message-ID: <1493295756-17812-2-git-send-email-martin.kepplinger@ginzinger.com> (raw)
In-Reply-To: <1493295756-17812-1-git-send-email-martin.kepplinger@ginzinger.com>

We now have a few of this device's definitions. Let's avoid magic numbers
and use them.

Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---
 drivers/input/touchscreen/ar1021_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
index 2a76231..edd5268 100644
--- a/drivers/input/touchscreen/ar1021_i2c.c
+++ b/drivers/input/touchscreen/ar1021_i2c.c
@@ -44,7 +44,7 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id)
 		goto out;
 
 	/* sync bit set ? */
-	if ((data[0] & 0x80) == 0)
+	if ((data[0] & AR1021_TOUCH) == 0)
 		goto out;
 
 	button = data[0] & BIT(0);
-- 
2.1.4

  reply	other threads:[~2017-04-27 12:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 12:22 [PATCH 1/2] input: touchscreen: ar1021_i2c: enable touch mode during open Martin Kepplinger
2017-04-27 12:22 ` Martin Kepplinger
2017-04-27 12:22 ` Martin Kepplinger [this message]
2017-04-27 12:22   ` [PATCH 2/2] input: touchscreen: ar1021_i2c: replace magic number with definition Martin Kepplinger
2017-04-28 17:06   ` Dmitry Torokhov
2017-04-30 19:38   ` [PATCH 2/2 v2] input: touchscreen: ar1021_i2c: use BIT to check for a bit Martin Kepplinger
2017-05-01 19:39     ` Dmitry Torokhov
2017-04-28 17:02 ` [PATCH 1/2] input: touchscreen: ar1021_i2c: enable touch mode during open Dmitry Torokhov
2018-02-05 10:07 ` Christian Gmeiner
2018-02-05 10:40   ` Martin Kepplinger
2018-02-16 16:38     ` Christian Gmeiner
2018-02-06  1:20   ` Dmitry Torokhov
2018-02-16 16:46     ` Christian Gmeiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493295756-17812-2-git-send-email-martin.kepplinger@ginzinger.com \
    --to=martin.kepplinger@ginzinger.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.