All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naveen M <naveen.m@intel.com>
To: alsa-devel@alsa-project.org
Cc: vinod.koul@intel.com, liam.r.girdwood@linux.intel.com,
	tiwai@suse.de, broonie@kernel.org, naveen.m@intel.com,
	Harsha Priya <harshapriya.n@intel.com>,
	pierre-louis.bossart@intel.com
Subject: [PATCH v3 3/7] ASoC: Intel: Create a helper to search for matching machine
Date: Mon, 15 May 2017 13:42:13 +0530	[thread overview]
Message-ID: <1494835937-22068-4-git-send-email-naveen.m@intel.com> (raw)
In-Reply-To: <1494835937-22068-1-git-send-email-naveen.m@intel.com>

Create a helper function to search for a matching machine
based on HID. No functional change

Signed-off-by: Naveen M <naveen.m@intel.com>
Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
---
 sound/soc/intel/common/sst-acpi.h       |  3 +++
 sound/soc/intel/common/sst-match-acpi.c | 19 +++++++++++++++----
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/sound/soc/intel/common/sst-acpi.h b/sound/soc/intel/common/sst-acpi.h
index 214e000..3649d3b 100644
--- a/sound/soc/intel/common/sst-acpi.h
+++ b/sound/soc/intel/common/sst-acpi.h
@@ -43,6 +43,9 @@ static inline bool sst_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
 /* acpi match */
 struct sst_acpi_mach *sst_acpi_find_machine(struct sst_acpi_mach *machines);
 
+/* acpi check hid */
+bool sst_acpi_check_hid(const u8 hid[ACPI_ID_LEN]);
+
 /* Descriptor for SST ASoC machine driver */
 struct sst_acpi_mach {
 	/* ACPI ID for the matching machine driver. Audio codec for instance */
diff --git a/sound/soc/intel/common/sst-match-acpi.c b/sound/soc/intel/common/sst-match-acpi.c
index 1070f3a..f4af3d1 100644
--- a/sound/soc/intel/common/sst-match-acpi.c
+++ b/sound/soc/intel/common/sst-match-acpi.c
@@ -63,15 +63,26 @@ static acpi_status sst_acpi_mach_match(acpi_handle handle, u32 level,
 	return AE_OK;
 }
 
+bool sst_acpi_check_hid(const u8 hid[ACPI_ID_LEN])
+{
+	acpi_status status;
+	bool found = false;
+
+	status = acpi_get_devices(hid, sst_acpi_mach_match, &found, NULL);
+
+	if (ACPI_FAILURE(status))
+		return false;
+
+	return found;
+}
+EXPORT_SYMBOL_GPL(sst_acpi_check_hid);
+
 struct sst_acpi_mach *sst_acpi_find_machine(struct sst_acpi_mach *machines)
 {
 	struct sst_acpi_mach *mach;
-	bool found = false;
 
 	for (mach = machines; mach->id[0]; mach++)
-		if (ACPI_SUCCESS(acpi_get_devices(mach->id,
-						  sst_acpi_mach_match,
-						  &found, NULL)) && found)
+		if (sst_acpi_check_hid(mach->id) == true)
 			return mach;
 	return NULL;
 }
-- 
1.9.1

  parent reply	other threads:[~2017-05-15  8:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15  8:12 [PATCH v3 0/7] ASoC: Intel: kabylake: Adds rt5663+max98927 machine driver Naveen M
2017-05-15  8:12 ` [PATCH v3 1/7] ASoC: Intel: Convert atom machine data to C99 style Naveen M
2017-05-24 17:41   ` Applied "ASoC: Intel: Convert atom machine data to C99 style" to the asoc tree Mark Brown
2017-05-15  8:12 ` [PATCH v3 2/7] ASoC: Intel: Convert skl machine data to C99 style Naveen M
2017-05-24 17:41   ` Applied "ASoC: Intel: Convert skl machine data to C99 style" to the asoc tree Mark Brown
2017-05-15  8:12 ` Naveen M [this message]
2017-05-15  8:12 ` [PATCH v3 4/7] ASoC: Move quirk to identify correct machine driver Naveen M
2017-05-15  8:12 ` [PATCH v3 5/7] ASoC: Improve machine driver selection based on quirk data Naveen M
2017-05-15  8:12 ` [PATCH v3 6/7] ASoC: Intel: Add Kabylake Realtek Maxim machine driver Naveen M
2017-05-15  8:12 ` [PATCH v3 7/7] ASoC: Intel: Add Kabylake RT5663+MAX98927 machine driver entry Naveen M
2017-05-15 10:54 ` [PATCH v3 0/7] ASoC: Intel: kabylake: Adds rt5663+max98927 machine driver Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494835937-22068-4-git-send-email-naveen.m@intel.com \
    --to=naveen.m@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=harshapriya.n@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=pierre-louis.bossart@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.