All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [OSSTEST PATCH] ts-examine-logs-save: Do not do readdir $! check
Date: Tue, 23 May 2017 19:07:53 +0100	[thread overview]
Message-ID: <1495562873-29798-1-git-send-email-ian.jackson@eu.citrix.com> (raw)

In perl 5.14 in Massachusetts, this produces this message
  /home/logs/logs/109694/test-amd64-amd64-examine Bad file descriptor at ./ts-examine-logs-save line 100.

Sadly this means there is no way to tell failure apart from end of
directory.  This patch should be reverted when we have a fixed version
of perl.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ts-examine-logs-save | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-examine-logs-save b/ts-examine-logs-save
index 014522a..b9c9941 100755
--- a/ts-examine-logs-save
+++ b/ts-examine-logs-save
@@ -97,7 +97,7 @@ sub save_logs () {
 	logm("saving $f");
 	link "$stash/$f", "$td/$f" or die "$stash $td $f $!";
     }
-    die "$stash $!" if $!;
+    # die "$stash $!" if $!;
     closedir D;
 }
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

                 reply	other threads:[~2017-05-23 18:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495562873-29798-1-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.