All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<horia.geanta@nxp.com>, <dan.douglass@nxp.com>,
	<giovanni.cabiddu@intel.com>, <salvatore.benedetto@intel.com>
Cc: <linux-crypto@vger.kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: [PATCH v4 07/14] crypto: dh - comply with crypto_kpp_maxsize()
Date: Thu, 25 May 2017 10:18:09 +0300	[thread overview]
Message-ID: <1495696696-22580-8-git-send-email-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <1495696696-22580-1-git-send-email-tudor.ambarus@microchip.com>

crypto_kpp_maxsize() asks for the output buffer size without
caring for errors. It allways assume that will be called after
a valid setkey. Comply with it and return what he wants.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 crypto/dh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/dh.c b/crypto/dh.c
index e151f12..b1032a5 100644
--- a/crypto/dh.c
+++ b/crypto/dh.c
@@ -147,7 +147,7 @@ static int dh_compute_value(struct kpp_request *req)
 	return ret;
 }
 
-static int dh_max_size(struct crypto_kpp *tfm)
+static unsigned int dh_max_size(struct crypto_kpp *tfm)
 {
 	struct dh_ctx *ctx = dh_get_ctx(tfm);
 
-- 
2.7.4

  parent reply	other threads:[~2017-05-25  7:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  7:18 [PATCH v4 00/14] fixes for kpp and akcipher Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 01/14] crypto: kpp, (ec)dh - fix typos Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 02/14] crypto: ecc - remove unused function arguments Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 03/14] crypto: ecc - remove unnecessary casts Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 04/14] crypto: ecc - don't be selfish on pubkeys Tudor Ambarus
2017-05-28 17:22   ` Horia Geantă
2017-05-29 14:11     ` Tudor Ambarus
2017-05-30 12:37       ` [PATCH v5 04/14] crypto: ecc - rename ecdh_make_pub_key() Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 05/14] crypto: dh - fix memleak in setkey Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 06/14] crypto: kpp: maxsize() - assume key is already set Tudor Ambarus
2017-05-25  7:18 ` Tudor Ambarus [this message]
2017-05-25  7:18 ` [PATCH v4 08/14] crypto: ecdh - comply with crypto_kpp_maxsize() Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 09/14] crypto: qat " Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 10/14] crypto: akcipher: maxsize() - assume key is already set Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 11/14] crypto: rsa - comply with crypto_akcipher_maxsize() Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 12/14] crypto: caampkc " Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 13/14] crypto: qat " Tudor Ambarus
2017-05-25  7:18 ` [PATCH v4 14/14] crypto: pkcs1pad " Tudor Ambarus
2017-06-10  4:17 ` [PATCH v4 00/14] fixes for kpp and akcipher Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495696696-22580-8-git-send-email-tudor.ambarus@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=dan.douglass@nxp.com \
    --cc=davem@davemloft.net \
    --cc=giovanni.cabiddu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=salvatore.benedetto@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.