All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, eblake@redhat.com,
	stefanha@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 30/31] qed: Use bdrv_co_* for coroutine_fns
Date: Fri, 16 Jun 2017 19:37:15 +0200	[thread overview]
Message-ID: <1497634636-20230-31-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1497634636-20230-1-git-send-email-kwolf@redhat.com>

All functions that are marked coroutine_fn can directly call the
bdrv_co_* version of functions instead of going through the wrapper.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qed.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/block/qed.c b/block/qed.c
index 48f2b0e..c073baa 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -116,7 +116,7 @@ static int coroutine_fn qed_write_header(BDRVQEDState *s)
     };
     qemu_iovec_init_external(&qiov, &iov, 1);
 
-    ret = bdrv_preadv(s->bs->file, 0, &qiov);
+    ret = bdrv_co_preadv(s->bs->file, 0, qiov.size, &qiov, 0);
     if (ret < 0) {
         goto out;
     }
@@ -124,7 +124,7 @@ static int coroutine_fn qed_write_header(BDRVQEDState *s)
     /* Update header */
     qed_header_cpu_to_le(&s->header, (QEDHeader *) buf);
 
-    ret = bdrv_pwritev(s->bs->file, 0, &qiov);
+    ret = bdrv_co_pwritev(s->bs->file, 0, qiov.size,  &qiov, 0);
     if (ret < 0) {
         goto out;
     }
@@ -796,7 +796,7 @@ static int coroutine_fn qed_read_backing_file(BDRVQEDState *s, uint64_t pos,
     qemu_iovec_concat(*backing_qiov, qiov, 0, size);
 
     BLKDBG_EVENT(s->bs->file, BLKDBG_READ_BACKING_AIO);
-    ret = bdrv_preadv(s->bs->backing, pos, *backing_qiov);
+    ret = bdrv_co_preadv(s->bs->backing, pos, size, *backing_qiov, 0);
     if (ret < 0) {
         return ret;
     }
@@ -844,7 +844,7 @@ static int coroutine_fn qed_copy_from_backing_file(BDRVQEDState *s,
     }
 
     BLKDBG_EVENT(s->bs->file, BLKDBG_COW_WRITE);
-    ret = bdrv_pwritev(s->bs->file, offset, &qiov);
+    ret = bdrv_co_pwritev(s->bs->file, offset, qiov.size, &qiov, 0);
     if (ret < 0) {
         goto out;
     }
@@ -987,7 +987,8 @@ static int coroutine_fn qed_aio_write_main(QEDAIOCB *acb)
     trace_qed_aio_write_main(s, acb, 0, offset, acb->cur_qiov.size);
 
     BLKDBG_EVENT(s->bs->file, BLKDBG_WRITE_AIO);
-    ret = bdrv_pwritev(s->bs->file, offset, &acb->cur_qiov);
+    ret = bdrv_co_pwritev(s->bs->file, offset, acb->cur_qiov.size,
+                          &acb->cur_qiov, 0);
     if (ret < 0) {
         return ret;
     }
@@ -1004,7 +1005,7 @@ static int coroutine_fn qed_aio_write_main(QEDAIOCB *acb)
              * region.  The solution is to flush after writing a new data
              * cluster and before updating the L2 table.
              */
-            ret = bdrv_flush(s->bs->file->bs);
+            ret = bdrv_co_flush(s->bs->file->bs);
             if (ret < 0) {
                 return ret;
             }
@@ -1221,7 +1222,8 @@ static int coroutine_fn qed_aio_read_data(void *opaque, int ret,
     }
 
     BLKDBG_EVENT(bs->file, BLKDBG_READ_AIO);
-    ret = bdrv_preadv(bs->file, offset, &acb->cur_qiov);
+    ret = bdrv_co_preadv(bs->file, offset, acb->cur_qiov.size,
+                         &acb->cur_qiov, 0);
     if (ret < 0) {
         return ret;
     }
-- 
1.8.3.1

  parent reply	other threads:[~2017-06-16 17:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16 17:36 [Qemu-devel] [PATCH v2 00/31] qed: Convert to coroutines Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 01/31] qed: Use bottom half to resume waiting requests Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 02/31] qed: Make qed_read_table() synchronous Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 03/31] qed: Remove callback from qed_read_table() Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 04/31] qed: Remove callback from qed_read_l2_table() Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 05/31] qed: Remove callback from qed_find_cluster() Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 06/31] qed: Make qed_read_backing_file() synchronous Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 07/31] qed: Make qed_copy_from_backing_file() synchronous Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 08/31] qed: Remove callback from qed_copy_from_backing_file() Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 09/31] qed: Make qed_write_header() synchronous Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 10/31] qed: Remove callback from qed_write_header() Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 11/31] qed: Make qed_write_table() synchronous Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 12/31] qed: Remove GenericCB Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 13/31] qed: Remove callback from qed_write_table() Kevin Wolf
2017-06-16 17:36 ` [Qemu-devel] [PATCH v2 14/31] qed: Make qed_aio_read_data() synchronous Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 15/31] qed: Make qed_aio_write_main() synchronous Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 16/31] qed: Inline qed_commit_l2_update() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 17/31] qed: Add return value to qed_aio_write_l1_update() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 18/31] qed: Add return value to qed_aio_write_l2_update() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 19/31] qed: Add return value to qed_aio_write_main() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 20/31] qed: Add return value to qed_aio_write_cow() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 21/31] qed: Add return value to qed_aio_write_inplace/alloc() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 22/31] qed: Add return value to qed_aio_read/write_data() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 23/31] qed: Remove ret argument from qed_aio_next_io() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 24/31] qed: Remove recursion in qed_aio_next_io() Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 25/31] qed: Implement .bdrv_co_readv/writev Kevin Wolf
2017-06-17 11:36   ` [Qemu-devel] [Qemu-block] " Manos Pitsidianakis
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 26/31] qed: Use CoQueue for serialising allocations Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 27/31] qed: Simplify request handling Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 28/31] qed: Use a coroutine for need_check_timer Kevin Wolf
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 29/31] qed: Add coroutine_fn to I/O path functions Kevin Wolf
2017-06-16 17:37 ` Kevin Wolf [this message]
2017-06-17 11:41   ` [Qemu-devel] [Qemu-block] [PATCH v2 30/31] qed: Use bdrv_co_* for coroutine_fns Manos Pitsidianakis
2017-06-16 17:37 ` [Qemu-devel] [PATCH v2 31/31] block: Remove bdrv_aio_readv/writev/flush() Kevin Wolf
2017-06-19 15:24 ` [Qemu-devel] [PATCH v2 00/31] qed: Convert to coroutines Stefan Hajnoczi
2017-06-22 16:58 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497634636-20230-31-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.