From: Joe Perches <joe@perches.com> To: Aravind Thokala <aravind.thk@gmail.com>, Mark Brown <broonie@kernel.org>, Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] spi/bcm63xx: Fix checkpatch warnings Date: Mon, 19 Jun 2017 12:42:18 -0700 [thread overview] Message-ID: <1497901338.8495.50.camel@perches.com> (raw) In-Reply-To: <1497896268-5613-1-git-send-email-aravind.thk@gmail.com> On Mon, 2017-06-19 at 23:47 +0530, Aravind Thokala wrote: > This patch fixes the checkpatch.pl warnings on the driver > file. [] > diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c [] > @@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs, > #endif > } > > -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { > +static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { > { 20000000, SPI_CLK_20MHZ }, > { 12500000, SPI_CLK_12_50MHZ }, > { 6250000, SPI_CLK_6_250MHZ }, It's probably better to change this array into a struct to make the indexing more obvious. Also the SPI_CLK_MASK uses are a bit obscure. Perhaps: --- diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index 247f71b02235..3cb8d92ee870 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -191,7 +191,10 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs, #endif } -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { +static const struct { + unsigned int speed; + unsigned int index; +} bcm63xx_spi_freq_table[] = { { 20000000, SPI_CLK_20MHZ }, { 12500000, SPI_CLK_12_50MHZ }, { 6250000, SPI_CLK_6_250MHZ }, @@ -213,8 +216,8 @@ static void bcm63xx_spi_setup_transfer(struct spi_device *spi, /* Find the closest clock configuration */ for (i = 0; i < SPI_CLK_MASK; i++) { - if (t->speed_hz >= bcm63xx_spi_freq_table[i][0]) { - clk_cfg = bcm63xx_spi_freq_table[i][1]; + if (t->speed_hz >= bcm63xx_spi_freq_table[i].speed) { + clk_cfg = bcm63xx_spi_freq_table[i].index; break; } }
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] spi/bcm63xx: Fix checkpatch warnings Date: Mon, 19 Jun 2017 12:42:18 -0700 [thread overview] Message-ID: <1497901338.8495.50.camel@perches.com> (raw) In-Reply-To: <1497896268-5613-1-git-send-email-aravind.thk@gmail.com> On Mon, 2017-06-19 at 23:47 +0530, Aravind Thokala wrote: > This patch fixes the checkpatch.pl warnings on the driver > file. [] > diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c [] > @@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs, > #endif > } > > -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { > +static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { > { 20000000, SPI_CLK_20MHZ }, > { 12500000, SPI_CLK_12_50MHZ }, > { 6250000, SPI_CLK_6_250MHZ }, It's probably better to change this array into a struct to make the indexing more obvious. Also the SPI_CLK_MASK uses are a bit obscure. Perhaps: --- diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index 247f71b02235..3cb8d92ee870 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -191,7 +191,10 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs, ?#endif ?} ? -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { +static const struct { + unsigned int speed; + unsigned int index; +} bcm63xx_spi_freq_table[] = { ? { 20000000, SPI_CLK_20MHZ }, ? { 12500000, SPI_CLK_12_50MHZ }, ? {??6250000, SPI_CLK_6_250MHZ }, @@ -213,8 +216,8 @@ static void bcm63xx_spi_setup_transfer(struct spi_device *spi, ? ? /* Find the closest clock configuration */ ? for (i = 0; i < SPI_CLK_MASK; i++) { - if (t->speed_hz >= bcm63xx_spi_freq_table[i][0]) { - clk_cfg = bcm63xx_spi_freq_table[i][1]; + if (t->speed_hz >= bcm63xx_spi_freq_table[i].speed) { + clk_cfg = bcm63xx_spi_freq_table[i].index; ? break; ? } ? }
next prev parent reply other threads:[~2017-06-19 19:42 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-19 18:17 [PATCH v2] spi/bcm63xx: Fix checkpatch warnings Aravind Thokala 2017-06-19 18:17 ` Aravind Thokala 2017-06-19 19:42 ` Joe Perches [this message] 2017-06-19 19:42 ` Joe Perches 2017-06-19 20:07 ` Joe Perches 2017-06-19 20:07 ` Joe Perches 2017-06-19 20:07 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1497901338.8495.50.camel@perches.com \ --to=joe@perches.com \ --cc=aravind.thk@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=broonie@kernel.org \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.