From: Bhumika Goyal <bhumirks@gmail.com> To: julia.lawall@lip6.fr, maxime.ripard@free-electrons.com, airlied@linux.ie, wens@csie.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.yao@rock-chips.com, heiko@sntech.de, linux-rockchip@lists.infradead.org Cc: Bhumika Goyal <bhumirks@gmail.com> Subject: [PATCH v2 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures Date: Wed, 21 Jun 2017 12:01:10 +0530 [thread overview] Message-ID: <1498026670-10671-3-git-send-email-bhumirks@gmail.com> (raw) In-Reply-To: <1498026670-10671-1-git-send-email-bhumirks@gmail.com> Add const to drm_encoder_helper_funcs structures as they are only passed as an argument to the function drm_encoder_helper_add and this argument is of type const. So, add const to these structures. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- Changes in v2 - * Let the line exceed over 80 characters while adding const. drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index 9606121..b64cadc 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -252,7 +252,7 @@ rockchip_dp_drm_encoder_atomic_check(struct drm_encoder *encoder, return 0; } -static struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { +static const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { .mode_fixup = rockchip_dp_drm_encoder_mode_fixup, .mode_set = rockchip_dp_drm_encoder_mode_set, .enable = rockchip_dp_drm_encoder_enable, diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 7d9b75e..4ab9fad 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -530,7 +530,7 @@ inno_hdmi_encoder_atomic_check(struct drm_encoder *encoder, return 0; } -static struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { +static const struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { .enable = inno_hdmi_encoder_enable, .disable = inno_hdmi_encoder_disable, .mode_fixup = inno_hdmi_encoder_mode_fixup, -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: bhumirks@gmail.com (Bhumika Goyal) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures Date: Wed, 21 Jun 2017 12:01:10 +0530 [thread overview] Message-ID: <1498026670-10671-3-git-send-email-bhumirks@gmail.com> (raw) In-Reply-To: <1498026670-10671-1-git-send-email-bhumirks@gmail.com> Add const to drm_encoder_helper_funcs structures as they are only passed as an argument to the function drm_encoder_helper_add and this argument is of type const. So, add const to these structures. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- Changes in v2 - * Let the line exceed over 80 characters while adding const. drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index 9606121..b64cadc 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -252,7 +252,7 @@ rockchip_dp_drm_encoder_atomic_check(struct drm_encoder *encoder, return 0; } -static struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { +static const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = { .mode_fixup = rockchip_dp_drm_encoder_mode_fixup, .mode_set = rockchip_dp_drm_encoder_mode_set, .enable = rockchip_dp_drm_encoder_enable, diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 7d9b75e..4ab9fad 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -530,7 +530,7 @@ inno_hdmi_encoder_atomic_check(struct drm_encoder *encoder, return 0; } -static struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { +static const struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { .enable = inno_hdmi_encoder_enable, .disable = inno_hdmi_encoder_disable, .mode_fixup = inno_hdmi_encoder_mode_fixup, -- 2.7.4
next prev parent reply other threads:[~2017-06-21 6:33 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-21 6:31 [PATCH v2 0/2] drm: constify drm_encoder_helper_funcs structures Bhumika Goyal 2017-06-21 6:31 ` Bhumika Goyal 2017-06-21 6:31 ` [PATCH v2 2/2] drm/sun4i: add const to " Bhumika Goyal 2017-06-21 6:31 ` Bhumika Goyal 2017-06-21 6:31 ` Bhumika Goyal [this message] 2017-06-21 6:31 ` [PATCH v2 1/2] drm/rockchip: " Bhumika Goyal 2017-06-21 6:36 ` Mark yao 2017-06-21 6:36 ` Mark yao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1498026670-10671-3-git-send-email-bhumirks@gmail.com \ --to=bhumirks@gmail.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=heiko@sntech.de \ --cc=julia.lawall@lip6.fr \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.yao@rock-chips.com \ --cc=maxime.ripard@free-electrons.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.